Bug #75027 for Net-SSLeay: Missing openssl constants

Wed Feb 15 09:38:21 2012 kmx [...] volny.cz - Ticket created

Subject:	Missing openssl constants
Date:	Wed, 15 Feb 2012 15:38:10 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Here comes my proposal to add couple more constants: X509_V_FLAG_CHECK_SS_SIGNATURE X509_V_FLAG_EXTENDED_CRL_SUPPORT X509_V_FLAG_POLICY_MASK X509_V_FLAG_USE_DELTAS (SSL_)ERROR_WANT_ACCEPT (SSL_)OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION (SSL_)OP_CISCO_ANYCONNECT (SSL_)OP_CRYPTOPRO_TLSEXT_BUG (SSL_)OP_LEGACY_SERVER_CONNECT (SSL_)OP_NO_TLSv1_1 (SSL_)OP_NO_TLSv1_2 (SSL_)OP_SINGLE_ECDH_USE (SSL_)OP_TLS_BLOCK_PADDING_BUG These are just IMHO obvious cases where probably the additional constants were introduced in newer versions of openssl and not added to Net::SSLeay. To be honest I have no idea how was constants.c generated thus I do not know how to add them. It also might be worth adding the new constants to @EXPORT. -- kmx

Wed Feb 15 16:58:25 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 16 Feb 2012 07:58:18 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, Yes, that looks fine. Cheers. On Wednesday, February 15, 2012 09:38:23 AM you wrote: Show quoted text

> Wed Feb 15 09:38:21 2012: Request 75027 was acted upon. > Transaction: Ticket created by kmx@volny.cz > Queue: Net-SSLeay > Subject: Missing openssl constants > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: kmx@volny.cz > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > > Here comes my proposal to add couple more constants: > > X509_V_FLAG_CHECK_SS_SIGNATURE > X509_V_FLAG_EXTENDED_CRL_SUPPORT > X509_V_FLAG_POLICY_MASK > X509_V_FLAG_USE_DELTAS > (SSL_)ERROR_WANT_ACCEPT > (SSL_)OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION > (SSL_)OP_CISCO_ANYCONNECT > (SSL_)OP_CRYPTOPRO_TLSEXT_BUG > (SSL_)OP_LEGACY_SERVER_CONNECT > (SSL_)OP_NO_TLSv1_1 > (SSL_)OP_NO_TLSv1_2 > (SSL_)OP_SINGLE_ECDH_USE > (SSL_)OP_TLS_BLOCK_PADDING_BUG > > These are just IMHO obvious cases where probably the additional > constants were introduced in newer versions of openssl and not added to > Net::SSLeay. > > To be honest I have no idea how was constants.c generated thus I do not > know how to add them. > > It also might be worth adding the new constants to @EXPORT. > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Feb 15 16:58:25 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 12 17:26:32 2012 kmx [...] cpan.org - Correspondence added

I have some research as regards constants and there are basically two issues:

1/ constant.c seem to be a generated code I just do not know by which means it was generated - I have found ExtUtils::Constant::XS which seems to be able to do the same job

2/ the constant names are slightly modified - constants starting with "SSL_" (e.g. SSL_CONST_NAME) are accessible from perl as CONST_NAME whereas OTHER_CONST_NAME is accessible from perl as OTHER_CONST_NAME (which makes it hard to autogenerate with ExtUtils::Constant::XS)

Have you any idea how to extend constant set with a minimum of work needed?
Or is it worth a big shift towards ExtUtils::Constant::XS or similar module?

--
kmx

Mon Mar 12 17:35:51 2012 kmx [...] cpan.org - Correspondence added

and one more thing:

3/ there is a bunch of constants in constants.c that are not available in openssl-0.9.3 or any higher version

--
kmx

Mon Mar 12 17:49:46 2012 kmx [...] cpan.org - Correspondence added

plus:

4/ constant.c seems to contain some textual constants like TXT_DES_192_EDE3_CBC_WITH_MD5 which IMHO are not working

--
kmx

Tue Mar 13 07:08:38 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Tue, 13 Mar 2012 12:07:59 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

I have played with ExtUtils::Constant and reimplemented the constants.c generation (no new constants added yet). See new_constant_generator_r310.diff - it is just an idea I do no insist on this particular approach. Adding a new constant means: 1/ add new constant name in __DATA__ section of helper_script/regen_openssl_constants_c.pl 2/ run helper_script/regen_openssl_constants_c.pl from Net::SSLeay dist directory 3/ run: perl Makefile.PL && make && make test My doubts: a/ I am still not sure whether 'double' is the best return type for constant function b/ A deeper redesign might be better (we can use more of ExtUtils::Constant capabilities - e.g. support also string constants) c/ It might be better to have some kind of automatic dependency in generated makefile (helper_script/regen_openssl_constants_c.pl >> constants.c >> SSLeay.xs) Anyway from my point of view I am just after adding couple of new constants - whatever that allows me this will be fine. -- kmx

Message body is not shown because sender requested not to inline it.

Tue Mar 13 09:26:29 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Tue, 13 Mar 2012 14:25:54 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Improved version - new_constant_generator_V2_r310.diff - fixing my doubt c/ -- kmx

Message body is not shown because sender requested not to inline it.

Tue Mar 13 15:41:39 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Tue, 13 Mar 2012 20:41:28 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

I have done a deep research on openssl from 0.9.6 to 1.0.1-beta2 and it turns out that nearly 100 constants (see enclosed never_used_constants.txt) seem to be expected by constants.c but do not occur in any openssl version starting 0.9.6. I propose removing them. -- kmx

Message body is not shown because sender requested not to inline it.

Tue Mar 13 17:29:55 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 07:29:33 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Cheers. On Tuesday, March 13, 2012 03:41:41 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > I have done a deep research on openssl from 0.9.6 to 1.0.1-beta2 and it > turns out that nearly 100 constants (see enclosed > never_used_constants.txt) seem to be expected by constants.c but do not > occur in any openssl version starting 0.9.6. > > I propose removing them.

Approved. Cheers. Show quoted text

> > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 13 19:09:03 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 09:08:41 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, do you want this one applied now? Has it been tested on Windows? On Tuesday, March 13, 2012 09:26:31 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > Improved version - new_constant_generator_V2_r310.diff - fixing my doubt c/ > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 13 19:14:46 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 00:14:35 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Show quoted text

> do you want this one applied now? >

Please no, I am working on improved version - it is tested mostly on Windows. -- kmx

Tue Mar 13 19:49:32 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 00:48:56 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

So, here it is: new_constant_generator_V3_r311.diff 1/ I have removed all constants I guess are no more relevant (maybe they come from pre-0.9.6 era) 2/ I have also removed them from @EXPORT_OK in SSLeay.pm 3/ I have updated constants list included in SSLeay.pod 4/ There is helper_script\regen_openssl_constants.pl used for automatic generation of constants.c + t/local/21_constants.t 5/ There is a kind of ugly hack in Makefile.PL that assures that after editing helper_script\regen_openssl_constants.pl both constants.c + t/local/21_constants.t will be regenerated I have not added any new constants yet - this commit should keep the same bahaviour of Net::SSLeay (at least for openssl 0.9.6+). As for the new constants (which come in a separate commit) my current list contains these candidates: ASN1_STRFLGS_ESC_CTRL ASN1_STRFLGS_ESC_MSB ASN1_STRFLGS_ESC_QUOTE ASN1_STRFLGS_RFC2253 EVP_PKS_DSA EVP_PKS_EC EVP_PKS_RSA EVP_PKT_ENC EVP_PKT_EXCH EVP_PKT_EXP EVP_PKT_SIGN EVP_PK_DH EVP_PK_DSA EVP_PK_EC EVP_PK_RSA MBSTRING_ASC MBSTRING_BMP MBSTRING_FLAG MBSTRING_UNIV MBSTRING_UTF8 SSL_ERROR_WANT_ACCEPT SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION SSL_OP_CISCO_ANYCONNECT SSL_OP_CRYPTOPRO_TLSEXT_BUG SSL_OP_LEGACY_SERVER_CONNECT SSL_OP_NO_TLSv1_1 SSL_OP_NO_TLSv1_2 SSL_OP_SINGLE_ECDH_USE SSL_OP_TLS_BLOCK_PADDING_BUG X509V3_EXT_CTX_DEP X509V3_EXT_DYNAMIC X509V3_EXT_MULTILINE X509_V_FLAG_CHECK_SS_SIGNATURE X509_V_FLAG_EXTENDED_CRL_SUPPORT X509_V_FLAG_POLICY_MASK X509_V_FLAG_USE_DELTAS X509_V_OK XN_FLAG_COMPAT XN_FLAG_DN_REV XN_FLAG_DUMP_UNKNOWN_FIELDS XN_FLAG_FN_ALIGN XN_FLAG_FN_LN XN_FLAG_FN_MASK XN_FLAG_FN_NONE XN_FLAG_FN_OID XN_FLAG_FN_SN XN_FLAG_MULTILINE XN_FLAG_ONELINE XN_FLAG_RFC2253 XN_FLAG_SEP_COMMA_PLUS XN_FLAG_SEP_CPLUS_SPC XN_FLAG_SEP_MASK XN_FLAG_SEP_MULTILINE XN_FLAG_SEP_SPLUS_SPC XN_FLAG_SPC_EQ -- kmx

Message body is not shown because sender requested not to inline it.

Wed Mar 14 03:01:59 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 17:01:33 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, nice work! Committed at 312. Cheers. On Tuesday, March 13, 2012 07:49:34 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > So, here it is: new_constant_generator_V3_r311.diff > > 1/ I have removed all constants I guess are no more relevant (maybe they > come from pre-0.9.6 era) > 2/ I have also removed them from @EXPORT_OK in SSLeay.pm > 3/ I have updated constants list included in SSLeay.pod > 4/ There is helper_script\regen_openssl_constants.pl used for automatic > generation of constants.c + t/local/21_constants.t > 5/ There is a kind of ugly hack in Makefile.PL that assures that after > editing helper_script\regen_openssl_constants.pl both constants.c + > t/local/21_constants.t will be regenerated > > I have not added any new constants yet - this commit should keep the > same bahaviour of Net::SSLeay (at least for openssl 0.9.6+). > > As for the new constants (which come in a separate commit) my current > list contains these candidates: > ASN1_STRFLGS_ESC_CTRL > ASN1_STRFLGS_ESC_MSB > ASN1_STRFLGS_ESC_QUOTE > ASN1_STRFLGS_RFC2253 > EVP_PKS_DSA > EVP_PKS_EC > EVP_PKS_RSA > EVP_PKT_ENC > EVP_PKT_EXCH > EVP_PKT_EXP > EVP_PKT_SIGN > EVP_PK_DH > EVP_PK_DSA > EVP_PK_EC > EVP_PK_RSA > MBSTRING_ASC > MBSTRING_BMP > MBSTRING_FLAG > MBSTRING_UNIV > MBSTRING_UTF8 > SSL_ERROR_WANT_ACCEPT > SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION > SSL_OP_CISCO_ANYCONNECT > SSL_OP_CRYPTOPRO_TLSEXT_BUG > SSL_OP_LEGACY_SERVER_CONNECT > SSL_OP_NO_TLSv1_1 > SSL_OP_NO_TLSv1_2 > SSL_OP_SINGLE_ECDH_USE > SSL_OP_TLS_BLOCK_PADDING_BUG > X509V3_EXT_CTX_DEP > X509V3_EXT_DYNAMIC > X509V3_EXT_MULTILINE > X509_V_FLAG_CHECK_SS_SIGNATURE > X509_V_FLAG_EXTENDED_CRL_SUPPORT > X509_V_FLAG_POLICY_MASK > X509_V_FLAG_USE_DELTAS > X509_V_OK > XN_FLAG_COMPAT > XN_FLAG_DN_REV > XN_FLAG_DUMP_UNKNOWN_FIELDS > XN_FLAG_FN_ALIGN > XN_FLAG_FN_LN > XN_FLAG_FN_MASK > XN_FLAG_FN_NONE > XN_FLAG_FN_OID > XN_FLAG_FN_SN > XN_FLAG_MULTILINE > XN_FLAG_ONELINE > XN_FLAG_RFC2253 > XN_FLAG_SEP_COMMA_PLUS > XN_FLAG_SEP_CPLUS_SPC > XN_FLAG_SEP_MASK > XN_FLAG_SEP_MULTILINE > XN_FLAG_SEP_SPLUS_SPC > XN_FLAG_SPC_EQ > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Mar 14 05:18:25 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 10:18:15 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

You have probably forgotten to add these 2 files: t/local/21_constants.t helper_script\regen_openssl_constants.pl -- kmx

Wed Mar 14 05:39:01 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 19:38:18 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi. Again :-( Sorry Fixed. Cheers. On Wednesday, March 14, 2012 05:18:26 AM kmx via RT wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > You have probably forgotten to add these 2 files: > > t/local/21_constants.t > helper_script\regen_openssl_constants.pl > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Mar 14 07:12:05 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 12:11:54 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Call for opinion: We have 51 constants (out of total 349) available in Net::SSLeay that are not in @EXPORT_OK Do we want to keep all available constants also in SSLeeay.pm's @EXPORT_OK ? (if yes I have a *.t test for this) -- kmx

Wed Mar 14 07:45:25 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 21:45:02 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, On Wednesday, March 14, 2012 07:12:07 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > Call for opinion: > > We have 51 constants (out of total 349) available in Net::SSLeay that > are not in @EXPORT_OK > > Do we want to keep all available constants also in SSLeeay.pm's > @EXPORT_OK ? (if yes I have a *.t test for this)

Either all or none :-) Cheers. Show quoted text

> > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Mar 14 08:10:40 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 14 Mar 2012 13:10:17 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Show quoted text

> Either all or none :-) >

So to be backwards compatible we need them all - see: constants_export_ok_and_related.diff -- kmx

Message body is not shown because sender requested not to inline it.

Wed Mar 14 17:52:15 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 15 Mar 2012 07:51:50 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, thanks for that. Tests fine here. Committed to 314 Cheers. On Wednesday, March 14, 2012 08:10:41 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > >

> > Either all or none :-)

> > So to be backwards compatible we need them all - see: > constants_export_ok_and_related.diff > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Thu Mar 15 02:25:34 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 15 Mar 2012 07:25:09 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

So finally after we have a new system for constants auto-generation in place I can add my new wanted constants - see new_constants_r314.diff List of added constants is in Changes -- kmx

Message body is not shown because sender requested not to inline it.

Thu Mar 15 02:40:45 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 15 Mar 2012 16:40:21 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, tests OK, but I see this during make: ### do not forget to update (manually) SSLeay.pod(constants list) + SSLeay.pm(@EXPORT_OK) Is that intentional? Its likely to scare people :-) Cheers. On Thursday, March 15, 2012 02:25:35 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > So finally after we have a new system for constants auto-generation in > place I can add my new wanted constants - see new_constants_r314.diff > > List of added constants is in Changes > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Thu Mar 15 04:44:47 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 15 Mar 2012 09:44:36 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Show quoted text

> tests OK, but I see this during make: > > ### do not forget to update (manually) SSLeay.pod(constants list) + > SSLeay.pm(@EXPORT_OK) > > Is that intentional? Its likely to scare people :-) >

It is intentional; however it should happen only when when the timespamp on helper_script/regen_openssl_constants.pl file is newer than timestamp on constants.c In other words if you try to run again: make clean perl Makefile.PL make It should not warn anymore. The idea (not sure if it is a good one) is that after modification of helper_script/regen_openssl_constants.pl (e.g. adding the new constant) user should be reminded to update those two things (1/ SSLeay.pod/constants list + 2/ SSLeay.pm/@EXPORT_OK) that are not updated automatically during autogeneration of constant related stuff. In other words: this warning should never happen when user installs Net-SSLeay distribution tarball (providing that you will run: 'perl Makefile; make test' before 'make dist'); the warning is intended for Net-SSLeay developers hacking on constants related stuff as the script helper_script/regen_openssl_constants.pl is not executed unless you make a modification to helper_script/regen_openssl_constants.pl But of course we can simply remove this warning if you prefer it. -- kmx

Thu Mar 15 05:17:55 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Thu, 15 Mar 2012 19:17:30 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, On Thursday, March 15, 2012 04:44:48 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > >

> > tests OK, but I see this during make: > > > > ### do not forget to update (manually) SSLeay.pod(constants list) + > > SSLeay.pm(@EXPORT_OK) > > > > Is that intentional? Its likely to scare people :-)

> > It is intentional; however it should happen only when when the timespamp > on helper_script/regen_openssl_constants.pl file is newer than timestamp > on constants.c > > In other words if you try to run again: > make clean > perl Makefile.PL > make > > It should not warn anymore.

OK, thats what I observe. Show quoted text

> > The idea (not sure if it is a good one) is that after modification of > helper_script/regen_openssl_constants.pl (e.g. adding the new constant) > user should be reminded to update those two things (1/ > SSLeay.pod/constants list + 2/ SSLeay.pm/@EXPORT_OK) that are not > updated automatically during autogeneration of constant related stuff. > > In other words: this warning should never happen when user installs > Net-SSLeay distribution tarball (providing that you will run: 'perl > Makefile; make test' before 'make dist'); the warning is intended for > Net-SSLeay developers hacking on constants related stuff as the script > helper_script/regen_openssl_constants.pl is not executed unless you make > a modification to helper_script/regen_openssl_constants.pl > > But of course we can simply remove this warning if you prefer it.

If it should only appear to net-ssleay developers then I am OK with it. Committed to 315. Cheers. Show quoted text

> > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 20 07:17:23 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Tue, 20 Mar 2012 12:17:13 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

The following constants turned out to be useless: Net::SSLeay::X509V3_EXT_CTX_DEP Net::SSLeay::X509V3_EXT_DYNAMIC Net::SSLeay::X509V3_EXT_MULTILINE will send patch removing them later (just wait with release) -- kmx

Tue Mar 20 19:53:56 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 00:53:45 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

To your change in r319: "Fixed reported errors about try to plan twice in 21_constants.t on some platforms." It has to be fixed in helper_script/regen_openssl_constants.pl 21_constants.t is autogenerated. I will fix this in my next patch. -- kmx

Tue Mar 20 20:02:11 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 01:01:51 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Here is the patch removing 3 recently added constants that turned out to be useless. -- kmx

Message body is not shown because sender requested not to inline it.

Tue Mar 20 20:13:49 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 10:12:53 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

On Tuesday, March 20, 2012 07:53:56 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > To your change in r319: "Fixed reported errors about try to plan twice > in 21_constants.t on some platforms." > > It has to be fixed in helper_script/regen_openssl_constants.pl > 21_constants.t is autogenerated.

Hmmm, my Makefile has this at the end now: # Postamble by Module::Install 0.93 constants.c :: helper_script/regen_openssl_constants.pl 100 14 16 33 54 100ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c constants.c t/local/21_constants.t :: helper_script/regen_openssl_constants.pl 100 14 16 33 54 100ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t t/local/21_constants.t and the regen of those files does not work. the fix is to change Makefile.PL: postamble <<MAKE; constants.c :: helper_script/regen_openssl_constants.pl \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c constants.c t/local/21_constants.t :: helper_script/regen_openssl_constants.pl \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t t/local/21_constants.t MAKE I have done that here: no need for a patch. Show quoted text

> > I will fix this in my next patch. > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 20 21:16:09 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 02:15:58 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

On 21.3.2012 1:13, mikem@open.com.au via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=75027> > > On Tuesday, March 20, 2012 07:53:56 PM you wrote: >

>> Queue: Net-SSLeay >> Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=75027> >> >> To your change in r319: "Fixed reported errors about try to plan twice >> in 21_constants.t on some platforms." >> >> It has to be fixed in helper_script/regen_openssl_constants.pl >> 21_constants.t is autogenerated. >>

> > Hmmm, my Makefile has this at the end now: > > # Postamble by Module::Install 0.93 > constants.c :: helper_script/regen_openssl_constants.pl > 100 14 16 33 54 100ABSPERLRUN) > helper_script/regen_openssl_constants.pl -gen-c constants.c > > t/local/21_constants.t :: helper_script/regen_openssl_constants.pl > 100 14 16 33 54 100ABSPERLRUN) > helper_script/regen_openssl_constants.pl -gen-t t/local/21_constants.t > > > and the regen of those files does not work. > > the fix is to change Makefile.PL: > > postamble<<MAKE; > constants.c :: helper_script/regen_openssl_constants.pl > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c constants.c > > t/local/21_constants.t :: helper_script/regen_openssl_constants.pl > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t > t/local/21_constants.t > MAKE > > I have done that here: no need for a patch. >

Hmmm my postamble was slightly buggy, please update it according this: postamble <<MAKE; constants.c :: helper_script/regen_openssl_constants.pl \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c constants.c t/local/21_constants.t :: helper_script/regen_openssl_constants.pl \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t t/local/21_constants.t SSLeay.o :: constants.c t/local/21_constants.t MAKE BEWARE: - empty lines at the beginning and at the end are necessary - target SSLeay.owas missing

Tue Mar 20 21:41:01 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 02:40:41 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Please apply removing_3_constants_r320.diff -- kmx

Message body is not shown because sender requested not to inline it.

Tue Mar 20 22:13:40 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 12:12:43 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, alas on OpenSuSE mikem@zulu:/usr/local/projects/net-ssleay/trunk> make Makefile:983: *** target file `SSLeay.o' has both : and :: entries. Stop. Works OK if there is a single : like this: SSLeay.o : constants.c t/local/21_constants.t shall I leave it like that? Cheers. On Tuesday, March 20, 2012 09:16:11 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > On 21.3.2012 1:13, mikem@open.com.au via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=75027> > > > > On Tuesday, March 20, 2012 07:53:56 PM you wrote:

> >> Queue: Net-SSLeay > >> > >> Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=75027> > >> > >> To your change in r319: "Fixed reported errors about try to plan twice > >> in 21_constants.t on some platforms." > >> > >> It has to be fixed in helper_script/regen_openssl_constants.pl > >> 21_constants.t is autogenerated.

> > > > Hmmm, my Makefile has this at the end now: > > > > # Postamble by Module::Install 0.93 > > constants.c :: helper_script/regen_openssl_constants.pl > > > > 100 14 16 33 54 100ABSPERLRUN) > > > > helper_script/regen_openssl_constants.pl -gen-c constants.c > > > > t/local/21_constants.t :: helper_script/regen_openssl_constants.pl > > > > 100 14 16 33 54 100ABSPERLRUN) > > > > helper_script/regen_openssl_constants.pl -gen-t t/local/21_constants.t > > > > > > and the regen of those files does not work. > > > > the fix is to change Makefile.PL: > > > > postamble<<MAKE; > > constants.c :: helper_script/regen_openssl_constants.pl > > > > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c > > constants.c> > > t/local/21_constants.t :: helper_script/regen_openssl_constants.pl > > > > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t > > > > t/local/21_constants.t > > MAKE > > > > I have done that here: no need for a patch.

> > Hmmm my postamble was slightly buggy, please update it according this: > > postamble <<MAKE; > > constants.c :: helper_script/regen_openssl_constants.pl > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-c > constants.c > > t/local/21_constants.t :: helper_script/regen_openssl_constants.pl > \$(ABSPERLRUN) helper_script/regen_openssl_constants.pl -gen-t > t/local/21_constants.t > > SSLeay.o :: constants.c t/local/21_constants.t > > MAKE > > BEWARE: > - empty lines at the beginning and at the end are necessary > - target SSLeay.owas missing

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 20 22:22:01 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 03:21:49 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

On 21.3.2012 3:13, mikem@open.com.au via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=75027> > > Hi, > > alas on OpenSuSE > > mikem@zulu:/usr/local/projects/net-ssleay/trunk> make > Makefile:983: *** target file `SSLeay.o' has both : and :: entries. Stop. > > Works OK if there is a single : like this: > > SSLeay.o : constants.c t/local/21_constants.t > > shall I leave it like that? >

my removing_3_constants_r320.diff already has single : consider applying my diff to avoid svn conflicts -- kmx

Tue Mar 20 22:25:17 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 12:24:19 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, added, tested OK, svn with commit 321 I think the only issue left is META.yml. I dont get a META.yml created ever. However I do get a MYMETA.yml created by perl Makefile.PL However, it doesnt contain the repository data that we added recently. Not sure how this is supposed to work? Views? Cheers. On Tuesday, March 20, 2012 09:41:03 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > Please apply removing_3_constants_r320.diff > > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Tue Mar 20 22:26:04 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75027] Missing openssl constants
Date:	Wed, 21 Mar 2012 12:25:09 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, On Tuesday, March 20, 2012 10:22:02 PM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75027 > > > On 21.3.2012 3:13, mikem@open.com.au via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=75027> > > > > Hi, > > > > alas on OpenSuSE > > > > mikem@zulu:/usr/local/projects/net-ssleay/trunk> make > > Makefile:983: *** target file `SSLeay.o' has both : and :: entries. > > Stop. > > > > Works OK if there is a single : like this: > > > > SSLeay.o : constants.c t/local/21_constants.t > > > > shall I leave it like that?

> > my removing_3_constants_r320.diff already has single : > > consider applying my diff to avoid svn conflicts

yes, saw that later. Fixed. Show quoted text

> > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Thu Mar 22 17:29:53 2012 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Mar 22 17:29:53 2012 MIKEM [...] cpan.org - Given to MIKEM