Bug #74879 for Module-ExtractUse: Failures due to Parse::RecDescent changes

Wed Feb 01 19:22:52 2012 TMUELLER [...] cpan.org - Ticket #74608: Ticket created

Subject:

Fails Tests on install

Hi, This Module fails on install for me. Cpantesters is encountering errors as well. http://www.cpantesters.org/distro/M/Module- ExtractUse.html#Module-ExtractUse-0.23 The Problem might be a backwards incompatible change in Parse::RecDescent. Its changelog contains the following entry: 1.966_002 Sun Jan 22 19:08:37 2012 - *** NON-BACKWARDS COMPATIBLE CHANGE! *** Change the caches for $prevline and $thisline to be local to the parser, rather than lexical vars in Parse::RecDescent. This prevents previously generated parsers from interfering with the line counts of later parsers.

Thu Feb 02 13:26:35 2012 paul [...] city-fan.org - Ticket #74608: Correspondence added

From:

paul [...] city-fan.org

On Wed Feb 01 19:22:52 2012, TMUELLER wrote: Show quoted text

> Hi, > > This Module fails on install for me. Cpantesters is encountering errors > as well. http://www.cpantesters.org/distro/M/Module- > ExtractUse.html#Module-ExtractUse-0.23 > > The Problem might be a backwards incompatible change in > Parse::RecDescent. Its changelog contains the following entry: > > 1.966_002 Sun Jan 22 19:08:37 2012 > > - *** NON-BACKWARDS COMPATIBLE CHANGE! *** Change the caches for > $prevline and $thisline to be local to the parser, rather than > lexical vars in Parse::RecDescent. This prevents previously > generated parsers from interfering with the line counts of > later parsers.

Recompiling the grammar (Module::ExtractUse::Grammar) using the new Parse::RecDescent as described in the POD fixes this problem.

Thu Feb 02 13:26:37 2012 The RT System itself - Ticket #74608: Status changed from 'new' to 'open'

Thu Feb 02 18:07:13 2012 TMUELLER [...] cpan.org - Ticket #74608: Correspondence added

On Thu Feb 02 13:26:35 2012, paul@city-fan.org wrote: Show quoted text

> On Wed Feb 01 19:22:52 2012, TMUELLER wrote:

> > Hi, > > > > This Module fails on install for me. Cpantesters is encountering errors > > as well. http://www.cpantesters.org/distro/M/Module- > > ExtractUse.html#Module-ExtractUse-0.23 > > > > The Problem might be a backwards incompatible change in > > Parse::RecDescent. Its changelog contains the following entry: > > > > 1.966_002 Sun Jan 22 19:08:37 2012 > > > > - *** NON-BACKWARDS COMPATIBLE CHANGE! *** Change the caches for > > $prevline and $thisline to be local to the parser, rather than > > lexical vars in Parse::RecDescent. This prevents previously > > generated parsers from interfering with the line counts of > > later parsers.

> > Recompiling the grammar (Module::ExtractUse::Grammar) using the new > Parse::RecDescent as described in the POD fixes this problem.

Thanks a lot, worked very well as a workaround.

Thu Feb 02 21:11:17 2012 KENTNL [...] cpan.org - Ticket #74608: Cc KENTNL added

Sat Feb 04 19:38:09 2012 jtbraun [...] CPAN.org - Ticket #74688: Ticket created

Subject:

Precompile parser on build to avoid dependency break

Recent changes I've made to Parse::RecDescent break pre-compiled parsers built with an earlier version of P::RD, as some of the internal P::RD functions that the precompiled parsers call have changed. This includes the precompiled parser included in Module::ExtractUse. Please find attached a modified version of Module::ExtractUse that auto-build the grammar into blib. I suspect that the procress_grammar_files function will need some changes to work correctly across Mac/Windows (the provided code assumes '/' as a directory separator). Would you mind cleaning this up to match your standards and releasing a new version into CPAN? Long-term I plan to have precompiled parsers not depend on P::RD at all, so modules like yours can distribute truly stand-alone pre-compiled parsers. However, that won't help Module::ExtractUse in the short term. Let me know if I can do anything else to help, Jeremy

Subject:

Module-ExtractUse-0.23.tar.gz

Download Module-ExtractUse-0.23.tar.gz
application/x-gzip 10.4k

Message body not shown because it is not plain text.

Sat Feb 11 09:35:11 2012 dirkus [...] yopmail.com - Ticket created

Subject:

Failures due to Parse::RecDescent changes

examples of failures: http://www.cpantesters.org/cpan/report/582931a0-51af-11e1-a48f-e7fb434ae6f1

Sun Feb 12 08:29:15 2012 domm [...] cpan.org - Ticket #74608: Merged into ticket #74879

Sun Feb 12 08:29:15 2012 domm [...] cpan.org - Merged into ticket #74879

Sun Feb 12 08:35:14 2012 domm [...] cpan.org - Requestor paul@city-fan.org added

Sun Feb 12 08:35:14 2012 domm [...] cpan.org - Requestor KENTNL added

Sun Feb 12 08:35:21 2012 domm [...] cpan.org - Cc KENTNL deleted

Sun Feb 12 08:37:14 2012 domm [...] cpan.org - Status changed from 'new' to 'open'

Sun Feb 12 08:37:16 2012 domm [...] cpan.org - Taken

Sun Feb 12 08:40:11 2012 domm [...] cpan.org - Correspondence added

A new version (0.24) with an updated compiled grammar is currently on it's way to CPAN. Thanks for the notifications, and sorry for keeping you waiting, but we had a week of holidays in Austria...

Sun Feb 12 08:41:26 2012 domm [...] cpan.org - Correspondence added

RT-Send-CC:

dirkus [...] yopmail.com, KENTNL [...] cpan.org, paul [...] city-fan.org, TMUELLER [...] cpan.org

A new version (0.24) with an updated compiled grammar is currently on it's way to CPAN. Thanks for the notifications, and sorry for keeping you waiting, but we had a week of holidays in Austria...

Sun Feb 12 08:41:28 2012 domm [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Feb 13 16:19:54 2012 thomas.mi.iller [...] googlemail.com - Correspondence added

Subject:	Re: [rt.cpan.org #74879] Resolved: Failures due to Parse::RecDescent changes
Date:	Mon, 13 Feb 2012 22:19:43 +0100
To:	bug-Module-ExtractUse [...] rt.cpan.org
From:	"Thomas Müller" <thomas.mi.iller [...] googlemail.com>

Am 12.02.2012 14:41, schrieb Thomas Klausner via RT: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=74879> > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message. >

Hallo Thomas, danke fürs Beheben. Habs gerade probiert, und die Installation klappt jetzt. Und 10 Tage sind doch keine lange Zeit für nen Bugfix, wichtig ist, dass die Ferien schön waren :) Ich glaub der Autor von Parse::RecDescent ist sich auch bewusst, dass vorkompilierte Grammatiken ein Problem sind, er weiß wohl nur noch nicht, wie ers anpacken soll. => https://rt.cpan.org/Public/Bug/Display.html?id=74593 MfG, Thomas (tmueller@cpan.org)

Mon Feb 13 16:19:55 2012 The RT System itself - Status changed from 'resolved' to 'open'

Fri Mar 16 15:11:54 2012 paul [...] city-fan.org - Correspondence added

From:

paul [...] city-fan.org

On Sun Feb 12 08:41:26 2012, DOMM wrote: Show quoted text

> A new version (0.24) with an updated compiled grammar is currently on > it's way to CPAN. Thanks for the notifications, and sorry for keeping > you waiting, but we had a week of holidays in Austria...

Parse::RecDescent 1.967009 is out today, and has triggered a re-occurrence of this problem. The grammar recompilation trick works again. If you ship an update with a recompiled grammar, it would be a good idea to make 1.967009 the minimum required version of Parse::RecDescent so as to avoid trying to use the new grammar with old parsers. It's also worth noting that Parse::RecDescent now has a facility for embedding a parser in its compiled output so that the resulting code no longer requires Parse::RecDescent to run, which might be a long-term solution for this issue.

Sun Mar 18 18:25:05 2012 RWSTAUNER [...] cpan.org - Correspondence added

For anybody wishing to fix this locally: cpanm --look Module::ExtractUse cd lib/Module/ExtractUse/ rm Grammar.pm perl -MParse::RecDescent - grammar Module::ExtractUse::Grammar chmod a-w Grammar.pm cd ../../../ perl Build.PL ./Build ./Build test ./Build install

Wed Mar 21 00:16:55 2012 xenoterracide [...] gmail.com - Correspondence added

Subject:	[rt.cpan.org #74879] Failures due to Parse::RecDescent
Date:	Tue, 20 Mar 2012 23:16:46 -0500
To:	bugs-module-extractuse [...] rt.cpan.org
From:	Caleb Cushing <xenoterracide [...] gmail.com>

I'd like to suggest that instead of fast workarounds why don't we make it so that Grammar.pm is built by the makefile so that all that is needed is a reinstall, if this happens again. Then it will also work with whatever Parse::RecDescent is installed. The Pod for grammar.pm can be split out. Would such a solution work? and would it get accepted if someone put the energy into making it happen? -- Caleb Cushing http://xenoterracide.com

Wed Mar 21 08:07:22 2012 paul [...] city-fan.org - Correspondence added

From:

paul [...] city-fan.org

On Wed Mar 21 00:16:55 2012, XENO wrote: Show quoted text

> I'd like to suggest that instead of fast workarounds why don't we make > it so that Grammar.pm is built by the makefile so that all that is > needed is a reinstall, if this happens again. Then it will also work > with whatever Parse::RecDescent is installed. The Pod for grammar.pm > can be split out. Would such a solution work? and would it get > accepted if someone put the energy into making it happen?

Parse::RecDescent's plan is to to use standalone precompiled parsers that won't depend on Parse::RecDescent at runtime: http://search.cpan.org/~jtbraun/Parse-RecDescent-1.967009/lib/Parse/RecDescent.pm#Standalone_Precompiled_Parsers Using that approach would mean no need to rebuild the grammar at any time other than when the module was built for distribution, and would even survive incompatible updates of Parse::RecDescent on users' systems.

Thu Mar 22 04:54:23 2012 domm [...] cpan.org - Ticket #74688: Merged into ticket #74879

Thu Mar 22 04:54:23 2012 domm [...] cpan.org - Merged into ticket #74879

Thu Mar 22 06:25:14 2012 domm [...] cpan.org - Correspondence added

RT-Send-CC:

thomas.mi.iller [...] googlemail.com, dirkus [...] yopmail.com, paul [...] city-fan.org, xenoterracide [...] gmail.com

Hi! I've now sort of integrated jtbrauns patch to autogenerate the Grammar during Build. I hope this will fix the current and any future issues caused by new versions of Parse::RecDescent. As far as I understand it, the "Standalone Precompiled Parsers" Feature is still experimental, so I'll stick with the autogeneration for now. Thanks for all the feedback, domm

Thu Mar 22 06:25:18 2012 domm [...] cpan.org - Status changed from 'open' to 'resolved'