Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 74836
Status: resolved
Priority: 0/
Queue: Log-Log4perl

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.35
Fixed in: (no value)



Subject: [PATCH] test fix for new Carp 1.25 dot
test fix for new Carp 1.25 dot (perl-5.16) patch attached. -- Reini Urban
Subject: 0002-test-fix-for-new-Carp-1.25-dot.patch
From 315b412d592c57c27a3201a1482e71ad9d997a49 Mon Sep 17 00:00:00 2001 From: Reini Urban <rurban@cpanel.net> Date: Thu, 9 Feb 2012 18:04:07 -0600 Subject: [PATCH 2/2] test fix for new Carp 1.25 dot --- t/022Wrap.t | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/022Wrap.t b/t/022Wrap.t index 97d467b..28b59e7 100644 --- a/t/022Wrap.t +++ b/t/022Wrap.t @@ -76,7 +76,7 @@ $buf =~ s#(\S+022Wrap\.t)#basename( $1 )#eg; is($buf, "File: 022Wrap.t Line number: $line package: main " . - "trace: at 022Wrap.t line $line", + "trace: at 022Wrap.t line $line".($Carp::VERSION gt '1.24'?".":""), "appender check"); # with the new wrapper_register in Log4perl 1.29, this will even work @@ -92,7 +92,7 @@ $buf =~ s#(\S+022Wrap\.t)#basename( $1 )#eg; is($buf, "File: 022Wrap.t Line number: $line package: main " . - "trace: at 022Wrap.t line $line", + "trace: at 022Wrap.t line $line".($Carp::VERSION gt '1.24'?".":""), "appender check"); ################################################## -- 1.7.5.4
On Thu Feb 09 19:10:06 2012, RURBAN wrote: Show quoted text
> test fix for new Carp 1.25 dot (perl-5.16) > patch attached.
That's an interesting find, thanks for catching that. Do we know if Carp 1.25 has just haphazardly added the dot or was this a conscious decision? If the former, and if it might go away going forward, it might be safer to use a regular expression match instead. Do you have any insight in what went on in Carp land by any chance? -- Mike
CC: RURBAN [...] cpan.org
Subject: Re: [rt.cpan.org #74836] [PATCH] test fix for new Carp 1.25 dot
Date: Fri, 10 Feb 2012 08:36:28 -0600
To: bug-Log-Log4perl [...] rt.cpan.org
From: Reini Urban <rurban [...] x-ray.at>
On Fri, Feb 10, 2012 at 1:38 AM, Michael_Schilli via RT <bug-Log-Log4perl@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=74836 > > > On Thu Feb 09 19:10:06 2012, RURBAN wrote:
>> test fix for new Carp 1.25 dot (perl-5.16) >> patch attached.
> > That's an interesting find, thanks for catching that. Do we know if Carp > 1.25 has just haphazardly added the dot or was this a conscious decision? > If the former, and if it might go away going forward, it might be safer > to use a regular expression match instead. Do you have any insight in > what went on in Carp land by any chance?
Hi Mike, It was brought up on p5p to add that dot for ästhetic reasons, no really to match die output. "Concious decision"? Well not really, many of us are angry, but nobody dared to speak up against Father and Zefram, so it went in, and several modules blew up. Like yours, Error and many more. http://www.nntp.perl.org/group/perl.perl5.porters/2011/12/msg180895.html https://rt.perl.org:443/rt3/Ticket/Display.html?id=106538 Since this change is tied to this version change I made the version check. Other modules like Error have like// in their test, so we used \.? but this looked awful. See https://rt.cpan.org/Ticket/Display.html?id=74770 I prefer the fix in yours. Maybe add a comment with reference to [PERL #106538] -- Reini Urban http://cpanel.net/   http://www.perl-compiler.org/
Got it, thanks for explaining :). What do you think of that? https://github.com/mschilli/log4perl/commit/05c5cb2190ffbd0916d0c88c8ae4 53b6459d6fb6 I haven't had a chance to test it (looks like Carp 1.25 isn't on CPAN), so I've tagged https://github.com/mschilli/log4perl/tarball/carp-folly-fixed if you want to give it a quick whirl. Thanks again, appreciate your help! -- Mike
Will be released as part of 1.36.