Bug #74801 for CGI-Info: kwalitee.t should be an author test

Thu Feb 09 02:00:13 2012 ANDK [...] cpan.org - Ticket created

Subject:

kwalitee.t should be an author test

All but two FAIL reports of the cpantesters fail the kwalitee test, as can be seen in this table: http://analysis.cpantesters.org/reports_by_field?distv=CGI-Info-0.18;field=qr%3A%28Failed%20test\s%2B\S%2B.*%29;order=1ta What does this tell the end user? It is hard to spot the relevant fails, the irrelevant dominate the picture. HTH&&Thanks&&Regards,

Thu Feb 09 21:27:49 2012 NHORNE [...] cpan.org - Correspondence added

What version of Test::Kwalitee and Module::CPANTS::Analyse are you using?

Thu Feb 09 21:27:50 2012 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 09 22:27:23 2012 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org
Subject:	Re: [rt.cpan.org #74801] kwalitee.t should be an author test
Date:	Fri, 10 Feb 2012 04:27:07 +0100
To:	bug-CGI-Info [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Thu, 9 Feb 2012 21:27:49 -0500, "Nigel Horne via RT" <bug-CGI-Info@rt.cpan.org> said:

Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=74801 > > What version of Test::Kwalitee and Module::CPANTS::Analyse are you using?

I was not talking about myself, I was talking about cpantesters in general. You can also see it here: http://matrix.cpantesters.org/?dist=CGI-Info-0.18 Only 12 of the reports are from me and only 7 of these are fails. I had fun for a while to research the reasons for the fails and came to the conclusion, kwalitee is an intrinsic author test, not an end user test. It does not test whether the code works but whether it pleases some external criterion that has nothing to do with code working or not working. Hint: It's not sufficient to answer your question about versions of Test::Kwalitee and Module::CPANTS::Analyse. You can find the versions of Test::Kwalitee at http://analysis.cpantesters.org/reports_by_field?SUBMIT_xxx=Submit&distv=CGI-Info-0.18&field=meta%3Afrom&field=meta%3Aperl&field=mod%3ATest%3A%3AKwalitee If you make Module::CPANTS::Analyse a direct dependency of CGI::Info and then wait a week or two, then you can add that to the query. I expect you will then have to add Test::Pod and Test::Pod::Coverage and maybe more. -- andreas

Tue Feb 14 18:26:03 2012 NHORNE [...] cpan.org - Correspondence added

Thank you for bringing this to my attention, however this is not a problem with CGI::Info. Test::Kwalitee is giving false positives stating that there are missing tests, which do in fact exist. A search around the Internet with your favourite search engine will show many modules suffering from this. Making the test author only, as you suggest, will mask the error by fixing the symptoms not the cause - a bad practice. You should raise the bug with Test::Kwalitee.

Tue Feb 14 18:26:46 2012 NHORNE [...] cpan.org - Status changed from 'open' to 'rejected'

Wed Feb 15 15:04:11 2012 ANDK [...] cpan.org - Correspondence added

We are talking past each other. I hope somebody else can express it better. Or maybe I'll retry some other day. If you can name another module(s) affected in a similar way as yours, please let me know, I'd really be curious about it/them.

Wed Feb 15 15:04:11 2012 The RT System itself - Status changed from 'rejected' to 'open'

Wed Feb 15 15:30:38 2012 NHORNE [...] cpan.org - Correspondence added

On Wed Feb 15 15:04:11 2012, ANDK wrote: Show quoted text

> We are talking past each other. I hope somebody else can express it > better. Or maybe I'll retry some other day. > > If you can name another module(s) affected in a similar way as yours, > please let me know, I'd really be curious about it/them.

Here's one I found with a few seconds of Googling: http://www.cpantesters.org/cpan/report/aac8f49a-4e2b-11e1b114-38629aeef8c6

Wed May 02 13:10:40 2012 NHORNE [...] cpan.org - Correspondence added

I've removed the call to Test::Kwalitee since it's clearly broken. If you're still getting a problem with it, please raise a problem against Test::Kwalitee.

Wed May 02 13:11:03 2012 NHORNE [...] cpan.org - Status changed from 'open' to 'resolved'