Skip Menu |

This queue is for tickets about the Error CPAN distribution.

Report information
The Basics
Id: 74770
Status: resolved
Priority: 0/
Queue: Error

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.17016
Fixed in: (no value)



Subject: Bleadperl v5.15.7-200-g879b0ca breaks SHLOMIF/Error-0.17016.tar.gz
Patch for the new croak dot attached. Tested ok on all perl versions. On Tue Feb 07 22:32:33 2012, ANDK wrote: Show quoted text
d30c9aeef8c6 Show quoted text
> > HTH && Thanks && Regards,
-- Reini Urban
Subject: Error-0.17016.patch
[CPAN #74770] new croak dot diff -bu Error-0.17016/t/08warndie.t~ Error-0.17016/t/08warndie.t --- Error-0.17016/t/08warndie.t~ 2012-02-09 16:45:59.000000000 -0600 +++ Error-0.17016/t/08warndie.t 2012-02-09 16:45:59.000000000 -0600 @@ -166,7 +166,7 @@ }; $linea = $line + 2; -like( $s, qr/^My custom warning here: A warning at $file line $linea. +like( $s, qr/^My custom warning here: A warning at $file line $linea.? $/, "Custom warn test STDERR" ); is( $felloffcode, 1, "Custom warn test felloffcode" ); @@ -176,7 +176,7 @@ }; $linea = $line + 2; -like( $s, qr/^My custom death here: An error at $file line $linea. +like( $s, qr/^My custom death here: An error at $file line $linea.? /, "Custom die test STDERR" ); is( $felloffcode, 0, "Custom die test felloffcode" ); @@ -189,7 +189,7 @@ }; ( $linea, $lineb ) = ( $line + 2, $line + 3 ); -like( $s, qr/^My custom warning here: A warning at $file line $linea: +like( $s, qr/^My custom warning here: A warning at $file line $linea.?: \tmain::__ANON__\(\) called at $file line $linekid \tmain::run_kid\('CODE\(0x[0-9a-f]+\)'\) called at $file line $lineb $/, "Custom warn STDERR" );
Patch was not complete, we found more errors. Revised patch added
Subject: Error-0.17016.patch
difforig Error-0.17016 diff -u Error-0.17016/t/08warndie.t.orig --- Error-0.17016/t/08warndie.t.orig 2012-02-09 17:40:02.602484465 -0600 +++ Error-0.17016/t/08warndie.t 2012-02-09 17:43:57.224232307 -0600 @@ -74,7 +74,7 @@ }; my ( $linea, $lineb ) = ( $line + 2, $line + 3 ); -like( $s, qr/^A warning at $file line $linea: +like( $s, qr/^A warning at $file line $linea\.?: \tmain::__ANON__\(\) called at $file line $linekid \tmain::run_kid\('CODE\(0x[0-9a-f]+\)'\) called at $file line $lineb $/, "warn \\n-terminated STDERR" ); @@ -86,7 +86,7 @@ }; ( $linea, $lineb ) = ( $line + 2, $line + 3 ); -like( $s, qr/^A warning at $file line $linea: +like( $s, qr/^A warning at $file line $linea\.?: \tmain::__ANON__\(\) called at $file line $linekid \tmain::run_kid\('CODE\(0x[0-9a-f]+\)'\) called at $file line $lineb $/, "warn unterminated STDERR" ); @@ -166,7 +166,7 @@ }; $linea = $line + 2; -like( $s, qr/^My custom warning here: A warning at $file line $linea. +like( $s, qr/^My custom warning here: A warning at $file line $linea.? $/, "Custom warn test STDERR" ); is( $felloffcode, 1, "Custom warn test felloffcode" ); @@ -176,7 +176,7 @@ }; $linea = $line + 2; -like( $s, qr/^My custom death here: An error at $file line $linea. +like( $s, qr/^My custom death here: An error at $file line $linea.? /, "Custom die test STDERR" ); is( $felloffcode, 0, "Custom die test felloffcode" ); @@ -189,7 +189,7 @@ }; ( $linea, $lineb ) = ( $line + 2, $line + 3 ); -like( $s, qr/^My custom warning here: A warning at $file line $linea: +like( $s, qr/^My custom warning here: A warning at $file line $linea.?: \tmain::__ANON__\(\) called at $file line $linekid \tmain::run_kid\('CODE\(0x[0-9a-f]+\)'\) called at $file line $lineb $/, "Custom warn STDERR" );
Hi. Thanks for the report and the series of patches. The last one used "." instead of "\." inside the regexes at some points and so I fixed it. This was now released in Error-0.17017 to CPAN. Regards, -- Shlomi Fish