Bug #74707 for Hash-Merge: Module requires Clone.pm unconditionally even if it can function without it

Sun Feb 05 14:45:42 2012 ribasushi [...] leporine.io - Ticket created

Subject:

Module requires Clone.pm unconditionally even if it can function without it

There are plenty of fallbacks in Hash::Merge::_my_clone (in fact I would say that Storable should just take precedence). Nevertheless the Makefile.PL of Hash-Merge has a hard-require on Clone. Please skip this dependency if a c compiler is not available. Here is a suitable working check: https://metacpan.org/source/ADAMK/List-MoreUtils-0.33/Makefile.PL#L81

Sun Feb 05 14:47:29 2012 ribasushi [...] leporine.io - Dependency by ticket #74706 added

Thu Jul 09 12:12:07 2020 HERMES [...] cpan.org - Correspondence added

Hi there, this has already been fixed with the use of then Clone::Choose module. Greetings Stefan

Thu Jul 09 12:12:07 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 09 12:12:07 2020 HERMES [...] cpan.org - Status changed from 'open' to 'patched'

Thu Jul 09 15:45:06 2020 ribasushi [...] leporine.io - Correspondence added

On Thu Jul 09 18:12:07 2020, HERMES wrote: Show quoted text

> > this has already been fixed with the use of then Clone::Choose module. >

This introduced a regression ( aside from Clone::Choose being very iffy ) https://rt.cpan.org/Public/Bug/Display.html?id=124321#txn-1832543 I am currently working around this breakage by unconditionally depending on Clone myself ( exactly the opposite of what this ticket was about ).

Thu Jul 09 15:48:17 2020 ribasushi [...] leporine.io - Correspondence added

Subject:	Re: [rt.cpan.org #74707] Module requires Clone.pm unconditionally even if it can function without it
Date:	Thu, 9 Jul 2020 21:42:54 +0200
To:	bug-Hash-Merge [...] rt.cpan.org
From:	Peter Rabbitson <ribasushi [...] leporine.io>

On 07/09/2020 06:12 PM, Stefan Hermes via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=74707 > > > this has already been fixed with the use of then Clone::Choose module.

This introduced a regression ( aside from Clone::Choose being iffy ) https://rt.cpan.org/Public/Bug/Display.html?id=124321#txn-1832543 I am currently working around this breakage by uncoditionally depending on Clone myself ( exactly the opposite of what this ticket was about ).

Tue Jul 14 11:53:39 2020 HERMES [...] cpan.org - Correspondence added

Hi, i'm sorry to hear that this is still an issue for you. So I reopened the ticket. But I need some more information on what's bothering you. Hash::Merge and Clone::Choose don't have a hard dependency (anymore) for Clone.pm in their Makefile. Of course, one (supported by Clone::Choose) Clone Module is needed in order for Hash::Merge to work correctly. So if you build an environment where no Clone Module available, that's not going to work. Maybe you could also tell me what you mean by the Clone::Choose module is "very iffy" so I can improve it? Best regards, Stefan

Tue Jul 14 11:53:39 2020 HERMES [...] cpan.org - Status changed from 'patched' to 'open'