Skip Menu |

This queue is for tickets about the IO-Pager CPAN distribution.

Report information
The Basics
Id: 74691
Status: resolved
Priority: 0/
Queue: IO-Pager
People
Owner: Nobody in particular
Requestors: jpierce [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.16
Fixed in: 0.20

History Show all quoted text
  Sat Feb 04 21:57:08 2012 jpierce [...] cpan.org - Ticket created
Subject: CPANTS test failures of find_pager
Many failures all seem to be like the following: [ERROR] [Sat Feb 4 22:38:44 2012] MAKE TEST failed: PERL_DL_NONLAZY=1 /usr/home/cpan/pit/bare/perl-5.12.4/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/1-load.t .................. ok t/2-which.t ................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests # Failed test 'PAGER is referred by its executable name' # at t/2-which.t line 30. # '/usr/bin/less' # doesn't match '(?i-xsm:perl)' # Looks like you failed 1 test of 6. IO-Pager-0.16: - OpenBSD.i386-openbsd-thread-multi / 5.15.6: - FAIL http://www.cpantesters.org/cpan/report/674650ac-4f23-11e1-bf5e-8a22db34f026 - amd64-freebsd / 5.12.4: - FAIL http://www.cpantesters.org/cpan/report/fe966f16-4f80-11e1-a48f-e7fb434ae6f1 - amd64-freebsd / 5.14.0: - FAIL http://www.cpantesters.org/cpan/report/4435d482-4f4d-11e1-9d6f-f6dbfa7543f5 - amd64-freebsd-thread-multi / 5.12.4: - FAIL http://www.cpantesters.org/cpan/report/29aa0df8-4f26-11e1-9d6f-f6dbfa7543f5 - amd64-freebsd-thread-multi / 5.14.0: - FAIL http://www.cpantesters.org/cpan/report/71a8a9a6-4f72-11e1-9d6f-f6dbfa7543f5 - i386-netbsd-thread-multi / 5.15.5: - FAIL http://www.cpantesters.org/cpan/report/bff90316-4f55-11e1-bf5e-8a22db34f026 - i386-netbsd-thread-multi / 5.15.6: - FAIL http://www.cpantesters.org/cpan/report/3f66cca8-4f5d-11e1-bf5e-8a22db34f026 - i86pc-solaris / 5.14.2: - FAIL http://www.cpantesters.org/cpan/report/b42ea03c-4f22-11e1-9d6f-f6dbfa7543f5 - i86pc-solaris / 5.8.9: - FAIL http://www.cpantesters.org/cpan/report/78ef886e-4f78-11e1-9d6f-f6dbfa7543f5 - i86pc-solaris-64int / 5.14.2: - FAIL http://www.cpantesters.org/cpan/report/8843eb52-4f64-11e1-9d6f-f6dbfa7543f5 - i86pc-solaris-thread-multi / 5.14.2: - FAIL http://www.cpantesters.org/cpan/report/5729baf2-4f4f-11e1-9d6f-f6dbfa7543f5 - i86pc-solaris-thread-multi-64int / 5.14.2: - FAIL http://www.cpantesters.org/cpan/report/eb320f04-4f38-11e1-9d6f-f6dbfa7543f5 - i86pc-solaris-thread-multi-64int / 5.8.9: - FAIL http://www.cpantesters.org/cpan/report/9b31b6cc-4f8c-11e1-9d6f-f6dbfa7543f5 - x86_64-linux-ld / 5.12.3: - FAIL http://www.cpantesters.org/cpan/report/53588716-4f5c-11e1-9d6f-f6dbfa7543f5 - x86_64-linux-thread-multi / 5.10.1: - FAIL http://www.cpantesters.org/cpan/report/9869fae6-4f7b-11e1-8d99-dc38a2908d23 - x86_64-linux-thread-multi / 5.12.4: - FAIL http://www.cpantesters.org/cpan/report/5a31e3ae-4f8c-11e1-8d99-dc38a2908d23 - x86_64-linux-thread-multi / 5.13.10: - FAIL http://www.cpantesters.org/cpan/report/806a3eba-4f6c-11e1-8d99-dc38a2908d23 - x86_64-linux-thread-multi / 5.15.5: - FAIL http://www.cpantesters.org/cpan/report/acc9a83a-4f83-11e1-8d99-dc38a2908d23 - x86_64-linux-thread-multi-ld / 5.12.2: - FAIL http://www.cpantesters.org/cpan/report/0ee37766-4f2b-11e1-9d6f-f6dbfa7543f5 - x86_64-linux-thread-multi-ld / 5.12.3: - FAIL http://www.cpantesters.org/cpan/report/07daf78e-4f92-11e1-9d6f-f6dbfa7543f5 - x86_64-linux-thread-multi-ld / 5.8.9: - FAIL http://www.cpantesters.org/cpan/report/2b8f2cce-4f54-11e1-8d99-dc38a2908d23
  Sat Feb 04 23:57:24 2012 florent.angly [...] gmail.com - Correspondence added
This should be fixed with commit 419cc88f679d11692031c53d4dfc6716fa605c84. The test failed because it did not account for systems on which File::Which is not installed. The solution is to skip this test on these systems. On a related note, maybe the first thing the _check_pagers sub should do is to check if PAGER can be executed with a system() call? I know that File::Which is strongly recommended, but on systems where it is not installed, that would help using the proper pager. For example, at the moment, if I don't have File::Which installed and I have the PAGER 'w3m' (and w3m is properly installed), IO::Pager will not validate this pager and try to use the usual suspects, '/usr/bin/less', etc, and end up not using the valid user-defined PAGER.
  Sat Feb 04 23:57:25 2012 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 05 00:05:53 2012 belg4mit [...] pthbb.org - Correspondence added
Subject: Re: [rt.cpan.org #74691] CPANTS test failures of find_pager
Date: Sun, 05 Feb 2012 00:05:01 -0500
To: bug-IO-Pager [...] rt.cpan.org
From: Jerrad Pierce <belg4mit [...] pthbb.org>
I think we're better off requiring File::Which than adding a sketchy system() call.
  Sun Feb 05 01:09:02 2012 belg4mit [...] pthbb.org - Correspondence added
Subject: Re: [rt.cpan.org #74691] CPANTS test failures of find_pager
Date: Sun, 05 Feb 2012 01:08:11 -0500
To: bug-IO-Pager [...] rt.cpan.org
From: Jerrad Pierce <belg4mit [...] pthbb.org>
Incidentally, what are the "find perl" tests meant to prove exactly?
  Sun Feb 05 17:59:23 2012 florent.angly [...] gmail.com - Correspondence added
The tests with Perl as a pager verify that if the value of PAGER is set to a valid program (either its full-path or its executable), IO::Pager uses that and not some other pager determined by IO::Pager.
  Sun Feb 05 17:59:24 2012 florent.angly [...] gmail.com - Status changed from 'open' to 'resolved'
  Sun Feb 12 11:18:23 2012 jpierce [...] cpan.org - Fixed in 0.20 added