Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Sub-Uplevel CPAN distribution.

Report information
The Basics
Id: 74677
Status: resolved
Priority: 0/
Queue: Sub-Uplevel
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 0.22
  • 0.23_01
Fixed in: (no value)

History Show all quoted text
  Sat Feb 04 04:06:49 2012 ANDK [...] cpan.org - Ticket created
Subject: Bleadperl v5.15.7-200-g879b0ca breaks DAGOLDEN/Sub-Uplevel-0.22.tar.gz
Just a cross reference for easier retrieval: https://rt.perl.org:443/rt3/Ticket/Display.html?id=109788 Kind Regards,
  Mon Feb 06 23:15:46 2012 ANDK [...] cpan.org - Correspondence added
Attached patch Sub-Uplevel-0.22-74677-01.patch seems to do it. Works with old and new bleadperl. Also tested with 5.14.2 and 5.12.4.
Subject: Sub-Uplevel-0.22-74677-01.patch
diff -ru /home/sand/.cpan/build/Sub-Uplevel-0.22-vNnirS~/t/02_uplevel.t /home/sand/.cpan/build/Sub-Uplevel-0.22-vNnirS/t/02_uplevel.t --- /home/sand/.cpan/build/Sub-Uplevel-0.22-vNnirS~/t/02_uplevel.t 2009-11-17 11:39:43.000000000 +0100 +++ /home/sand/.cpan/build/Sub-Uplevel-0.22-vNnirS/t/02_uplevel.t 2012-02-07 04:53:45.844937901 +0100 @@ -81,6 +81,7 @@ Now we can fool croak! at $0 line 64 main::wrap_croak(1) called at $0 line 72 CARP +$croak_regex =~ s/64/64\.?/; $croak_regex .= '\t(require 0|eval \{\.\.\.\})' . quotemeta( " called at $0 line 72" ); like( $@, "/$croak_regex/", 'croak() fooled'); @@ -92,6 +93,7 @@ $croak_regex = quotemeta( <<"CARP" ); Now we can fool croak! at $0 line 64 CARP +$croak_regex =~ s/64/64\.?/; like( $@, "/$croak_regex/", 'croak() fooled'); #line 79 @@ -119,10 +121,12 @@ #line 98 wrap_carp(); } -is( $warning, <<CARP, 'carp() fooled' ); +my $carp_regex = quotemeta( <<"CARP" ); HA! Even carp is fooled! at $0 line 88 main::wrap_carp() called at $0 line 98 CARP +$carp_regex =~ s/88/88\.?/; +like( $warning, "/$carp_regex/", 'carp() fooled' ); use Foo;
  Mon Feb 06 23:15:58 2012 ANDK [...] cpan.org - Status changed from 'new' to 'open'
  Tue Feb 07 14:39:40 2012 dagolden [...] cpan.org - Correspondence added
Thanks. Fixed and released.
  Tue Feb 07 14:39:41 2012 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Feb 07 16:25:43 2012 ANDK [...] cpan.org - Status changed from 'resolved' to 'open'
  Tue Feb 07 16:28:22 2012 ANDK [...] cpan.org - Correspondence added
Did not work out, something went wrong. I'm too tired now to investigate, sorry, it was a stuffed day. Here is the error get now with 23_02: # Failed test 'croak() fooled' # at t/02_uplevel.t line 79. # 'Now we can fool croak! at t/02_uplevel.t line 64. # eval {...} called at t/02_uplevel.t line 75 # ' # doesn't match '/Now\ we\ can\ fool\ croak\!\ at\ t\/02_uplevel\.t\ line\ 64\ # /' # Looks like you failed 1 test of 23. t/02_uplevel.t ............... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/23 subtests Good night!
  Tue Feb 07 17:07:28 2012 dagolden [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #74677] Bleadperl v5.15.7-200-g879b0ca breaks DAGOLDEN/Sub-Uplevel-0.22.tar.gz
Date: Tue, 7 Feb 2012 17:05:44 -0500
To: bug-Sub-Uplevel [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
On Tue, Feb 7, 2012 at 4:28 PM, Andreas Koenig via RT <bug-Sub-Uplevel@rt.cpan.org> wrote: Show quoted text
> Did not work out, something went wrong. I'm too tired now to > investigate, sorry, it was a stuffed day. Here is the error  get now > with 23_02:
Darn. I'll look into it. The patch you attached was broken so I tried to replicate it manually. This time I'll actually test it against blead. :-) David
  Tue Feb 07 17:17:46 2012 dagolden [...] cpan.org - Correspondence added
Should be fixed now. I missed one of the places to apply a patch line. -- David
  Tue Feb 07 17:17:47 2012 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'