Bug #74675 for Dist-Zilla-Plugin-MetaProvides-Package: Should ignore "private" packages

Fri Feb 03 23:13:54 2012 dagolden [...] cpan.org - Ticket created

Subject:

Should ignore "private" packages

This scanner picks up "private" packages that are hidden with the "package\n Foo::Bar;" convention of putting package on a separate line. It also picks up packages that have a leading underscore like "Foo::Bar::_internal::Whatever". Both of those should not be reported in provides. Ideally that would be the default behavior, but an option to do so would be acceptable as well. Thanks! David

Sat Feb 04 00:19:24 2012 KENTNL [...] cpan.org - Correspondence added

Thanks for the bug report, I didn't even notice it was reporting private namespaces.

Filtering out the X::_Y form should be easy enough, just package\nX; form might prove more difficult as its handled by Module::Extract::Namespaces at present, which in turn does it via PPI ( also, damn you metacpan for being down, yay for search.cpan.org still working ), which is on my list of giant hairy bastards so hairy I employ yaks to shave it.

Sat Feb 04 00:19:25 2012 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 04 07:03:06 2012 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #74675] Should ignore "private" packages
Date:	Sat, 4 Feb 2012 07:02:37 -0500
To:	bug-Dist-Zilla-Plugin-MetaProvides-Package [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Sat, Feb 4, 2012 at 12:19 AM, Kent Fredric via RT <bug-Dist-Zilla-Plugin-MetaProvides-Package@rt.cpan.org> wrote: Show quoted text

> Filtering out the X::_Y form should be easy enough, just package\nX; form might > prove more difficult as its handled by Module::Extract::Namespaces at present, > which in turn does it via PPI ( also, damn you metacpan for being down, yay for > search.cpan.org still working ), which is on my list of giant hairy bastards so > hairy I employ yaks to shave it.

I suggest you consider using Module::Metadata instead, which is what Module::Build and ExtUtils::MakeMaker use for generating "provides" for META. That would ensure consistency. Regards, David

Tue Feb 07 09:53:26 2012 KENTNL [...] cpan.org - Correspondence added

Release is out, hopefully its to your liking =)

https://metacpan.org/source/KENTNL/Dist-Zilla-Plugin-MetaProvides-Package-1.14000000/Changes#L4

Somewhat-formal valedictions,

Kent

Tue Feb 07 22:35:08 2012 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #74675] Should ignore "private" packages
Date:	Tue, 7 Feb 2012 22:34:37 -0500
To:	bug-Dist-Zilla-Plugin-MetaProvides-Package [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Tue, Feb 7, 2012 at 9:53 AM, Kent Fredric via RT <bug-Dist-Zilla-Plugin-MetaProvides-Package@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=74675 > > > Release is out, hopefully its to your liking =) > > https://metacpan.org/source/KENTNL/Dist-Zilla-Plugin-MetaProvides-Package-1.14000000/Changes#L4

Thanks! FWIW, the new Module::Metadata 1.000008 now has a "provides" method that should give you pretty much exactly what you need. I discovered the packages_inside gives you the raw output, without filtering. I've also documented it better. David

Wed Feb 08 02:56:24 2012 KENTNL [...] cpan.org - Fixed in 1.14000000 added

Wed Feb 08 02:56:24 2012 KENTNL [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #74675 for Dist-Zilla-Plugin-MetaProvides-Package: Should ignore "private" packages

Preferred bug tracker