Skip Menu |

This queue is for tickets about the Diamond CPAN distribution.

Report information
The Basics
Id: 74594
Status: new
Priority: 0/
Queue: Diamond
People
Owner: Nobody in particular
Requestors: mst [...] shadowcat.co.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Feb 01 15:18:36 2012 mst [...] shadowcat.co.uk - Ticket created
Subject: Code taken from Task::Plack needs to be credited
Date: Wed, 1 Feb 2012 19:39:26 +0000
To: bugs-Diamond [...] rt.cpan.org
From: Matt S Trout <mst [...] shadowcat.co.uk>
It's traditional to include at the very least a comment, and preferably also a note in the POD, mentioning when you copy code from another module - Diamond.pm's use of Task::Plack code definitely falls into this category. Also, if you're wanting to do the same things might it not be an idea to extract the code into a separate module so you and miyagawa can share it? -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our Catalyst commercial support, training and consultancy packages could help your team.