Skip Menu |

This queue is for tickets about the Image-Xbm CPAN distribution.

Report information
The Basics
Id: 7439
Status: resolved
Priority: 0/
Queue: Image-Xbm

People
Owner: Nobody in particular
Requestors: ashand [...] wetafx.co.nz
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Patches for Image::Xbm build
When trying to install Image::Info we had problems with it failing the Image::Xpm and Image::Xbm tests. The maintainer tightened up some of the constructor code to test for the existence of the source file, but forgot that the source might actually be a reference to a file handle and this fails the test saying the file is not readable. These two patches should go back to the maintainer of the Image::X[pb]m perl modules that would be good. NOTE: Your email address listed in CPAN is currently bouncing (summer at perl press dot com).
diff -urw Image-Xbm-1.08/Xbm.pm Image-Xbm-1.08.patched/Xbm.pm --- Image-Xbm-1.08/Xbm.pm 2000-11-10 08:05:51.000000000 +1300 +++ Image-Xbm-1.08.patched/Xbm.pm 2004-08-22 17:16:09.000000000 +1200 @@ -140,7 +140,9 @@ } my $file = $self->get( '-file' ) ; - $self->load if defined $file and -r $file and not $self->{'-bits'} ; + if (defined $file and not $self->{-bits}) { + $self->load if ref $file or -r $file; + } croak "new() `$file' not found or unreadable" if defined $file and not defined $self->get( '-width' ) ;
As there no problems anymore with Image::Info and XBM support, I suppose that this patch is not needed anymore. Regards, Slaven