Bug #7436 for XML-SAX-Writer: Test failure with newer Text::Iconvs

Sun Aug 22 03:59:12 2004 scop [...] cpan.org - Ticket created

Subject:

Test failure with newer Text::Iconvs

Using Text-Iconv 1.4, make test fails with: t/05basic........NOK 18# Failed test (t/05basic.t at line 51) # iconv converter for real encoding isn't a 'Text::Iconv' it's a 'Text::IconvPtr' Looks sort of harmless to me though. I guess this would happen also with Text-Iconv 1.3 (see its change log).

Sun Aug 22 04:07:27 2004 scop [...] cpan.org - Correspondence added

From:

ville.skytta [...] iki.fi

Here's a quick and dirty hack to fix this, tested only with Text::Iconv 1.4.

--- t/05basic.t~ 2002-08-01 18:59:15.000000000 +0300 +++ t/05basic.t 2004-08-22 11:03:36.038144470 +0300 @@ -7,6 +7,7 @@ use strict; use Test::More tests => 27; +use Text::Iconv; BEGIN { use_ok('XML::SAX::Writer'); } @@ -48,7 +49,9 @@ # different inits (mostly for Consumer DWIM) $w1->{EncodeFrom} = 'iso-8859-1'; $w1->start_document; -isa_ok($w1->{Encoder}, 'Text::Iconv', 'iconv converter for real encoding'); +my $iconv_class = 'Text::Iconv'; +$iconv_class .= 'Ptr' if ($Text::Iconv::VERSION >= 1.3); +isa_ok($w1->{Encoder}, $iconv_class, 'iconv converter for real encoding'); $w1->{Output} = 'test_file_for_output'; $w1->start_document;

Fri Jul 08 02:27:53 2005 Marek.Rouchal [...] gmx.net - Correspondence added

From:

marek.rouchal [...] infineon.com

[SCOP - Sun Aug 22 04:07:27 2004]: Show quoted text

> Here's a quick and dirty hack to fix this, tested only with > Text::Iconv 1.4.

I confirm that this patch works ok - please update XML-SAX-Writer on CPAN, it is annoying when installing 100s of modules with CPAN and 'install Bundle::AllMyModules' and here and there some break because of such simple errors. Thanks a lot, Marek

Wed Feb 01 09:01:05 2006 MIROD [...] cpan.org - Taken

Tue Sep 05 03:15:06 2006 PCIMPRICH [...] cpan.org - Correspondence added

Fixed in upcoming v0.50. I don't have rights to close this ticket at this moment.

Tue Sep 05 03:15:08 2006 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 07 23:55:24 2009 cpan [...] prather.org - Correspondence added

This should have been closed years ago. Closing now. -Chris

Tue Jul 07 23:55:27 2009 cpan [...] prather.org - Status changed from 'open' to 'resolved'