Skip Menu |

This queue is for tickets about the DB_File CPAN distribution.

Report information
The Basics
Id: 74336
Status: resolved
Priority: 0/
Queue: DB_File

People
Owner: Nobody in particular
Requestors: perlbug-followup [...] perl.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.826



CC: bug-DB_File [...] rt.cpan.org
Subject: [perl #108970] [PATCH] f6722c7 fix wrong DB_File/t/db-btree.t
Date: Tue, 24 Jan 2012 13:13:15 -0800
To: "OtherRecipients of perl Ticket #108970":;
From: "Father Chrysostomos via RT" <perlbug-followup [...] perl.org>
Forwarding.... On Tue Jan 24 13:07:02 2012, rurban@cpanel.net wrote: Show quoted text
> > This is a bug report for perl from rurban@cpanel.net, > generated with the help of perlbug 1.39 running under perl 5.15.7. > > From f6722c7b0c76fd425930e632fda0224c0e27f1b2 Mon Sep 17 00:00:00 2001 > From: Reini Urban <rurban@x-ray.at> > Date: Tue, 24 Jan 2012 15:05:43 -0600 > Subject: [PATCH] fix wrong DB_File/t/db-btree.t > > --- > cpan/DB_File/t/db-btree.t | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cpan/DB_File/t/db-btree.t b/cpan/DB_File/t/db-btree.t > index 29c70a1..ab02407 100644 > --- a/cpan/DB_File/t/db-btree.t > +++ b/cpan/DB_File/t/db-btree.t > @@ -566,9 +566,9 @@ sub ArrayCompare > > return 0 if @$a != @$b ; > > - foreach (1 .. length @$a) > + foreach (0 .. @$a-1) > { > - return 0 unless $$a[$_] eq $$b[$_] ; > + return 0 unless $$a[$_] eq $$b[$_]; > } > > 1 ;
-- Father Chrysostomos --- via perlbug: queue: perl5 status: new https://rt.perl.org:443/rt3/Ticket/Display.html?id=108970
Thanks. Fix uploaded to CPAN in DB_File-1.825 Paul
On Tue Jan 24 17:36:56 2012, PMQS wrote: Show quoted text
> Thanks. Fix uploaded to CPAN in DB_File-1.825
In perl only half of the fix appeared. Please compare my patch. The first array elements $$a[0] are never checked still. -- Reini Urban
On Tue Jan 24 20:28:29 2012, RURBAN wrote: Show quoted text
> On Tue Jan 24 17:36:56 2012, PMQS wrote:
> > Thanks. Fix uploaded to CPAN in DB_File-1.825
> > In perl only half of the fix appeared. Please compare my patch. > > The first array elements $$a[0] are never checked still.
Oops! Well spotted. DB_File-1.825 now headed to CPAN. Payl
On Wed Jan 25 03:16:27 2012, PMQS wrote: Show quoted text
> On Tue Jan 24 20:28:29 2012, RURBAN wrote:
> > On Tue Jan 24 17:36:56 2012, PMQS wrote:
> > > Thanks. Fix uploaded to CPAN in DB_File-1.825
> > > > In perl only half of the fix appeared. Please compare my patch. > > > > The first array elements $$a[0] are never checked still.
> > Oops! Well spotted. DB_File-1.825 now headed to CPAN.
Should, of course, say thet DB_File-1.826 headed to CPAN Paul
CC: perlbug-followup [...] perl.org
Subject: Re: [rt.cpan.org #74336] [perl #108970] [PATCH] f6722c7 fix wrong DB_File/t/db-btree.t
Date: Wed, 25 Jan 2012 19:45:41 +0000
To: Paul Marquess via RT <bug-DB_File [...] rt.cpan.org>
From: "Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>
On Wed, Jan 25, 2012 at 03:17:48AM -0500, Paul Marquess via RT wrote: Show quoted text
> > > Should, of course, say thet DB_File-1.826 headed to CPAN >
Updated in blead with commit b34385a668b1275a17bd3e8d94e6c6decb78edf5 Many thanks. -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================
Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.