Bug #74283 for Catalyst-Plugin-AutoCRUD: make test fails with DBIx::Class older than 0.08127

Mon Jan 23 15:28:45 2012 martin.rusko [...] gmail.com - Ticket created

CC:	oliver [...] cpan.org
Subject:	make test fails with DBIx::Class older than 0.08127
Date:	Mon, 23 Jan 2012 21:28:36 +0100
To:	bug-Catalyst-Plugin-AutoCRUD [...] rt.cpan.org
From:	Martin Rusko <martin.rusko [...] gmail.com>

Hi Oliver, so according to commit https://github.com/rbuels/Catalyst-Plugin-AutoCRUD/commit/b8a945eafe86a725ab2e58405f0bc136b559120e there should be variable $skip_dangling_rels which gets set to 1 if DBIx::Class has lower version than 0.08127. But if I look into CPAC 2.113450 sources, this variable is used in SleeveNotes.pm but never set anywhere. Best Regards, Martin On Mon, Jan 23, 2012 at 5:56 PM, Martin Rusko <martin.rusko@gmail.com> wrote: Show quoted text

> OK, found just now some discussion at > https://github.com/ollyg/Catalyst-Plugin-AutoCRUD/pull/11 > > I'm going to digest it to see if it applies to me. DBIx::Class in use > in my case is 0.08123 (from Debian/Squeeze). > > Martin > > > On Mon, Jan 23, 2012 at 5:49 PM, Martin Rusko <martin.rusko@gmail.com> wrote:

>> Hi Oliver, >> >> I'm trying to use your module Catalyst-Plugin-AutoCRUD-2.113450, but >> I'm failing test 10-www.t with following error message ... >> >> [error] Caught exception in >> TestApp::Model::AutoCRUD::StorageEngine::DBIC->schema_metadata >> "translate: Error with parser 'SQL::Translator::Parser::DBIx::Class': >> DBIx::Class::ResultSource::reverse_relationship_info(): Can't find >> source for Nonexistent::Schema::Noggin at >> /usr/share/perl5/SQL/Translator/Parser/DBIx/Class.pm line 168" >> [error] Caught exception in >> TestApp::Controller::AutoCRUD::Root->do_meta "Can't bless >> non-reference value at lib/SQL/Translator/AutoCRUD/Quick.pm line 31." >> [error] Caught exception in >> TestApp::Controller::AutoCRUD::Root->bootstrap "Can't call method "t" >> on an undefined value at >> lib/Catalyst/Plugin/AutoCRUD/Controller/Root.pm line 191." >> >> I can see that such non-existent schema is referenced in >> t/lib/TestApp/Schema/SleeveNotes.pm file. Am I missing anything or >> what is going on, please? Any hint where to turn and look is >> appreciated. >> >> Best Regards, >> Martin >> -- >> Martin Rusko | martin.rusko@gmail.com | tel: +46 8 524 98091 | mobile: >> +46 768 598091 | mobile: +421 903 246 698

Tue Jan 24 14:39:51 2012 OLIVER [...] cpan.org - Correspondence added

Hi Martin, On Mon Jan 23 15:28:45 2012, martin.rusko@gmail.com wrote: Show quoted text

> so according to commit > https://github.com/rbuels/Catalyst-Plugin- > AutoCRUD/commit/b8a945eafe86a725ab2e58405f0bc136b559120e > there should be variable $skip_dangling_rels which gets set to 1 if > DBIx::Class has lower version than 0.08127. > > But if I look into CPAC 2.113450 sources, this variable is used in > SleeveNotes.pm but never set anywhere.

Many thanks for your patience, and investigation. The patch on github to which you refer is for the 1.x train of this module. When I rewrote the module for version 2.x I added code which should detect dangling references in schemas and cope with them: https://metacpan.org/source/OLIVER/Catalyst-Plugin-AutoCRUD- 2.113450/lib/SQL/Translator/Filter/AutoCRUD/StorageEngine/DBIC/Relationships.pm#L82 It was a bit sloppy of me not to update the test file, I admit! My preference would be for updating the dependencies so that only more recent versions of DBIx::Class are supported. In general this is not what I do (for Catalyst I try to maintain compatibility with pre-Moose versions, for example). However in the case of DBIx::Class there are new features which improve performance and remove bugs which I feel the end-user ought to have. I see you have another ticket open which refers to DBIx::Class 0.08125. Would it be sufficient for both your reported issues to specify 0.08127 as the minimum DBIx::Class release, then? This is roughly one year old and older than the 2.x release of AutoCRUD so I'm hoping not too contentious with the user community. regards, oliver.

Tue Jan 24 14:39:52 2012 The RT System itself - Status changed from 'new' to 'open'

Tue Jan 24 17:04:35 2012 martin.rusko [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #74283] make test fails with DBIx::Class older than 0.08127
Date:	Tue, 24 Jan 2012 23:04:28 +0100
To:	bug-Catalyst-Plugin-AutoCRUD [...] rt.cpan.org
From:	Martin Rusko <martin.rusko [...] gmail.com>

Hi Oliver, yes, it's fine with me to list 0.08127 as minimum requirement. Thanks! Best Regards, Martin On Tue, Jan 24, 2012 at 8:39 PM, Oliver Gorwits via RT <bug-Catalyst-Plugin-AutoCRUD@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=74283 > > > Hi Martin, > > On Mon Jan 23 15:28:45 2012, martin.rusko@gmail.com wrote:

>> so according to commit >> https://github.com/rbuels/Catalyst-Plugin- >> AutoCRUD/commit/b8a945eafe86a725ab2e58405f0bc136b559120e >> there should be variable $skip_dangling_rels which gets set to 1 if >> DBIx::Class has lower version than 0.08127. >> >> But if I look into CPAC 2.113450 sources, this variable is used in >> SleeveNotes.pm but never set anywhere.

> > Many thanks for your patience, and investigation. > > The patch on github to which you refer is for the 1.x train of this module. > > When I rewrote the module for version 2.x I added code which should detect dangling references in schemas and cope > with them: > > https://metacpan.org/source/OLIVER/Catalyst-Plugin-AutoCRUD- > 2.113450/lib/SQL/Translator/Filter/AutoCRUD/StorageEngine/DBIC/Relationships.pm#L82 > > It was a bit sloppy of me not to update the test file, I admit! > > My preference would be for updating the dependencies so that only more recent versions of DBIx::Class are supported. > In general this is not what I do (for Catalyst I try to maintain compatibility with pre-Moose versions, for example). > However in the case of DBIx::Class there are new features which improve performance and remove bugs which I feel > the end-user ought to have. > > I see you have another ticket open which refers to DBIx::Class 0.08125. Would it be sufficient for both your reported > issues to specify 0.08127 as the minimum DBIx::Class release, then? This is roughly one year old and older than the > 2.x release of AutoCRUD so I'm hoping not too contentious with the user community. > > regards, > oliver.

Wed Jan 25 17:35:58 2012 OLIVER [...] cpan.org - Reference by ticket #74320 added

Wed Jan 25 17:37:24 2012 OLIVER [...] cpan.org - Status changed from 'open' to 'patched'

Wed Jan 25 17:40:27 2012 OLIVER [...] cpan.org - Status changed from 'patched' to 'resolved'