Skip Menu |

This queue is for tickets about the Module-Find CPAN distribution.

Report information
The Basics
Id: 74251
Status: resolved
Priority: 0/
Queue: Module-Find

People
Owner: crenz [...] cpan.org
Requestors: wyant [...] cpan.org
Cc: KENTNL [...] cpan.org
AdminCc:

Bug Information
Severity: Important
Broken in: 0.10
Fixed in: (no value)



Subject: [patch] defined(@array) is deprecated under Perl 5.15.7
Actually, defined(@array) has been deprecated for a while, but 5.15.7 started emitting deprecation warnings for package variables. Before, only lexical variables were warned. The symptom is messages like this from the tests: t/1-use.t ................ defined(@array) is deprecated at /Users/tom/.cpan/build/Module-Find-0.10-bwzr6b/blib/lib/Module/Find.pm line 182. (Maybe you should just omit the defined()?) t/1-use.t ................ ok I have marked this 'important' because although Module::Find passes its tests, any distribution that uses Module::Find and that tests for unexpected warnings (e.g. Module-CPANTS-Analyse) will fail. The solution is simply to omit the 'defined'. A patch is attached.
Subject: Module-Find.patch
--- Find.old 2010-02-26 10:40:55.000000000 -0500 +++ Find.pm 2012-01-22 19:16:47.000000000 -0500 @@ -7,7 +7,7 @@ use File::Spec; use File::Find; -our $VERSION = '0.10'; +our $VERSION = '0.10_01'; our $basedir = undef; our @results = (); @@ -179,7 +179,7 @@ my $dir = File::Spec->catdir(split(/::/, $category)); my @dirs; - if (defined @Module::Find::ModuleDirs) { + if (@Module::Find::ModuleDirs) { @dirs = map { File::Spec->catdir($_, $dir) } @Module::Find::ModuleDirs; } else {

For your convenience, I have made a fork of the Module-Find Git repository, and applied wyant's patch, and produced a consumable dist for anyone who is interested  or needs something simple to use with their perl blead test runs.

 

https://github.com/kentfredric/Module-Find/commits/perl-5-15

 

You should be able to get going simply by

cpanm "https://github.com/downloads/kentfredric/Module-Find/Module-Find-0.10_01.tar.gz"

Hope this is helpful.

--kent
 

The problem is still there with perl 5.16.0 RC0. Regards, Slaven
On Sun May 13 09:32:13 2012, SREZIC wrote: Show quoted text
> The problem is still there with perl 5.16.0 RC0. > > Regards, > Slaven
And now 5.16.0 is out for real real.
Thanks for the notice, and sorry for the delay. I've uploaded a new version to CPAN which should fix this.