Skip Menu |

This queue is for tickets about the Data-Show CPAN distribution.

Report information
The Basics
Id: 74146
Status: open
Priority: 0/
Queue: Data-Show

People
Owner: Nobody in particular
Requestors: liannaee [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Bug in t/show.t
I'm using cpanm to install Data::Show on 5.14.2, and it's not getting through the tests: cpanm (App::cpanminus) 1.5007 on perl 5.014002 built for i686-linux Work directory is /home/lianna/.cpanm/work/1326966342.5738 You have make /usr/bin/make You have /usr/bin/wget You have /bin/tar: tar (GNU tar) 1.22 Copyright (C) 2009 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. You have /usr/bin/unzip Searching Data::Show on cpanmetadb ... --> Working on Data::Show Fetching http://search.cpan.org/CPAN/authors/id/D/DC/DCONWAY/Data-Show-0.001002.tar.gz -> OK Unpacking Data-Show-0.001002.tar.gz Entering Data-Show-0.001002 Checking configure dependencies from META.yml Configuring Data-Show-0.001002 Running Build.PL Created MYMETA.yml and MYMETA.json Creating new 'Build' script for 'Data-Show' version '0.001002' -> OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0 ... Yes (0.98) Checking if you have version 0 ... Yes (0.88) Checking if you have Data::Dump 1.17 ... Yes (1.21) Building and testing Data-Show-0.001002 Building Data-Show # Testing Data::Show 0.001002 t/00.load.t .. ok t/pod.t ...... ok # Failed test ': "173.205080756888" # ' # at t/show.t line 34. # got: ' 173.205080756888 # ' # expected: ' "173.205080756888" # ' # Looks like you failed 1 test of 58. t/show.t ..... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/58 subtests Test Summary Report ------------------- t/show.t (Wstat: 256 Tests: 58 Failed: 1) Failed test: 48 Non-zero exit status: 1 Files=3, Tests=60, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.18 cusr 0.05 csys = 0.28 CPU) Result: FAIL Failed 1/3 test programs. 1/60 subtests failed. I'm guessing the quotes around the expected string in t/show.t at line 85 should not be there? When I remove those quotes it gets through all tests without issues.
Subject: Re: [rt.cpan.org #74146] Bug in t/show.t
Date: Fri, 20 Jan 2012 17:50:39 +1100
To: bug-Data-Show [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Hi Lianna Show quoted text
> I'm guessing the quotes around the expected string in t/show.t at line > 85 should not be there? When I remove those quotes it gets through all > tests without issues.
Yes. Data::Dump (which Data::Show uses for dumping) changed its behaviour in a recent release: it now no longer quotes floats. Because I have to support folks using both older and newer versions of Data::Dump, I've now removed that test from the latest release (which I just uploaded to CPAN). The latest release has some other worthwhile improvements (in particular: better handing of quotelikes, and of hashes), so it might be worth reinstalling it, once the update has propagated. Thanks for the report, and I hope you find Data::Show useful. All the very best, Damian