Bug #74036 for Tk: Tk.pm fails to build on ActivePerl 5.12 and 5.14

Mon Jan 16 07:18:06 2012 johannes.madel [...] gmx.de - Ticket created

Subject:

Tk.pm fails to build on ActivePerl 5.12 and 5.14

Hey Folks, when trying to install Tk.pm using cpan on ActivePerl Version 5.12 or 5.14, build fails. The errormessage is the folloing: ------------ C:/Perl/site/bin/gcc.exe -c -I.. -I.. -I../pTk/mTk/xlib -I. -Ibitmaps - I.. -I../pTk/mTk/xlib -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DHA VE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT - DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T - DPERL_MSVCRT_READFIX -DHASAT TRIBUTE -fno-strict-aliasing -mms-bitfields -DPERLDLL -O2 - DVERSION=\"804.03\" -DXS_VERSION=\"804.03\" "-IC:\Perl\lib\CORE" - Wal l -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES__ ximage.c C:/Perl/site/bin/gcc.exe -c -I.. -I.. -I../pTk/mTk/xlib -I. -Ibitmaps - I.. -I../pTk/mTk/xlib -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DHA VE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT - DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T - DPERL_MSVCRT_READFIX -DHASAT TRIBUTE -fno-strict-aliasing -mms-bitfields -DPERLDLL -O2 - DVERSION=\"804.03\" -DXS_VERSION=\"804.03\" "-IC:\Perl\lib\CORE" - Wal l -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES__ xutil.c rc -fo tk.res -r -i . -i mTk\win\rc mTk\win\rc\tk.rc dmake.exe: Error code 197, while making 'tk.res' dmake.exe: Error code 255, while making 'pTk\libpTk.a' SREZIC/Tk-804.030.tar.gz C:\Perl\site\bin\dmake.exe -- NOT OK CPAN: YAML::XS loaded ok (v0.35) ------------ When no compiler is present, ActivePerl downloads a version of MinGW and installs it. I assume failing command tries to call to be the windows resource compiler rc.exe. Maybe it could instead call the command windres.exe, which is the resource compiler which is downloaded with mingw. Best regards, Efewig

Mon Jan 16 17:22:27 2012 SREZIC [...] cpan.org - Correspondence added

On 2012-01-16 07:18:06, Efewig wrote: Show quoted text

> Hey Folks, > > when trying to install Tk.pm using cpan on ActivePerl Version 5.12 or > 5.14, build fails. The errormessage is the folloing: > ------------ > C:/Perl/site/bin/gcc.exe -c -I.. -I.. -I../pTk/mTk/xlib -I. -Ibitmaps - > I.. -I../pTk/mTk/xlib -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DHA > VE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT - > DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T - > DPERL_MSVCRT_READFIX -DHASAT > TRIBUTE -fno-strict-aliasing -mms-bitfields -DPERLDLL -O2 - > DVERSION=\"804.03\" -DXS_VERSION=\"804.03\" "-IC:\Perl\lib\CORE" - > Wal > l -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES__ > ximage.c > C:/Perl/site/bin/gcc.exe -c -I.. -I.. -I../pTk/mTk/xlib -I. -Ibitmaps - > I.. -I../pTk/mTk/xlib -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DHA > VE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT - > DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T - > DPERL_MSVCRT_READFIX -DHASAT > TRIBUTE -fno-strict-aliasing -mms-bitfields -DPERLDLL -O2 - > DVERSION=\"804.03\" -DXS_VERSION=\"804.03\" "-IC:\Perl\lib\CORE" - > Wal > l -Wno-implicit-int -Wno-comment -Wno-unused -D__USE_FIXED_PROTOTYPES__ > xutil.c > rc -fo tk.res -r -i . -i mTk\win\rc mTk\win\rc\tk.rc > dmake.exe: Error code 197, while making 'tk.res' > dmake.exe: Error code 255, while making 'pTk\libpTk.a' > SREZIC/Tk-804.030.tar.gz > C:\Perl\site\bin\dmake.exe -- NOT OK > CPAN: YAML::XS loaded ok (v0.35) > ------------ > > When no compiler is present, ActivePerl downloads a version of MinGW > and installs it. I assume failing command tries to call to be the > windows resource compiler rc.exe. Maybe it could instead call the > command windres.exe, which is the resource compiler which is downloaded > with mingw.

Hello, can you try again with the attached patch (it's just removing an anchor from the gcc regexp in pTk/Makefile.PL)? Regards, Slaven

Subject:

gcc.diff

diff --git i/pTk/Makefile.PL w/pTk/Makefile.PL index 2f4788c..5b08abe 100644 --- i/pTk/Makefile.PL +++ w/pTk/Makefile.PL @@ -243,7 +243,7 @@ if ($Tk::MMutil::IsWin32 or ($win_arch eq 'MSWin32' and $^O eq 'cygwin')) { my $cc = $Config{'cc'}; my $file = 'tk.res'; - if ($cc =~ /^gcc/i) + if ($cc =~ /gcc/i) { $file = 'tkres$(OBJ_EXT)'; $dep .= "$file : mTk/win/rc/tk.rc\n\t";

Mon Jan 16 17:22:28 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 16 17:49:30 2012 SREZIC [...] cpan.org - Correspondence added

On 2012-01-16 17:22:27, SREZIC wrote: Show quoted text

> On 2012-01-16 07:18:06, Efewig wrote:

[...] Show quoted text

> > Hello, > > can you try again with the attached patch (it's just removing an anchor > from the gcc regexp in pTk/Makefile.PL)? >

That said, I just realized that there are more places using /^gcc/ instead of /gcc/. So can you use this patch (gcc2.diff) instead of the previous one and tell me whether it works? Regards, Slaven

Subject:

gcc2.diff

diff --git c/Makefile.PL w/Makefile.PL index 38e9c77..c4e545f 100755 --- c/Makefile.PL +++ w/Makefile.PL @@ -142,7 +142,7 @@ sub MY::post_initialize } else { push(@{$self->{'O_FILES'}}, - ($Config{'cc'} =~ /^gcc/i) ? + ($Config{'cc'} =~ /gcc/i) ? 'pTk\\tkres$(OBJ_EXT)' : 'pTk\\tk.res'); } } diff --git c/Tk/MMutil.pm w/Tk/MMutil.pm index 1a69e56..59a64e0 100644 --- c/Tk/MMutil.pm +++ w/Tk/MMutil.pm @@ -551,7 +551,7 @@ sub TkExtMakefile $i = "-I$tk $i"; $i = "-I$ptk $i"; } - if ($IsWin32 && $Config{'cc'} =~ /^gcc/i) + if ($IsWin32 && $Config{'cc'} =~ /gcc/i) { my $base = $Config{'libpth'}; #$base =~ s#lib$#i386-mingw32/lib#; diff --git c/pTk/Makefile.PL w/pTk/Makefile.PL index 2f4788c..5b08abe 100644 --- c/pTk/Makefile.PL +++ w/pTk/Makefile.PL @@ -243,7 +243,7 @@ if ($Tk::MMutil::IsWin32 or ($win_arch eq 'MSWin32' and $^O eq 'cygwin')) { my $cc = $Config{'cc'}; my $file = 'tk.res'; - if ($cc =~ /^gcc/i) + if ($cc =~ /gcc/i) { $file = 'tkres$(OBJ_EXT)'; $dep .= "$file : mTk/win/rc/tk.rc\n\t";

Mon May 20 13:18:07 2013 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'

Sun May 26 05:05:51 2013 SREZIC [...] cpan.org - Status changed from 'patched' to 'resolved'

Sun May 26 05:05:51 2013 SREZIC [...] cpan.org - Fixed in 804.031 added