Skip Menu |

This queue is for tickets about the Net-DHCP CPAN distribution.

Report information
The Basics
Id: 73972
Status: resolved
Priority: 0/
Queue: Net-DHCP
People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc: sprout [...] cpan.org
AdminCc:
Bug Information
Severity: Important
Broken in: 0.67_1
Fixed in: (no value)

History Show all quoted text
  Fri Jan 13 02:24:00 2012 ANDK [...] cpan.org - Ticket created
CC: sprout [...] cpan.org
Subject: Lvalue fixes in bleadperl reveal precedence bug in DJZORT/Net-DHCP-0.67_1.tar.gz
Since commit v5.15.6-179-gda1dff9 perl complains about this line 43 in Net::DHCP::Packet (some whitespace omitted to get it on one line): exists($args{Htype})?$self->htype($args{Htype}) : $self->{htype}=1; Can't modify non-lvalue subroutine call at /tmp/loop_over_bdir-XsCq11/Net-DHCP-0.67_1-UnPfM3/blib/lib/Net/DHCP/Packet.pm line 43. This looks to me like a precedence bug in line 43 that was simply swallowed by perl so far. I suppose the code wants to add parentheses around the assignment on the right. exists($args{Htype})?$self->htype($args{Htype}) : ($self->{htype}=1); I'm wondering how frequent this mistake is. HTH && Regards,
  Fri Jan 13 03:06:03 2012 dean [...] fragfest.com.au - Correspondence added
That section is lowsy, ive made it more sensible and uploaded a new dev release via PAUSE. Hopefully it will solve the problem. On Fri Jan 13 02:24:00 2012, ANDK wrote: Show quoted text
> Since commit v5.15.6-179-gda1dff9 perl complains about this line 43 in > Net::DHCP::Packet (some whitespace omitted to get it on one line): > > exists($args{Htype})?$self->htype($args{Htype}) : $self->{htype}=1; > > Can't modify non-lvalue subroutine call at > /tmp/loop_over_bdir-XsCq11/Net-DHCP-0.67_1- > UnPfM3/blib/lib/Net/DHCP/Packet.pm > line 43. > > This looks to me like a precedence bug in line 43 that was simply > swallowed by perl so far. I suppose the code wants to add parentheses > around the assignment on the right. > > exists($args{Htype})?$self->htype($args{Htype}) : ($self->{htype}=1); > > I'm wondering how frequent this mistake is. > > HTH && Regards,
  Fri Jan 13 03:06:05 2012 The RT System itself - Status changed from 'new' to 'open'
  Sun Jan 15 21:01:36 2012 dean [...] fragfest.com.au - Correspondence added
resolved in latest release
  Sun Jan 15 21:01:38 2012 dean [...] fragfest.com.au - Status changed from 'open' to 'resolved'