Bug #73873 for DBI-Shell: Useless localization of scalar assignment at /usr/local/share/perl/5.10.1/DBI/Format.pm line 377

Tue Jan 10 07:23:14 2012 bohica [...] ntlworld.com - Ticket created

Subject:

Useless localization of scalar assignment at /usr/local/share/perl/5.10.1/DBI/Format.pm line 377

Using Perl 5.10.1 and running up dbi shell I get: Useless localization of scalar assignment at /usr/local/share/perl/5.10.1/DBI/Format.pm line 377. I think line 377 needs to be changed from: local( $^W = 0 ); to local( $^W ) = 0; Martin -- Martin J. Evans Wetherby, UK

Sat Oct 07 20:32:50 2017 KENTNL [...] cpan.org - Correspondence added

Subject:

0002-Fix-useless-localization-of-scalar-assignment.patch

From ef8efc5b80c9395c01f23e5acd28bb3ee7810b54 Mon Sep 17 00:00:00 2001 From: Kent Fredric <kentnl@gentoo.org> Date: Sun, 8 Oct 2017 13:08:20 +1300 Subject: Fix useless localization of scalar assignment Bug: https://rt.cpan.org/Ticket/Display.html?id=73873 --- lib/DBI/Format.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DBI/Format.pm b/lib/DBI/Format.pm index 49cd7dd..bc985f9 100755 --- a/lib/DBI/Format.pm +++ b/lib/DBI/Format.pm @@ -374,7 +374,7 @@ sub header { sub row { my($self, $rowref) = @_; - local( $^W = 0 ); + local ($^W) = 0; my @row = @$rowref; my $fh = $self->{'fh'}; print $fh (join($self->{sep}, @row), "\n"); -- 2.14.1

Sat Oct 07 20:32:51 2017 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 08 19:11:19 2019 DLAMBLEY [...] cpan.org - Correspondence added

Thank you for your patch! It seems to resolve the problem. I have merged it into 11.95_01.

Fri Nov 08 19:11:19 2019 DLAMBLEY [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Nov 08 19:11:19 2019 DLAMBLEY [...] cpan.org - Taken