Bug #73837 for Term-ReadLine-Perl: Adding ReadHistory, WriteHistory and StifleHIstory (patch attached)

Sun Jan 08 23:18:42 2012 Rocky Bernstein - Ticket created

Subject:

Adding ReadHistory, WriteHistory and StifleHIstory (patch attached)

Hi - I have been working working on a rewrite of the perl5db debugger (or rather a port of the Ruby trepanning debuggers to Perl). In doing this, it would be useful to be able to read and write the debugger commands to a history file. Attached for your consideration is a patch that adds to Term::ReadLine::Perl the corresponding history routines in Term::ReadLine::Gnu. In fact, I have also included part of the history test found in Term::ReadLine::Gnu which I used to help me verify that the two work the same. Thanks, rocky

Subject:

r.diff

Message body is not shown because it is too large.

Mon Jan 09 08:31:43 2012 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #73837] Adding ReadHistory, WriteHistory and StifleHIstory (patch attached)
Date:	Mon, 9 Jan 2012 05:31:27 -0800
To:	Rocky Bernstein via RT <bug-Term-ReadLine-Perl [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Sun, Jan 08, 2012 at 11:18:42PM -0500, Rocky Bernstein via RT wrote: Show quoted text

> I have been working working on a rewrite of the perl5db debugger (or > rather a port of the Ruby trepanning debuggers to Perl). > > In doing this, it would be useful to be able to read and write the > debugger commands to a history file. > > Attached for your consideration is a patch that adds to > Term::ReadLine::Perl the corresponding history routines in > Term::ReadLine::Gnu. In fact, I have also included part of the history > test found in Term::ReadLine::Gnu which I used to help me verify that > the two work the same.

A lot of thanks! I'm a little bit swamped at the time. If you do not see any followup, please remind me in a month. Yours, Ilya

Mon Jan 09 08:31:44 2012 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 12 00:31:31 2012 Rocky Bernstein - Correspondence added

On Mon Jan 09 08:31:43 2012, nospam-abuse@ilyaz.org wrote: Show quoted text

> On Sun, Jan 08, 2012 at 11:18:42PM -0500, Rocky Bernstein via RT wrote:

> > I have been working working on a rewrite of the perl5db debugger (or > > rather a port of the Ruby trepanning debuggers to Perl). > > > > In doing this, it would be useful to be able to read and write the > > debugger commands to a history file. > > > > Attached for your consideration is a patch that adds to > > Term::ReadLine::Perl the corresponding history routines in > > Term::ReadLine::Gnu. In fact, I have also included part of the history > > test found in Term::ReadLine::Gnu which I used to help me verify that > > the two work the same.

> > A lot of thanks! I'm a little bit swamped at the time. If you do not > see any followup, please remind me in a month. > > Yours, > Ilya

I've revised the patch a to cover (and pass) more of the Term::ReadLine::Gnu tests. For example, from the tests I see that Read/WriteHistory return values are the negation of read/write_history. (In other situations, the CamelCase routines work the same way.) Although there is much more that could be done, these changes cover everything I need in the debugger to implement gdb's {set,show} history {filename,save,size}. Thanks again for considering, Rocky

Subject:

r2.diff

Message body is not shown because it is too large.

Sat Feb 11 11:52:42 2012 Rocky Bernstein - Correspondence added

RT-Send-CC:

nospam-abuse [...] ilyaz.org

On Mon Jan 09 08:31:43 2012, nospam-abuse@ilyaz.org wrote: Show quoted text

> On Sun, Jan 08, 2012 at 11:18:42PM -0500, Rocky Bernstein via RT wrote:

> > I have been working working on a rewrite of the perl5db debugger (or > > rather a port of the Ruby trepanning debuggers to Perl). > > > > In doing this, it would be useful to be able to read and write the > > debugger commands to a history file. > > > > Attached for your consideration is a patch that adds to > > Term::ReadLine::Perl the corresponding history routines in > > Term::ReadLine::Gnu. In fact, I have also included part of the history > > test found in Term::ReadLine::Gnu which I used to help me verify that > > the two work the same.

> > A lot of thanks! I'm a little bit swamped at the time. If you do not > see any followup, please remind me in a month.

Ping. Show quoted text

> > Yours, > Ilya

Sat Mar 31 19:12:09 2012 Rocky Bernstein - Correspondence added

RT-Send-CC:

cpan [...] ilyaz.org, nospam-abuse [...] ilyaz.org

Any progress on this? On Sat Feb 11 11:52:42 2012, ROCKY wrote: Show quoted text

> On Mon Jan 09 08:31:43 2012, nospam-abuse@ilyaz.org wrote:

> > On Sun, Jan 08, 2012 at 11:18:42PM -0500, Rocky Bernstein via RT wrote:

> > > I have been working working on a rewrite of the perl5db debugger (or > > > rather a port of the Ruby trepanning debuggers to Perl). > > > > > > In doing this, it would be useful to be able to read and write the > > > debugger commands to a history file. > > > > > > Attached for your consideration is a patch that adds to > > > Term::ReadLine::Perl the corresponding history routines in > > > Term::ReadLine::Gnu. In fact, I have also included part of the history > > > test found in Term::ReadLine::Gnu which I used to help me verify that > > > the two work the same.

> > > > A lot of thanks! I'm a little bit swamped at the time. If you do not > > see any followup, please remind me in a month.

> > Ping. >

> > > > Yours, > > Ilya

> >

Mon Dec 03 14:07:36 2012 SHLOMIF [...] cpan.org - Correspondence added

On Sat Mar 31 19:12:09 2012, ROCKY wrote: Show quoted text

> Any progress on this? > >

Ping. I've been bitten by this bug too in the context of Devel-Trepan as well (as can be witnessed here - https://github.com/rocky/Perl-Devel-Trepan/issues/19 ). Ilya, you should merge Rocky's patch. Regards, -- Shlomi Fish Show quoted text

> On Sat Feb 11 11:52:42 2012, ROCKY wrote:

> > On Mon Jan 09 08:31:43 2012, nospam-abuse@ilyaz.org wrote:

> > > On Sun, Jan 08, 2012 at 11:18:42PM -0500, Rocky Bernstein via RT

wrote: Show quoted text

> > > > I have been working working on a rewrite of the perl5db debugger (or > > > > rather a port of the Ruby trepanning debuggers to Perl). > > > > > > > > In doing this, it would be useful to be able to read and write the > > > > debugger commands to a history file. > > > > > > > > Attached for your consideration is a patch that adds to > > > > Term::ReadLine::Perl the corresponding history routines in > > > > Term::ReadLine::Gnu. In fact, I have also included part of the

history Show quoted text

> > > > test found in Term::ReadLine::Gnu which I used to help me verify

that Show quoted text

> > > > the two work the same.

> > > > > > A lot of thanks! I'm a little bit swamped at the time. If you do not > > > see any followup, please remind me in a month.

> > > > Ping. > >

> > > > > > Yours, > > > Ilya

> > > >

> >