Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the YAML CPAN distribution.

Report information
The Basics
Id: 73673
Status: open
Priority: 0/
Queue: YAML
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 0.78
  • 0.79
  • 0.80
Fixed in: (no value)

History Show all quoted text
  Mon Jan 02 10:51:25 2012 KENTNL [...] cpan.org - Ticket created
Subject: dump-perl-types.t broken on Blead >= v5.15.5-469-g6cee328 
v5.15.5-469-g6cee328, v5.15.5-486-g423e8af , v5.15.5-502-gb7c4bcf , perl-5.15.6( release ):

  All fail t/dump-perl-types.t due to getting 

#     use strict 'refs';
#     BEGIN {
#         $^H{'strict/subs'} = undef;
#         $^H{'strict/refs'} = undef;
#         $^H{'strict/vars'} = undef;
#     }

instead of simply

#    use strict 'refs';

v5.15.6-172-g11e0f19, v5.15.6-179-gda1dff9,  v5.15.6-207-gd5e4555, v5.15.6-321-g8756617

All fail with

#       use strict;

Instead of

#       use strict 'refs';


http://www.cpantesters.org/cpan/report/2a994f02-3519-11e1-8d1f-0e329aeef8c6

^ Completely replicates my problem.

But for completeness, my build log and perl -V can be found here if they are deemed to be useful: https://gist.github.com/1551182 

Thanks =)

 

  Mon Jan 02 12:54:10 2012 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Jan 02 10:51:25 2012, KENTNL wrote: Show quoted text
> v5.15.5-469-g6cee328, v5.15.5-486-g423e8af , v5.15.5-502-gb7c4bcf , > perl-5.15.6( release ): > >   All fail t/dump-perl-types.t due to getting > > # use strict 'refs'; > # BEGIN { > # $^H{'strict/subs'} = undef; > # $^H{'strict/refs'} = undef; > # $^H{'strict/vars'} = undef; > # } > > instead of simply > > # use strict 'refs';
That was fixed in v5.15.6-78-g1c74777. Show quoted text
> > v5.15.6-172-g11e0f19, v5.15.6-179-gda1dff9, v5.15.6-207-gd5e4555, > v5.15.6-321-g8756617 > > All fail with > > # use strict; > > Instead of > > # use strict 'refs';
And that part, caused by v5.15.6-147-g415d4c6 (a B::Deparse bug fix), is the same as #73483, which was fixed by INGY/YAML-0.78.tar.gz. But I don’t have the right permissions to mark this as resolved.
  Mon Jan 02 12:54:11 2012 The RT System itself - Status changed from 'new' to 'open'
  Mon Jan 02 13:05:14 2012 KENTNL [...] cpan.org - Correspondence added
On 2012-01-03 06:54:10, SPROUT wrote:

Show quoted text
> And that part, caused by v5.15.6-147-g415d4c6 (a B::Deparse bug fix),
> is the same as
> #73483, which was fixed by INGY/YAML-0.78.tar.gz.
>

> But I don’t have the right permissions to mark this as resolved.

But I was running these tests on 0.78.tar.gz , doesn't this mean 0.78 *isn't* fixed? 

But thanks for the other link, I didn't see it in the resolved list -_-. I didn't think to check there for some reason.

 



  Mon Jan 02 13:11:17 2012 KENTNL [...] cpan.org - Correspondence added
On 2012-01-03 07:05:14, KENTNL wrote:
Show quoted text
> On 2012-01-03 06:54:10, SPROUT wrote:
>
> > And that part, caused by v5.15.6-147-g415d4c6 (a B::Deparse bug
> fix),
> > is the same as
> > #73483, which was fixed by INGY/YAML-0.78.tar.gz.
> >
>
> > But I don’t have the right permissions to mark this as resolved.
>
> But I was running these tests on 0.78.tar.gz , doesn't this mean 0.78
> *isn't*
> fixed?
>
> But thanks for the other link, I didn't see it in the resolved list
> -_-. I
> didn't think to check there for some reason.

Seems bug 73483 is *similar* but different. I compared 0.77 and 0.78 ( https://metacpan.org/diff/release/INGY/YAML-0.77/INGY/YAML-0.78 ) and it appears the only significant changes are to the tests themselves, and then only on "dump-code.t", not "dump-perl-types.t"

Which you'll see both failing in the linked perl bug, but is not solved in the patch.
  Mon Jan 02 15:32:49 2012 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Mon Jan 02 13:11:17 2012, KENTNL wrote: Show quoted text
> On 2012-01-03 07:05:14, KENTNL wrote:
> > On 2012-01-03 06:54:10, SPROUT wrote: > >
> > > And that part, caused by v5.15.6-147-g415d4c6 (a B::Deparse bug
> > fix),
> > > is the same as > > > #73483, which was fixed by INGY/YAML-0.78.tar.gz. > > >
> >
> > > But I don’t have the right permissions to mark this as resolved.
> > > > But I was running these tests on 0.78.tar.gz , doesn't this mean
> 0.78
> > *isn't* > > fixed? > > > > But thanks for the other link, I didn't see it in the resolved list > > -_-. I > > didn't think to check there for some reason.
> > Seems bug 73483 is *similar* but different. I compared 0.77 and 0.78 ( > https://metacpan.org/diff/release/INGY/YAML-0.77/INGY/YAML-0.78 ) and > it > appears the only significant changes are to the tests themselves, and > then only > on "dump-code.t", not "dump-perl-types.t" > > Which you'll see both failing in the linked perl bug, but is not > solved in the > patch.
I spoke too soon. Here is a patch for the other failure.
Subject: open_6WBowqSl.txt
diff -rup YAML-0.78-z1hwoG/t/dump-perl-types.t YAML-0.78-z1hwoG-copy/t/dump-perl-types.t --- YAML-0.78-z1hwoG/t/dump-perl-types.t 2011-04-19 05:02:48.000000000 -0700 +++ YAML-0.78-z1hwoG-copy/t/dump-perl-types.t 2012-01-02 12:31:50.000000000 -0800 @@ -1,5 +1,13 @@ use t::TestYAML tests => 14; +use B::Deparse; +if (new B::Deparse -> coderef2text ( sub { no strict; 1; use strict; 1; }) + =~ 'refs') { + local $/; + (my $data = <DATA>) =~ s/use strict/use strict 'refs'/g; + open DATA, '<', \$data; +} + filters { perl => ['eval', 'yaml_dump'] }; no_diff; @@ -36,7 +44,7 @@ sub { print "Hello, world\n"; } --- !!perl/code | { use warnings; - use strict 'refs'; + use strict; print "Hello, world\n"; } @@ -82,7 +90,7 @@ NAME: var3 CODE: !!perl/code | { use warnings; - use strict 'refs'; + use strict; print "Hello, world\n"; }
  Thu Feb 09 22:30:40 2012 ANDK [...] cpan.org - Broken in 0.79 added
  Thu Feb 09 22:32:52 2012 ANDK [...] cpan.org - Correspondence added
Version 0.79 missed one of the patches here: https://rt.cpan.org/Ticket/Attachment/1017625/530619/open_6WBowqSl.txt also available from $CPAN/authors/id/A/AN/ANDK/patches/YAML-0.78-SPROUT-01.patch.gz Best,
  Sat Feb 11 08:28:33 2012 ANDK [...] cpan.org - Severity Unimportant changed to Important
  Sat Feb 11 08:28:33 2012 ANDK [...] cpan.org - Broken in 0.80 added
  Mon Feb 20 21:40:47 2012 RURBAN [...] cpan.org - Correspondence added
See updated patch at https://rt.cpan.org/Ticket/Display.html?id=74826 -- Reini Urban
  Thu Aug 14 02:51:13 2014 ingy [...] cpan.org - Correspondence added
This issue has been copied to: https://github.com/ingydotnet/yaml-pm/issues/120 please take all future correspondence there. This ticket will remain open but please do not reply here. This ticket will be closed when the github issue is dealt with.