Skip Menu |

This queue is for tickets about the MooseX-StrictConstructor CPAN distribution.

Report information
The Basics
Id: 73664
Status: resolved
Priority: 0/
Queue: MooseX-StrictConstructor
People
Owner: Nobody in particular
Requestors: chip [...] pobox.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jan 02 02:03:34 2012 chip [...] pobox.com - Ticket created
Subject: Avoid reconstructing a hash on every construction
This code: $source .= <<"EOF"; my \%attrs = (@attrs); ... ends up creating %attrs on every construction. This is wasteful. Using 'state' would be better, or the pre-state equivalent. I've committed a patch to git branch "chip/fast1".
  Sat Jan 14 19:56:16 2012 chip [...] pobox.com - Correspondence added
From: chip [...] pobox.com
On Mon Jan 02 02:03:34 2012, CHIPS wrote: Show quoted text
> This code: > > $source .= <<"EOF"; > my \%attrs = (@attrs); > ... > > ends up creating %attrs on every construction. This is wasteful.
Using Show quoted text
> 'state' would be better, or the pre-state equivalent. > > I've committed a patch to git branch "chip/fast1".
The above is still in 0.18. WTF?
  Sun Jan 15 02:56:04 2012 autarch [...] urth.org - Correspondence added
Subject: Re: [rt.cpan.org #73664] Avoid reconstructing a hash on every construction
Date: Sun, 15 Jan 2012 01:55:55 -0600 (CST)
To: Chip Salzenberg via RT <bug-MooseX-StrictConstructor [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Sat, 14 Jan 2012, Chip Salzenberg via RT wrote: Show quoted text
> Queue: MooseX-StrictConstructor > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=73664 > > > On Mon Jan 02 02:03:34 2012, CHIPS wrote:
>> This code: >> >> $source .= <<"EOF"; >> my \%attrs = (@attrs); >> ... >> >> ends up creating %attrs on every construction. This is wasteful.
> Using
>> 'state' would be better, or the pre-state equivalent. >> >> I've committed a patch to git branch "chip/fast1".
> > The above is still in 0.18. WTF?
Look more closely. That's TF. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
  Sun Jan 15 02:56:05 2012 The RT System itself - Status changed from 'new' to 'open'
  Tue Jan 17 13:54:24 2012 chip [...] pobox.com - Correspondence added
From: chip [...] pobox.com
On Sun Jan 15 02:56:04 2012, autarch@urth.org wrote: Show quoted text
> On Sat, 14 Jan 2012, Chip Salzenberg via RT wrote: >
> > Queue: MooseX-StrictConstructor > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=73664 > > > > > On Mon Jan 02 02:03:34 2012, CHIPS wrote:
> >> This code: > >> > >> $source .= <<"EOF"; > >> my \%attrs = (@attrs); > >> ... > >> > >> ends up creating %attrs on every construction. This is wasteful.
> > Using
> >> 'state' would be better, or the pre-state equivalent. > >> > >> I've committed a patch to git branch "chip/fast1".
> > > > The above is still in 0.18. WTF?
> > Look more closely. That's TF.
No love for old moose, eh? OK
  Tue Jan 17 23:54:39 2012 autarch [...] urth.org - Correspondence added
Subject: Re: [rt.cpan.org #73664] Avoid reconstructing a hash on every construction
Date: Tue, 17 Jan 2012 22:54:25 -0600 (CST)
To: Chip Salzenberg via RT <bug-MooseX-StrictConstructor [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Tue, 17 Jan 2012, Chip Salzenberg via RT wrote: Show quoted text
>> Look more closely. That's TF.
> > No love for old moose, eh? OK
It's kind of a pain to support both. Note that I accidentally broke old Moose support with 0.18. Fixed in 0.19. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
  Mon Jan 23 14:39:01 2012 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'