Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Simple CPAN distribution.

Report information
The Basics
Id: 73595
Status: resolved
Priority: 0/
Queue: Test-Simple
People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.005000_002
Fixed in: (no value)

History Show all quoted text
  Thu Dec 29 12:51:50 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket created
Subject: Implicit dependency on threads::shared 1.21
I get test failures with MSCHWERN/Test-Simple-1.005000_002.tar.gz on 5.8.8 and 5.10.0. (I was just trying to see whether #73542 affects 5.8.8, when I found this problem.) The tests are using shared_clone from threads::shared, but that was not added until version 1.21. Excerpts from corelist -A threads::shared: ... 5.008008 0.94 5.008009 1.27 ... 5.010000 1.14 5.010001 1.29 ... I would suggest skipping the tests if the version of threads::shared is too low.
  Thu Dec 29 23:27:21 2011 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #73595] Implicit dependency on threads::shared 1.21
Date: Thu, 29 Dec 2011 20:27:13 -0800
To: bug-Test-Simple [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
On 2011.12.29 9:51 AM, Father Chrysostomos via RT wrote: Show quoted text
> I get test failures with MSCHWERN/Test-Simple-1.005000_002.tar.gz on 5.8.8 and 5.10.0. (I > was just trying to see whether #73542 affects 5.8.8, when I found this problem.) The tests > are using shared_clone from threads::shared, but that was not added until version 1.21.
TB2 checks that threads::shared->can("shared_clone") and if it can't it makes its own. See TB2::threads::shared::on. Either that's broken or your analysis is incorrect. What leads you to believe TB2 is using threads::shared::shared_clone when it doesn't exist? What's the error? -- 151. The proper way to report to my Commander is "Specialist Schwarz, reporting as ordered, Sir" not "You can't prove a thing!" -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
  Thu Dec 29 23:27:22 2011 The RT System itself - Status changed from 'new' to 'open'
  Fri Dec 30 11:29:20 2011 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Thu Dec 29 23:27:21 2011, schwern@pobox.com wrote: Show quoted text
> On 2011.12.29 9:51 AM, Father Chrysostomos via RT wrote:
> > I get test failures with MSCHWERN/Test-Simple-1.005000_002.tar.gz on
> 5.8.8 and 5.10.0. (I
> > was just trying to see whether #73542 affects 5.8.8, when I found
> this problem.) The tests
> > are using shared_clone from threads::shared, but that was not added
> until version 1.21. > > TB2 checks that threads::shared->can("shared_clone") and if it can't > it makes > its own. See TB2::threads::shared::on. Either that's broken or your > analysis > is incorrect. > > What leads you to believe TB2 is using threads::shared::shared_clone > when it > doesn't exist? What's the error?
$ perl5.8.8 Makefile.PL Looks good Writing Makefile for Test::Simple $ make ... $ perl5.8.8 -Mblib t/Streamer/threads.t # clone a streamer Undefined subroutine &main::shared_clone called at t/Streamer/threads.t line 21. $ perl5.8.8 -Mblib t/Streamer/ThreadSafeFilehandleAccessor.t # construction and accessors ok 1 ok 2 ok 3 - works with scalar ref filehandles # with threads Undefined subroutine &main::shared_clone called at t/Streamer/ThreadSafeFilehandleAccessor.t line 52.
  Fri Dec 30 14:36:55 2011 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #73595] Implicit dependency on threads::shared 1.21
Date: Fri, 30 Dec 2011 11:36:47 -0800
To: bug-Test-Simple [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
On 2011.12.30 8:29 AM, Father Chrysostomos via RT wrote: Show quoted text
> $ perl5.8.8 -Mblib t/Streamer/threads.t > # clone a streamer > Undefined subroutine &main::shared_clone called at t/Streamer/threads.t line 21. > $ perl5.8.8 -Mblib t/Streamer/ThreadSafeFilehandleAccessor.t > # construction and accessors > ok 1 > ok 2 > ok 3 - works with scalar ref filehandles > # with threads > Undefined subroutine &main::shared_clone called at > t/Streamer/ThreadSafeFilehandleAccessor.t line 52.
Ahh, it's in the tests! I'll have to provide a utility so the tests can get at the internal shared_clone. Thanks. -- I have a date with some giant cartoon robots and booze.
  Fri Dec 30 14:37:21 2011 mschwern [...] cpan.org - Subject changed from 'Implicit dependency on threads::shared 1.21' to 'Tests have implicit dep on shared_clone()'
  Fri Dec 30 14:37:21 2011 mschwern [...] cpan.org - Severity Important added
  Fri Dec 30 14:37:21 2011 mschwern [...] cpan.org - Broken in 1.005000_002 added
  Fri Oct 28 14:45:54 2016 exodist7 [...] gmail.com - Correspondence added
On Thu Dec 29 09:51:50 2011, SPROUT wrote: Show quoted text
> I get test failures with MSCHWERN/Test-Simple-1.005000_002.tar.gz on > 5.8.8 and 5.10.0. (I > was just trying to see whether #73542 affects 5.8.8, when I found this > problem.) The tests > are using shared_clone from threads::shared, but that was not added > until version 1.21. > > Excerpts from corelist -A threads::shared: > > ... > 5.008008 0.94 > 5.008009 1.27 > ... > 5.010000 1.14 > 5.010001 1.29 > ... > > I would suggest skipping the tests if the version of threads::shared > is too low.
no longer applicable.
  Fri Oct 28 14:46:00 2016 exodist7 [...] gmail.com - Status changed from 'open' to 'resolved'