Bug #73447 for Term-Cap: Cap.pm malformed POD

Thu Dec 22 17:29:40 2011 dom [...] cpan.org - Ticket created

Subject:

Cap.pm malformed POD

The POD in this file produces errors from pod2man: POD ERRORS Hey! The above document had some coding errors, which are explained below: Around line 89: You can't have =items (as at line 148) unless the first thing after the =over is an =item The attached patch fixes this.

Subject:

pod-parser-pod-fix.diff

diff --git a/lib/Pod/InputObjects.pm b/lib/Pod/InputObjects.pm index 13a8618..527e442 100644 --- a/lib/Pod/InputObjects.pm +++ b/lib/Pod/InputObjects.pm @@ -39,10 +39,10 @@ This module defines some basic input objects used by B<Pod::Parser> when reading and parsing POD text from an input source. The following objects are defined: -=over 4 - =begin __PRIVATE__ +=over 4 + =item package B<Pod::InputSource> An object corresponding to a source of POD input text. It is mostly a @@ -50,8 +50,12 @@ wrapper around a filehandle or C<IO::Handle>-type object (or anything that implements the C<getline()> method) which keeps track of some additional information relevant to the parsing of PODs. +=back + =end __PRIVATE__ +=over 4 + =item package B<Pod::Paragraph> An object corresponding to a paragraph of POD input text. It may be a

Thu Dec 22 17:30:16 2011 dom [...] cpan.org - Correspondence added

On Thu Dec 22 17:29:40 2011, DOM wrote: Show quoted text

> The POD in this file produces errors from pod2man: > > > POD ERRORS > Hey! The above document had some coding errors, which are > explained > below: > > Around line 89: > You can't have =items (as at line 148) unless the first

thing Show quoted text

> after > the =over is an =item > > The attached patch fixes this.

Correct patch this time....

Subject:

term-cap-pod-fix.diff

diff --git a/Cap.pm b/Cap.pm index 004a03c..82f4071 100644 --- a/Cap.pm +++ b/Cap.pm @@ -86,8 +86,6 @@ termcap manpage on most Unix-like systems. =head2 METHODS -=over 4 - The output strings for B<Tputs> are cached for counts of 1 for performance. B<Tgoto> and B<Tpad> do not cache. C<$self-E<gt>{_xx}> is the raw termcap data and C<$self-E<gt>{xx}> is the cached version. @@ -145,6 +143,8 @@ sub termcap_path return grep { defined $_ && -f $_ } @termcap_path; } +=over 4 + =item B<Tgetent> Returns a blessed object reference which the user can

Thu Dec 22 17:30:18 2011 dom [...] cpan.org - Status changed from 'new' to 'open'

Wed Jul 31 13:19:50 2013 shay [...] cpan.org - Correspondence added

Please could you incorporate the attached patch into a new CPAN release of Term-Cap to bring it into sync with bleadperl. This contains the POD fix which is the original subject of this ticket, plus a 'version bump' for it, from the following two commits: http://perl5.git.perl.org/perl.git/commit/c0e71a27c71a8acdad1dc8cbbd6847eba1a34890 http://perl5.git.perl.org/perl.git/commit/b9411ff2d79526114566a6486a0c0238691cec2d together with the following other commit which removed some boilerplate code from the test script: http://perl5.git.perl.org/perl.git/commit/2c48d544547cde085a32e29c951f5afcd7ed5501 (The version bump would also resolve CPAN RT #82287.) It's not urgent, but if you were able to release a new version to CPAN by 20th August when the next Perl release is due I would be very grateful.

Subject:

sync-with-blead.patch

diff -ruN Term-Cap-1.12.orig/Cap.pm Term-Cap-1.12/Cap.pm --- Term-Cap-1.12.orig/Cap.pm 2007-12-07 23:10:59.000000000 +0000 +++ Term-Cap-1.12/Cap.pm 2013-03-13 08:36:22.516864000 +0000 @@ -19,7 +19,7 @@ use vars qw($VERSION $VMS_TERMCAP); use vars qw($termpat $state $first $entry); -$VERSION = '1.12'; +$VERSION = '1.13'; # Version undef: Thu Dec 14 20:02:42 CST 1995 by sanders@bsdi.com # Version 1.00: Thu Nov 30 23:34:29 EST 2000 by schwern@pobox.com @@ -57,6 +57,8 @@ # EBDIC fixes from Chun Bing Ge <gecb@cn.ibm.com> # Version 1.12: Sat Dec 8 00:10:21 GMT 2007 # QNX test fix from Matt Kraai <kraai@ftbfs.org> +# Version 1.13: Thu Dec 22 22:21:09 GMT 2011 +# POD error fix from Domin Hargreaves <dom@earth.li> # # TODO: # support Berkeley DB termcaps @@ -86,8 +88,6 @@ =head2 METHODS -=over 4 - The output strings for B<Tputs> are cached for counts of 1 for performance. B<Tgoto> and B<Tpad> do not cache. C<$self-E<gt>{_xx}> is the raw termcap data and C<$self-E<gt>{xx}> is the cached version. @@ -145,6 +145,8 @@ return grep { defined $_ && -f $_ } @termcap_path; } +=over 4 + =item B<Tgetent> Returns a blessed object reference which the user can diff -ruN Term-Cap-1.12.orig/test.pl Term-Cap-1.12/test.pl --- Term-Cap-1.12.orig/test.pl 2007-11-29 19:52:55.000000000 +0000 +++ Term-Cap-1.12/test.pl 2013-03-13 08:36:22.519364000 +0000 @@ -5,10 +5,6 @@ BEGIN { $file = $0; chdir 't' if -d 't'; - - if ( $ENV{PERL_CORE} ) { - @INC = '../lib'; - } } END {

Sat Oct 26 13:45:02 2013 jns [...] gellyfish.co.uk - Correspondence added

On Wed Jul 31 13:19:50 2013, SHAY wrote: Show quoted text

> Please could you incorporate the attached patch into a new CPAN > release of Term-Cap to bring it into sync with bleadperl. > > This contains the POD fix which is the original subject of this > ticket, plus a 'version bump' for it, from the following two commits: > http://perl5.git.perl.org/perl.git/commit/c0e71a27c71a8acdad1dc8cbbd6847eba1a34890 > http://perl5.git.perl.org/perl.git/commit/b9411ff2d79526114566a6486a0c0238691cec2d > > together with the following other commit which removed some > boilerplate code from the test script: > http://perl5.git.perl.org/perl.git/commit/2c48d544547cde085a32e29c951f5afcd7ed5501 > > (The version bump would also resolve CPAN RT #82287.) > > It's not urgent, but if you were able to release a new version to CPAN > by 20th August when the next Perl release is due I would be very > grateful.

Thanks, belatedly applied with https://github.com/jonathanstowe/Term-Cap/commit/6025cb66d8c5485a7487eeb115203f1f153b6b1f I'm going to make a new release with the higher number and immmediately after a new one with some changes to the support details (to give the github details.)

Sat Oct 26 13:45:03 2013 jns [...] gellyfish.co.uk - Status changed from 'open' to 'resolved'