Bug #73390 for Net-Async-HTTP: Buggy EOF handling behaviour around connection caching/reuse

Tue Dec 20 15:25:15 2011 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

Buggy EOF handling behaviour around connection caching/reuse

If the (cached) connection happens to be at EOF condition but the response reader hasn't read this far yet, the next use of that connection fails with Connection closed while awaiting header Unclear quite how to handle this case, and also the related problems of SIGPIPE from writing to it. Needs more unit tests and fixing. -- Paul Evans

Tue Dec 20 15:26:20 2011 kiyoshi.aman [...] gmail.com - Cc AERDAN added

Tue Jan 17 11:43:03 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Attached patch should fix it. -- Paul Evans

Subject:

rt73390.patch

=== modified file 'lib/Net/Async/HTTP/Protocol.pm' --- lib/Net/Async/HTTP/Protocol.pm 2011-12-25 00:30:20 +0000 +++ lib/Net/Async/HTTP/Protocol.pm 2012-01-17 16:41:18 +0000 @@ -146,7 +146,8 @@ } my $transfer_encoding = $header->header( "Transfer-Encoding" ); - my $content_length = $header->content_length; + my $connection = lc( $header->header( "Connection" ) || "close" ); + my $content_length = $header->content_length; if( defined $transfer_encoding and $transfer_encoding eq "chunked" ) { my $chunk_length; @@ -226,6 +227,7 @@ if( $content_length == 0 ) { $self->debug_printf( "BODY done" ); + $self->close if $connection eq "close"; $on_body_chunk->(); return undef; }

Tue Jan 17 11:43:03 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Wed Feb 08 09:46:00 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added

This and more fixes were applied in 0.15, now on CPAN. -- Paul Evans

Wed Feb 08 09:46:02 2012 The RT System itself - Status changed from 'patched' to 'open'

Wed Feb 08 09:46:02 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'resolved'

Wed Feb 08 09:46:13 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.15 added