Bug #73281 for Test-Pod-LinkCheck: Doesn't handle unknown link types gracefully

Thu Dec 15 11:29:39 2011 DOHERTY [...] cpan.org - Ticket created

Subject:

Doesn't handle unknown link types gracefully

Apparently it doesn't understand man links (which is odd, they are probably very common) - such things should definitely not be counted as a test failure: # Failed test 'LinkCheck test for blib/lib/perlfaq9.pod' # at /home/mike/perl5/perlbrew/perls/perl- 5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213. # Erroneous links: # * blib/lib/perlfaq9.pod:500:41 - Unknown link type(man) to(mail(1)) # * blib/lib/perlfaq9.pod:500:52 - Unknown link type(man) to(mailx(1))

Sat Nov 01 13:19:47 2014 APOCAL [...] cpan.org - Correspondence added

Hello, Thanks for noticing this! The module is capable of processing man links, just that it wasn't able to find one on your system :) Maybe I could reword that to make it more clearer? On Thu Dec 15 11:29:39 2011, DOHERTY wrote: Show quoted text

> Apparently it doesn't understand man links (which is odd, they are > probably very common) - such things should definitely not be counted as a > test failure: > > # Failed test 'LinkCheck test for blib/lib/perlfaq9.pod' > # at /home/mike/perl5/perlbrew/perls/perl- > 5.14.2/lib/site_perl/5.14.2/Test/Pod/LinkCheck.pm line 213. > # Erroneous links: > # * blib/lib/perlfaq9.pod:500:41 - Unknown link type(man) to(mail(1)) > # * blib/lib/perlfaq9.pod:500:52 - Unknown link type(man) to(mailx(1))

-- ~Apocalypse

Sat Nov 01 13:19:47 2014 The RT System itself - Status changed from 'new' to 'open'

Sun Nov 02 01:35:47 2014 DOHERTY [...] cpan.org - Correspondence added

On Sat Nov 01 13:19:47 2014, APOCAL wrote: Show quoted text

> Thanks for noticing this! The module is capable of processing man > links, just that it wasn't able to find one on your system :)

Might it be trying to find a "mail(1)" man page instead of "mail" in section 1?

Sun Nov 02 11:14:38 2014 perl [...] 0ne.us - Correspondence added

Subject:	Re: [rt.cpan.org #73281] Doesn't handle unknown link types gracefully
Date:	Sun, 02 Nov 2014 08:14:28 -0800
To:	bug-Test-Pod-LinkCheck [...] rt.cpan.org
From:	Apocalypse <perl [...] 0ne.us>

On 11/01/2014 10:35 PM, Mike Doherty via RT wrote: Show quoted text

> Queue: Test-Pod-LinkCheck > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=73281 > > > On Sat Nov 01 13:19:47 2014, APOCAL wrote:

>> Thanks for noticing this! The module is capable of processing man >> links, just that it wasn't able to find one on your system :)

> Might it be trying to find a "mail(1)" man page instead of "mail" in section 1?

Hmm, the code already recognizes section markers and should do the right thing. As seen in sub _known_manpage: if ( $page =~ /(.+)\s*$(.+)$$/ ) { @manargs = ($2, $1); } else { @manargs = ($page); } ... system( 'man', @manargs ); Can you try to debug this on your side by checking the link itself and verifying that it exists on your system? Maybe there was UTF8 or something zany in $page? Or maybe some other assumption I made in the code didn't hold for your system? Thanks for helping :)

Thu Jan 08 23:52:27 2015 DOHERTY [...] cpan.org - Correspondence added

On Sun Nov 02 11:14:38 2014, perl@0ne.us wrote: Show quoted text

> Can you try to debug this on your side by checking the link itself and > verifying that it exists on your system? Maybe there was UTF8 or > something zany in $page? Or maybe some other assumption I made in the > code didn't hold for your system? Thanks for helping :)

This report is so old that I doubt we'll make much headway. Running the same test against the same repository (which took some remembering. For future me: it's the perlfaq repo) yields different errors, one of which is in fact a man page my system doesn't have.