Skip Menu |

This queue is for tickets about the Test-Pod-LinkCheck CPAN distribution.

Report information
The Basics
Id: 73280
Status: resolved
Priority: 0/
Queue: Test-Pod-LinkCheck
People
Owner: Nobody in particular
Requestors: DOHERTY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Dec 15 11:04:31 2011 DOHERTY [...] cpan.org - Ticket created
Subject: Handle failure to open files gracefully at line 626
The call to $parser->parse_file($filename) can cause the whole thing to die if the file cannot be opened. This should be handled gracefully by warning that a file couldn't be opened, and then continuing with any remaining files.
  Thu Dec 15 11:20:08 2011 DOHERTY [...] cpan.org - Correspondence added
On Thu Dec 15 11:04:31 2011, DOHERTY wrote: Show quoted text
> The call to $parser->parse_file($filename) can cause the whole thing to > die if the file cannot be opened. This should be handled gracefully by > warning that a file couldn't be opened, and then continuing with any > remaining files.
This was found because it was trying to open a file called "0" - I think you're confusing a return indicating an error with one indicating a filename at line 607 - you should check for truth, not definedness.
  Thu Dec 15 11:20:09 2011 DOHERTY [...] cpan.org - Status changed from 'new' to 'open'
  Tue Aug 14 20:57:32 2012 ether [...] cpan.org - Correspondence added
O Show quoted text
> This was found because it was trying to open a file called "0" - I think > you're confusing a return indicating an error with one indicating a > filename at line 607 - you should check for truth, not definedness.
I'm encountering this on a simple check failure (which is actually due to the module not being installed, due to the wrong backend being used, as described in another ticket): t/release-pod-linkcheck.t ........ Can't open 0: No such file or directory at /Users/ether/perl5/perlbrew/perls/perl-5.16.0/lib/site_perl/5.16.0/Test/Pod/LinkCheck.pm line 626. # Looks like your test exited with 2 before it could output anything.
  Thu Apr 25 19:13:09 2013 ether [...] cpan.org - Severity Critical added
  Sat Nov 01 20:44:15 2014 APOCAL [...] cpan.org - Correspondence added
Hello, Thanks for reporting this! Yes, the module didn't trap exceptions in the right places ( the bugs regarding the open fd:0 actually was deeper in the App::PodLinkCheck and Pod::Parser guts! ) so I've released v0.008 to CPAN that hopefully solves this. Please let me know if this works for you or not :) -- ~Apocalypse
  Sat Nov 01 20:44:16 2014 APOCAL [...] cpan.org - Status changed from 'open' to 'resolved'