Skip Menu |

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 73279
Status: resolved
Priority: 0/
Queue: libnet

People
Owner: Nobody in particular
Requestors: tompa.lorand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.24



Subject: Fwd: Fixed bug in NET::Ftp
Date: Thu, 15 Dec 2011 16:41:11 +0200
To: bug-libnet [...] rt.cpan.org
From: Tompa Lorand <tompa.lorand [...] gmail.com>
Hello Graham, Long ago I has send a bugfix to the NET::Ftp module, but at that to the wrong address. I forget about the issue, but I hope it can still help the NET::Ftp module. Please see the full topic at: http://www.nntp.perl.org/group/perl.perl5.porters/2010/06/msg161210.html Thanks, Lorand. Show quoted text
---------- Forwarded message ---------- From: Tompa Lorand <tompa.lorand@gmail.com> Date: Thu, May 13, 2010 at 7:43 PM Subject: Fixed bug in NET::Ftp To: perlbug@perl.org Hello, I am a software engineer at Romania, and I have found / fixed two related bugs in the NET::Ftp module. I was not sure where to send the patch, so please commit them if you can, or tell me where to report it if you cannot. # 1. If the FTP data connection could not be opened, the NET::Ftp quits with an error # Can't use an undefined value as a symbol reference at .../Net/FTP/dataconn.pm line 54 # Search google "Net/FTP/dataconn.pm line 54" for more reports about this # # 2. when opening the data connection, NET::Ftp ignores the timeout value # I have corrected the problems, and I have also created a test script for it. Now I am attaching a corrected version of the NET module, an unified patch and also a test script. Regards, Lori.
Download NETFtpFix.zip
application/zip 263.7k

Message body not shown because it is not plain text.

The first item (undefined $ftp object) is fixed by equivalent code in the current version of libnet (1.24). The second item (the data connection timeout) is a duplicate of #78926 and is also fixed in the current version of libnet in a better way than your proposed fix, which ignored the case where ${*$ftp}{'net_ftp_listen'} rather than ${*$ftp}{'net_ftp_pasv'} is defined.