Skip Menu |

This queue is for tickets about the Geo-Coder-Google CPAN distribution.

Report information
The Basics
Id: 73237
Status: resolved
Priority: 0/
Queue: Geo-Coder-Google

People
Owner: Nobody in particular
Requestors: MAROS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.08
  • 0.09
  • 0.09_01
Fixed in: 0.09_02



Subject: v3 api broken if JSON::XS is loaded
Please check these two examples where the first one works and the second one fails just because another module is loaded: perl -MGeo::Coder::Google -MData::Dumper -E 'say Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' perl -MJSON::XS -MGeo::Coder::Google -MData::Dumper -E 'say Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' Seems like the sensor query param in the second example is submitted as sensor=0 instead of sensor=false
patched: https://github.com/arcanez/geo-coder- google/commit/978ded1419d26e4bb4b03951388c69d676addcb1 shipped 0.09_02 On Tue Dec 13 12:19:21 2011, MAROS wrote: Show quoted text
> Please check these two examples where the first one works and the
second Show quoted text
> one fails just because another module is loaded: > > perl -MGeo::Coder::Google -MData::Dumper -E 'say > Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => > "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' > > perl -MJSON::XS -MGeo::Coder::Google -MData::Dumper -E 'say > Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => > "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' > > Seems like the sensor query param in the second example is submitted
as Show quoted text
> sensor=0 instead of sensor=false
shipped 0.10 On Tue Dec 13 12:38:37 2011, arcanez wrote: Show quoted text
> patched: https://github.com/arcanez/geo-coder- > google/commit/978ded1419d26e4bb4b03951388c69d676addcb1 > > shipped 0.09_02 > > On Tue Dec 13 12:19:21 2011, MAROS wrote:
> > Please check these two examples where the first one works and the
> second
> > one fails just because another module is loaded: > > > > perl -MGeo::Coder::Google -MData::Dumper -E 'say > > Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => > > "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' > > > > perl -MJSON::XS -MGeo::Coder::Google -MData::Dumper -E 'say > > Dumper(Geo::Coder::Google->new( apiver => 3 )->geocode( location => > > "1600 Amphitheatre Parkway, 94043 Mountain View,CA"))' > > > > Seems like the sensor query param in the second example is submitted
> as
> > sensor=0 instead of sensor=false