Bug #73194 for Perl-Critic-Pulp: Stray optional requires Devel::Comments in META.yml

Mon Dec 12 08:07:47 2011 ppisar [...] redhat.com - Ticket created

Subject:

Stray optional requires Devel::Comments in META.yml

META.yml says: optional_features: maximum_devel: description: Stuff used variously for development. requires: Devel::Comments: 0 But the only occurrence of Devel::Comments is in comment: lib/Perl/Critic/Policy/Documentation/ProhibitLinkToSelf.pm:30:#use Devel::Comments; I think the Devel::Comments should disappear from META.yml.

Wed Dec 14 18:04:20 2011 user42 [...] zip.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #73194] Stray optional requires Devel::Comments in META.yml
Date:	Thu, 15 Dec 2011 10:04:04 +1100
To:	ppisar [...] redhat.com, bug-Perl-Critic-Pulp [...] rt.cpan.org
From:	Kevin Ryde <user42 [...] zip.com.au>

"Petr Pisar via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes: Show quoted text

> > lib/Perl/Critic/Policy/Documentation/ProhibitLinkToSelf.pm:30:#use > Devel::Comments;

Yep. I've gone between Smart::Comments and Devel::Comments and back. Show quoted text

> I think the Devel::Comments should disappear from META.yml.

The "maximum_devel" is supposed to be author things I use in development. I've been tempted to drop it altogether in my various dists since it's often incomplete or irrelevant anyway. Does it show up somewhere particularly bad or good? I wondered if cpanplus stuff offered those optional bits, but I haven't tried to run it up.

Wed Dec 14 18:04:21 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Dec 15 05:39:42 2011 ppisar [...] redhat.com - Correspondence added

CC:	bug-Perl-Critic-Pulp [...] rt.cpan.org
Subject:	Re: [rt.cpan.org #73194] Stray optional requires Devel::Comments in META.yml
Date:	Thu, 15 Dec 2011 11:39:22 +0100
To:	Kevin Ryde <user42 [...] zip.com.au>, bug-Perl-Critic-Pulp [...] rt.cpan.org
From:	Petr Pisar <ppisar [...] redhat.com>

On Thu, Dec 15, 2011 at 10:04:04AM +1100, Kevin Ryde wrote: Show quoted text

> "Petr Pisar via RT" <bug-Perl-Critic-Pulp@rt.cpan.org> writes:

> > > > lib/Perl/Critic/Policy/Documentation/ProhibitLinkToSelf.pm:30:#use > > Devel::Comments;

> > Yep. I've gone between Smart::Comments and Devel::Comments and back. >

> > I think the Devel::Comments should disappear from META.yml.

> > The "maximum_devel" is supposed to be author things I use in > development. I've been tempted to drop it altogether in my various > dists since it's often incomplete or irrelevant anyway. > > Does it show up somewhere particularly bad or good? I wondered if > cpanplus stuff offered those optional bits, but I haven't tried to run > it up.

I have no idea about cpanplus. I just found this dependency when upgrading Perl-Critic-Pulp in Fedora distribution. And because it is used nowhere in the stock code I concluded this was not necessary to be listed in the META.yml. If somebody want to enable Devel::Comments, he needs to patch the code and then he should be aware he adds new dependency. -- Petr

Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

Fri Dec 16 19:25:10 2011 user42 [...] zip.com.au - Correspondence added

CC:	bug-Perl-Critic-Pulp [...] rt.cpan.org
Subject:	Re: [rt.cpan.org #73194] Stray optional requires Devel::Comments in META.yml
Date:	Sat, 17 Dec 2011 11:24:50 +1100
To:	Petr Pisar <ppisar [...] redhat.com>
From:	Kevin Ryde <user42 [...] zip.com.au>

Petr Pisar <ppisar@redhat.com> writes: Show quoted text

> > I just found this dependency when upgrading > Perl-Critic-Pulp in Fedora distribution.

It doesn't create a dependency in the package does it? Show quoted text

> If somebody want to enable Devel::Comments, he needs to patch the > code and then he should be aware he adds new dependency.

Yes, good point. (I had wondered at one stage if filters like Smart::Comments could be turned on selectively from outside. Presumably not impossible, but perhaps not easy.)

Mon Dec 19 04:13:53 2011 ppisar [...] redhat.com - Correspondence added

CC:	bug-Perl-Critic-Pulp [...] rt.cpan.org
Subject:	Re: [rt.cpan.org #73194] Stray optional requires Devel::Comments in META.yml
Date:	Mon, 19 Dec 2011 10:13:36 +0100
To:	Kevin Ryde <user42 [...] zip.com.au>
From:	Petr Pisar <ppisar [...] redhat.com>

On Sat, Dec 17, 2011 at 11:24:50AM +1100, Kevin Ryde wrote: Show quoted text

> Petr Pisar <ppisar@redhat.com> writes:

> > > > I just found this dependency when upgrading > > Perl-Critic-Pulp in Fedora distribution.

> > It doesn't create a dependency in the package does it? >

It doesn't because we generate dependencies from code and not from META.yml. However we watch META.yml for changes because developers tends to omit version contrains in code and put them to META.yml only. -- Petr

Download (untitled)
application/pgp-signature 230b

Message body not shown because it is not plain text.

Thu Dec 22 18:37:06 2011 user42 [...] zip.com.au - Correspondence added

CC:	bug-Perl-Critic-Pulp [...] rt.cpan.org
Subject:	Re: [rt.cpan.org #73194] Stray optional requires Devel::Comments in META.yml
Date:	Fri, 23 Dec 2011 10:37:08 +1100
To:	Petr Pisar <ppisar [...] redhat.com>
From:	Kevin Ryde <user42 [...] zip.com.au>

Petr Pisar <ppisar@redhat.com> writes: Show quoted text

> > It doesn't because we generate dependencies from code and not from META.yml. > However we watch META.yml for changes because developers tends to omit version > contrains in code and put them to META.yml only.

I've done it the other way around too, a constraint in the code not expressed in the makefile/meta :). In any case I chopped the devel bits from new P-C-Pulp 67 as you suggested since it's pretty pointless if I don't even use those bits myself. The same in my other dists on next uploads, or if anyone is particularly annoyed sooner. -- The sigfile lesser-known SI units series: milliHelen - the amount of beauty required to launch a ship. (A full Helen is the amount to launch 1000 ships, but so few women have that much that it's too large for most uses.)

Thu Dec 22 18:42:01 2011 KRYDE [...] cpan.org - Status changed from 'open' to 'resolved'