Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Path-Class-Rule CPAN distribution.

Report information
The Basics
Id: 72841
Status: resolved
Priority: 0/
Queue: Path-Class-Rule

People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.007
Fixed in: (no value)



Subject: [PATCH] kill 35 of 53 dependencies
P::C::R is an OO module with no exports, so it really does not need n::autoclean; this lets us avoid pulling in the whole Moose antlers
Subject: 0001-kill-35-of-53-dependencies.patch
From 8618f4c06ec6794126173ec84888d875e5dfa1f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20D=C9=AA=E1=B4=87=E1=B4=84=E1=B4=8B=E1=B4=8F=E1=B4=A1=20?= =?UTF-8?q?=E8=BF=AA=E6=8B=89=E6=96=AF?= <daxim@cpan.org> Date: Wed, 30 Nov 2011 09:02:57 +0100 Subject: [PATCH] kill 35 of 53 dependencies P::C::R is an OO module with no exports, so it really does not need n::autoclean; this lets us avoid pulling in the whole Moose antlers --- lib/Path/Class/Rule.pm | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/Path/Class/Rule.pm b/lib/Path/Class/Rule.pm index 16e4275..5b6380d 100644 --- a/lib/Path/Class/Rule.pm +++ b/lib/Path/Class/Rule.pm @@ -10,12 +10,11 @@ our $VERSION = '0.007'; # VERSION use warnings::register; # Dependencies -use namespace::autoclean; use re 'regexp_pattern'; use Carp; use List::Util qw/first/; use Number::Compare 0.02; -use Path::Class; +use Path::Class::Dir qw(); use Scalar::Util qw/blessed/; use Text::Glob qw/glob_to_regex/; use Try::Tiny; @@ -75,7 +74,7 @@ sub iter { my $args = ref($_[0]) && !blessed($_[0]) ? shift : ref($_[-1]) && !blessed($_[-1]) ? pop : {}; my $opts = { %defaults, %$args }; - my @queue = map { { path => dir($_), depth => 0 } } @_ ? @_ : '.'; + my @queue = map { { path => Path::Class::Dir->new($_), depth => 0 } } @_ ? @_ : '.'; my $stash = {}; my %seen; -- 1.7.7
Thanks. I didn't realize autoclean needed the whole Class::MOP. I wish there were a dependency free cleaner, but even namespace::clean has a stack of stuff it needs. Oh, well. I'll cut a new release shortly.
On Wed Nov 30 09:31:03 2011, DAGOLDEN wrote: Show quoted text
> Thanks. I didn't realize autoclean needed the whole Class::MOP. > > I wish there were a dependency free cleaner, but even namespace::clean > has a stack of stuff it needs. Oh, well. >
Sorry for reopening this ticket, but the only dep of n::c is Package::Stash. Even *that* can be excised away if you think it is worthwhile. So comments?
On Wed Nov 30 09:50:10 2011, RIBASUSHI wrote: Show quoted text
> Sorry for reopening this ticket, but the only dep of n::c is > Package::Stash. Even *that* can be excised away if you think it is > worthwhile. So comments?
It's still heavier than I'd like if I'm trying to be minimalist about it, because Package::Stash pulls in stuff, too. http://deps.cpantesters.org/?module=namespace::clean I'll just do it the "old fashioned way" and let my OO module import a bunch of subroutines and hope no one ever tries to call them as methods or introspect it. :-) -- David