Bug #72817 for Moose: A few missing build

Tue Nov 29 12:01:28 2011 w.phillip.moore [...] gmail.com - Ticket created

Subject:

A few missing build_recommends dependencies

I noticed while building Moose-2.0401 that some of the tests whine about some optional modules that are missing, but proceed anyway. I try very hard to get maximum coverage by the test suite by installing as many of the optional "recommends" dependencies as possible, but these are missing from the META.yml file. All of the following are missing: Test::Output Test::LeakTrace SUPER Module::Refresh DateTime::Format::MySQL Declare::Constraints::Simple Test::Deep Data::Visitor IO::String If you could include these in the META.yml for the next release of Moose, I'd appreciate it.

Tue Nov 29 12:25:45 2011 w.phillip.moore [...] gmail.com - Correspondence added

Observation: Data::Visitor already depends on Moose, to defining this as a build_recommends in Moose would create a circular dependency. I'm not sure if that's wise, although there are plenty of such circular relationships in the CPAN metadata today.

Tue Nov 29 12:25:47 2011 w.phillip.moore [...] gmail.com - Status changed from 'new' to 'open'

Tue Nov 29 12:32:54 2011 autarch [...] urth.org - Correspondence added

Subject:	Re: [rt.cpan.org #72817] A few missing build_recommends dependencies
Date:	Tue, 29 Nov 2011 11:32:45 -0600 (CST)
To:	Phillip Moore via RT <bug-Moose [...] rt.cpan.org>
From:	Dave Rolsky <autarch [...] urth.org>

On Tue, 29 Nov 2011, Phillip Moore via RT wrote: Show quoted text

> I noticed while building Moose-2.0401 that some of the tests whine about some optional > modules that are missing, but proceed anyway. I try very hard to get maximum coverage by > the test suite by installing as many of the optional "recommends" dependencies as possible, > but these are missing from the META.yml file.

The tests should not continue to run anyway. We use Test::Requires, which should skip all the tests if the optional modules aren't available. Could you include some test output that shows otherwise? -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/

Tue Nov 29 12:39:42 2011 DROLSKY [...] cpan.org - Correspondence added

On Tue Nov 29 12:01:28 2011, WPMOORE wrote: Show quoted text

> I noticed while building Moose-2.0401 that some of the tests whine > about some optional > modules that are missing, but proceed anyway. I try very hard to get > maximum coverage by > the test suite by installing as many of the optional "recommends" > dependencies as possible, > but these are missing from the META.yml file. > > All of the following are missing: > > Test::Output > Test::LeakTrace > SUPER > Module::Refresh > DateTime::Format::MySQL > Declare::Constraints::Simple > Test::Deep > Data::Visitor > IO::String > > If you could include these in the META.yml for the next release of > Moose, I'd appreciate it. >

Oops, I misunderstood the ticket. Ignore my last response. These modules are listed as develop/requires in the META.json file, so the information is available. I'm not sure what tools you're using to deal with requirements, but you should probably upgrade them to handle META.json files (CPAN::Meta spec v2 - https://metacpan.org/module/CPAN::Meta::Spec).

Tue Nov 29 13:08:12 2011 w.phillip.moore [...] gmail.com - Correspondence added

On Tue Nov 29 12:39:42 2011, DROLSKY wrote: Show quoted text

> Oops, I misunderstood the ticket. Ignore my last response. > > These modules are listed as develop/requires in the META.json file, so > the information is available. I'm not sure what tools you're using to > deal with requirements, but you should probably upgrade them to handle > META.json files (CPAN::Meta spec v2 - > https://metacpan.org/module/CPAN::Meta::Spec).

Thanks -- my tools use META.yml exclusively, and I haven't payed much attention to META.json. Looks like I'm a bit out of the loop on the state of the toolchain and metadata evolution. If the metadata's in META.json, then this can be closed. Sounds like I simply need to prefer META.json over META.yml, if the former's found. Thanks again.

Tue Nov 29 13:38:24 2011 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #72817 for Moose: A few missing build_recommends dependencies