Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 72551
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.19
Fixed in: 3.20



Subject: [PATCH] new tests need to be case blind
t/search12.t recently added some new tests which fail when filename case is not preserved. This happens by default on VMS. It could happen on Windows or Mac OS X where the dominant file systems do typically preserve case but don't enforce it, i.e., are not case sensitive. The easiest safest thing to do is to just make the comparisons case blind, as in the attached patch.
Subject: search12_case.patch
--- t/search12.t;-0 2011-10-04 12:55:40 -0500 +++ t/search12.t 2011-11-11 23:16:13 -0600 @@ -88,12 +88,12 @@ print $p; { my $names = join "|", sort values %$where2name; -ok $names, "Suzzle"; +ok lc($names), lc("Suzzle"); } { my $names = join "|", sort keys %$name2where; -ok $names, "Suzzle"; +ok lc($names), lc("Suzzle"); } ok( ($name2where->{'Vliff'} || 'huh???'), 'huh???');
On 2011-11-19 12:19:29, CBERRY wrote: Show quoted text
> t/search12.t recently added some new tests which fail when filename > case is not preserved. > This happens by default on VMS. It could happen on Windows or Mac OS > X where the dominant > file systems do typically preserve case but don't enforce it, i.e., > are not case sensitive. > > The easiest safest thing to do is to just make the comparisons case > blind, as in the attached > patch.
There are no failures on Windows or OS X for this, because while HFS+ and the Windows file system are case-insensitive, they are also case-preserving. So it will always be “Suzzle” there. Is VMS not case-preserving? Thanks, David
Subject: Re: [rt.cpan.org #72551] [PATCH] new tests need to be case blind
Date: Mon, 02 Jan 2012 18:35:19 -0600
To: bug-Pod-Simple [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
On Jan 2, 2012, at 6:16 PM, David Wheeler via RT wrote: Show quoted text
> There are no failures on Windows or OS X for this, because while HFS+ and the Windows file > system are case-insensitive, they are also case-preserving. So it will always be “Suzzle” there.
Assuming the filenames aren't case-leveled by network transfer, archiving and unarchiving, spending time on a FAT volume on the way there, etc. The case can be cOmPleteLy mangled and the filesystem doesn't care, so a robustly-written program that processes those files shouldn't care either. So usually, yes, but not always. Show quoted text
> Is VMS not case-preserving?
Not by default, no. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Subject: Re: [rt.cpan.org #72551] [PATCH] new tests need to be case blind
Date: Mon, 2 Jan 2012 16:38:05 -0800
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <david [...] justatheory.com>
On Jan 2, 2012, at 4:35 PM, craigberry@mac.com via RT wrote: Show quoted text
>> Is VMS not case-preserving?
> > Not by default, no.
Okay. Is that the only failure you see for 3.19 on VMS? Thanks, David
Subject: Re: [rt.cpan.org #72551] [PATCH] new tests need to be case blind
Date: Mon, 02 Jan 2012 21:38:51 -0600
To: bug-Pod-Simple [...] rt.cpan.org
From: "Craig A. Berry" <craigberry [...] mac.com>
On Jan 2, 2012, at 6:38 PM, david@justatheory.com via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=72551 > > > On Jan 2, 2012, at 4:35 PM, craigberry@mac.com via RT wrote: >
>>> Is VMS not case-preserving?
>> >> Not by default, no.
> > Okay. Is that the only failure you see for 3.19 on VMS?
Yes. This showed up in routine testing of blead, which looks like it has 3.19 in it. Show quoted text
________________________________________ Craig A. Berry mailto:craigberry@mac.com "... getting out of a sonnet is much more difficult than getting in." Brad Leithauser
Thanks, patched here: https://github.com/theory/pod- simple/commit/4de9c36d3434c2c75bb49a22ba833beb8ff65956