Skip Menu |

This queue is for tickets about the Encode CPAN distribution.

Report information
The Basics
Id: 72519
Status: resolved
Priority: 0/
Queue: Encode

People
Owner: Nobody in particular
Requestors: michael.parker [...] st.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 2.44
Fixed in: (no value)



Subject: Unused variables reported by warnings::unused
A number of unused variables are reported in Encode.pm by warnings::unused : Unused variable my $class at PATH/Encode.pm line 64. Unused variable my $obj at PATH/Encode.pm line 250. Unused variable my $obj at PATH/Encode.pm line 262. Unused variable my $obj at PATH/Encode.pm line 281. Unused variable my $obj at PATH/Encode.pm line 306. Unused variable my $obj at PATH/Encode.pm line 315. Unused variable my $obj at PATH/Encode.pm line 323. The attached patch fixes these by either commenting out the offending line or replacing the unused variable with undef.
Subject: Encode.pm.patch
64c64 < my $class = shift; --- > #my $class = shift; 250c250 < my ( $obj, $str, $chk ) = @_; --- > my ( undef, $str, $chk ) = @_; 262c262 < my ( $obj, $str, $chk ) = @_; --- > my ( undef, $str, $chk ) = @_; 281c281 < my ( $obj, $str, $chk ) = @_; --- > my ( undef, $str, $chk ) = @_; 306c306 < my ( $obj, $octets, $chk ) = @_; --- > my ( undef, $octets, $chk ) = @_; 315c315 < my ( $obj, $string, $chk ) = @_; --- > my ( undef, $string, $chk ) = @_; 323c323 < my ( $obj, undef, undef, $pos, $trm ) = @_; --- > my ( undef, undef, undef, $pos, $trm ) = @_;
Thanks. Applied in my repo and will be available in 2.45. Dan the Maintainer Thereof On Fri Nov 18 05:04:00 2011, michael.parker@st.com wrote: Show quoted text
> A number of unused variables are reported in Encode.pm by warnings::unused : > > Unused variable my $class at PATH/Encode.pm line 64. > Unused variable my $obj at PATH/Encode.pm line 250. > Unused variable my $obj at PATH/Encode.pm line 262. > Unused variable my $obj at PATH/Encode.pm line 281. > Unused variable my $obj at PATH/Encode.pm line 306. > Unused variable my $obj at PATH/Encode.pm line 315. > Unused variable my $obj at PATH/Encode.pm line 323. > > The attached patch fixes these by either commenting out the offending > line or replacing the unused variable with undef.