Bug #72421 for cpan2rpm: Extraction fails for certain tarfiles.

Mon Nov 14 15:39:11 2011 dogcow+spamspamspam [...] babymeat.com - Ticket created

Subject:

Extraction fails for certain tarfiles.

Certain tarfiles, like that for Expect, will not build properly: -- module: ../modules/Expect-1.21.tar.gz -- Metadata retrieval Tarball extraction: [/home/dogcow/rpmbuild/SOURCES/Expect-1.21.tar.gz] Can't stat /tmp/uT6ppdd5yr/12:41:12: No such file or directory at ./cpan2rpm line 386 This is because the tarfile has an embedded space in the group name ("Domain Users"), and the offending line of code (1262) is $_ = (split)[5] unless $zip; and will thus fail unless your version of tar happens to rewrite embedded spaces as something else. I'd suggest changing the code to something like ($_) = (m/(\S+)$/) unless $zip; which will always match the last field - unless, of course, someone inexplicably embedded spaces there as well.

Mon Nov 14 16:13:43 2011 zenekkis [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #72421] Extraction fails for certain tarfiles.
Date:	Mon, 14 Nov 2011 13:13:29 -0800
To:	bug-cpan2rpm [...] rt.cpan.org
From:	Erick Calder <zenekkis [...] gmail.com>

this particular line has seen more "fixes" than I can think of. the trouble is inconsistency of the output I need to parse. I no longer remember what the issue was but picking up the last field was how it was originally written. the issue will probably need revision before I repatch but I really just don't have the time now. sorry about that. On Nov 14, 2011, at 12:39 PM, Tom Spindler via RT wrote: Show quoted text

> Mon Nov 14 15:39:11 2011: Request 72421 was acted upon. > Transaction: Ticket created by TSPIN > Queue: cpan2rpm > Subject: Extraction fails for certain tarfiles. > Broken in: 2.028 > Severity: (no value) > Owner: Nobody > Requestors: dogcow+spamspamspam@babymeat.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72421 > > > > Certain tarfiles, like that for Expect, will not build properly: > > -- module: ../modules/Expect-1.21.tar.gz -- > Metadata retrieval > Tarball extraction: [/home/dogcow/rpmbuild/SOURCES/Expect-1.21.tar.gz] > Can't stat /tmp/uT6ppdd5yr/12:41:12: No such file or directory > at ./cpan2rpm line 386 > > This is because the tarfile has an embedded space in the group name > ("Domain Users"), and the offending line of code (1262) is > $_ = (split)[5] unless $zip; > and will thus fail unless your version of tar happens to rewrite > embedded spaces as something else. I'd suggest changing the code to > something like > ($_) = (m/(\S+)$/) unless $zip; > which will always match the last field - unless, of course, someone > inexplicably embedded spaces there as well. >

Mon Nov 14 16:13:44 2011 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 14 16:19:40 2011 dogcow [...] babymeat.com - Correspondence added

Subject:	Re: [rt.cpan.org #72421] Extraction fails for certain tarfiles.
Date:	Mon, 14 Nov 2011 13:19:30 -0800
To:	Erick Calder via RT <bug-cpan2rpm [...] rt.cpan.org>, r [...] babymeat.com
From:	Tom Spindler <dogcow [...] babymeat.com>

I figured it was something like that. No worries. (I couldn't decide whether last field would be best, or whether to just require Archive::Tar, or just read from the work directory, or....)