Bug #72343 for DBI: Problem with Sponge driver call in DBI::DBD::SqlEngine

Thu Nov 10 15:55:04 2011 BBYRD [...] cpan.org - Ticket created

Subject:

Problem with Sponge driver call in DBI::DBD::SqlEngine

# Temporary kludge: DBD::Sponge dies if @tables is empty. :-( @tables or return; my $dbh2 = $dbh->func("sql_sponge_driver"); my $sth = $dbh2->prepare( "TABLE_INFO", { rows => \@tables, NAMES => $names, } ); $sth or $dbh->set_err( $DBI::stderr, $dbh2->errstr ); return $sth; There is no such attrib called "NAMES". It should be "NAME". This is causing the TABLE_INFO call to not use the proper names. Also, can DBD::Sponge be fixed to accept empty-tabled rows?

Wed Nov 30 04:03:17 2011 bohica [...] ntlworld.com - Correspondence added

On Thu Nov 10 15:55:04 2011, BBYRD wrote: Show quoted text

> # Temporary kludge: DBD::Sponge dies if @tables is empty. :-( > @tables or return; > > my $dbh2 = $dbh->func("sql_sponge_driver"); > my $sth = $dbh2->prepare( > "TABLE_INFO", > { > rows => \@tables, > NAMES => $names, > } > ); > $sth or $dbh->set_err( $DBI::stderr, $dbh2->errstr ); > return $sth; > > > There is no such attrib called "NAMES". It should be "NAME". This is > causing the TABLE_INFO call to not use the proper names.

I have fixed this and removed the comment/return for "kludge" as DBD::Sponge does support an empty table array. Show quoted text

> Also, can DBD::Sponge be fixed to accept empty-tabled rows?

Don't think this is possible or meaningful: select * from table where 1 = 0 produces an empty result-set. How are you supposed to tell the difference between reaching the end of the result set and there being no result-set. Martin -- Martin J. Evans Wetherby, UK

Wed Nov 30 04:03:19 2011 The RT System itself - Status changed from 'new' to 'open'

Wed Nov 30 04:03:31 2011 bohica [...] ntlworld.com - Status changed from 'open' to 'patched'

Wed Nov 30 04:25:06 2011 rehsack [...] googlemail.com - Correspondence added

Subject:	Re: [rt.cpan.org #72343] Problem with Sponge driver call in DBI::DBD::SqlEngine
Date:	Wed, 30 Nov 2011 10:24:56 +0100
To:	bug-DBI [...] rt.cpan.org
From:	Jens Rehsack <rehsack [...] googlemail.com>

2011/11/30 Martin J Evans via RT <bug-DBI@rt.cpan.org>: Show quoted text

> Queue: DBI > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72343 > > > On Thu Nov 10 15:55:04 2011, BBYRD wrote:

>> # Temporary kludge: DBD::Sponge dies if @tables is empty. :-( >> @tables or return; >> >> my $dbh2 = $dbh->func("sql_sponge_driver"); >> my $sth = $dbh2->prepare( >> "TABLE_INFO", >> { >> rows => \@tables, >> NAMES => $names, >> } >> ); >> $sth or $dbh->set_err( $DBI::stderr, $dbh2->errstr ); >> return $sth; >> >> >> There is no such attrib called "NAMES". It should be "NAME". This is >> causing the TABLE_INFO call to not use the proper names.

> > I have fixed this and removed the comment/return for "kludge" as > DBD::Sponge does support an empty table array. >

>> Also, can DBD::Sponge be fixed to accept empty-tabled rows?

> > Don't think this is possible or meaningful: > > select * from table where 1 = 0 produces an empty result-set. How are > you supposed to tell the difference between reaching the end of the > result set and there being no result-set.

Did you check out the sqlengine branch where such fixes should be done (and partially did meanwhile)? /Jens

Wed Nov 30 04:25:08 2011 The RT System itself - Status changed from 'patched' to 'open'

Wed Nov 30 04:30:42 2011 bohica [...] ntlworld.com - Correspondence added

On Wed Nov 30 04:25:06 2011, rehsack@googlemail.com wrote: Show quoted text

> Did you check out the sqlengine branch where such fixes should be > done (and partially did meanwhile)? > > /Jens

No, it has been over a year since I used that branch and I forgot about it. I was just trying to help out with the growing bugs. I will revert the change later this morning and you can do it in whatever branch you are using. Martin -- Martin J. Evans Wetherby, UK

Wed Nov 30 06:07:03 2011 bohica [...] ntlworld.com - Correspondence added

On Wed Nov 30 04:30:42 2011, MJEVANS wrote: Show quoted text

> On Wed Nov 30 04:25:06 2011, rehsack@googlemail.com wrote: >

> > Did you check out the sqlengine branch where such fixes should be > > done (and partially did meanwhile)? > > > > /Jens

> > No, it has been over a year since I used that branch and I forgot about > it. I was just trying to help out with the growing bugs. I will revert > the change later this morning and you can do it in whatever branch you > are using. > > Martin

Reverted change in trunk and added to sqlengine branch. Martin -- Martin J. Evans Wetherby, UK

Wed Nov 30 06:07:15 2011 bohica [...] ntlworld.com - Status changed from 'open' to 'patched'

Wed Nov 30 06:11:54 2011 rehsack [...] googlemail.com - Correspondence added

Subject:	Re: [rt.cpan.org #72343] Problem with Sponge driver call in DBI::DBD::SqlEngine
Date:	Wed, 30 Nov 2011 12:11:46 +0100
To:	bug-DBI [...] rt.cpan.org
From:	Jens Rehsack <rehsack [...] googlemail.com>

2011/11/30 Martin J Evans via RT <bug-DBI@rt.cpan.org>: Show quoted text

> Queue: DBI > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72343 > > > On Wed Nov 30 04:30:42 2011, MJEVANS wrote:

>> On Wed Nov 30 04:25:06 2011, rehsack@googlemail.com wrote: >>

>> > Did you check out the sqlengine branch where such fixes should be >> > done (and partially did meanwhile)? >> > >> > /Jens

>> >> No, it has been over a year since I used that branch and I forgot about >> it. I was just trying to help out with the growing bugs. I will revert >> the change later this morning and you can do it in whatever branch you >> are using. >> >> Martin

> > Reverted change in trunk and added to sqlengine branch.

I hope I find the required time soon to complete Proc::ProcessTable to start with neded fixes and improvements of S::S and sqlengine DBI branch. Thanks, Martin. /Jens

Wed Nov 30 06:11:54 2011 The RT System itself - Status changed from 'patched' to 'open'

Fri Oct 05 07:13:34 2012 REHSACK [...] cpan.org - Correspondence added

Fix in commit rev 15424

Fri Oct 05 07:13:35 2012 REHSACK [...] cpan.org - Status changed from 'open' to 'patched'

Sat Apr 23 11:08:55 2016 TIMB [...] cpan.org - Correspondence added

Closing as resolved. Thanks!

Sat Apr 23 11:09:01 2016 TIMB [...] cpan.org - Status changed from 'patched' to 'resolved'