Skip Menu |

This queue is for tickets about the DBIx-Class-Schema-Loader CPAN distribution.

Report information
The Basics
Id: 72260
Status: resolved
Priority: 0/
Queue: DBIx-Class-Schema-Loader
People
Owner: Nobody in particular
Requestors: mjgardner [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.07011
Fixed in: (no value)

History Show all quoted text
  Mon Nov 07 17:41:26 2011 mjgardner [...] cpan.org - Ticket created
Subject: custom_column_info hook now gets DCSL::Table object
The DCSL::Base docs say that the coderef assigned to the custom_column_info cosntructor option would get the table name, column name and column info as parameters. With the latest release that firsr parameter is now a DBIx::Class::Schema::Loader::Table object. Please either change it back or (less desirably) fix the docs. I didn't see anything about this in the changelog.
  Mon Nov 07 19:50:40 2011 rkitover [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #72260] custom_column_info hook now gets DCSL::Table object
Date: Mon, 07 Nov 2011 19:50:17 -0500
To: bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From: Rafael Kitover <rkitover [...] cpan.org>
Mark Gardner via RT <bug-DBIx-Class-Schema-Loader@rt.cpan.org> wrote: Show quoted text
>Mon Nov 07 17:41:26 2011: Request 72260 was acted upon. >Transaction: Ticket created by MJGARDNER > Queue: DBIx-Class-Schema-Loader > Subject: custom_column_info hook now gets DCSL::Table object > Broken in: 0.07011 > Severity: Important > Owner: Nobody > Requestors: mjgardner@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72260 > > > >The DCSL::Base docs say that the coderef assigned to the >custom_column_info cosntructor option would get the table name, column >name and column info as parameters. With the latest release that firsr >parameter is now a DBIx::Class::Schema::Loader::Table object. > >Please either change it back or (less desirably) fix the docs. I >didn't >see anything about this in the changelog.
The table object stringifies to the table name.
  Mon Nov 07 19:50:43 2011 The RT System itself - Status changed from 'new' to 'open'
  Mon Nov 07 20:41:07 2011 mjgardner [...] cpan.org - Correspondence added
On Mon Nov 07 19:50:40 2011, RKITOVER wrote: Show quoted text
> The table object stringifies to the table name.
Thanks for that. The change still broke my callback which didn't know to put that parameter in string context. :-) Please patch the docs?
  Wed Nov 09 11:13:38 2011 rkitover [...] cpan.org - Correspondence added
Docs patched in 0.07012.
  Wed Nov 09 11:13:41 2011 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'