Skip Menu |

This queue is for tickets about the CPAN-Site CPAN distribution.

Report information
The Basics
Id: 72243
Status: resolved
Priority: 0/
Queue: CPAN-Site

People
Owner: Nobody in particular
Requestors: MELEZHIK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.09
Fixed in: (no value)



Subject: version compare does not work correct
In CPAN::Site::Index sub register($$$) { my ($package, $this_version, $dist) = @_; # skip your code here return if defined $registered_version && $registered_version > $this_version; # skip your code here } if $registered_version is NOT a version object, than compare `'0.9.1' > '0.10.0'` will give true (the case when regular string compare perl operator get called not version object's one ). The rough path for this is: return if defined $registered_version && version->parse($registered_version) > $this_version;
Subject: Re: [rt.cpan.org #72243] version compare does not work correct
Date: Mon, 7 Nov 2011 12:41:17 +0100
To: Alexey Melezhik via RT <bug-CPAN-Site [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
* Alexey Melezhik via RT (bug-CPAN-Site@rt.cpan.org) [111107 10:38]: Show quoted text
> Mon Nov 07 05:38:09 2011: Request 72243 was acted upon. > Transaction: Ticket created by MELEZHIK > Queue: CPAN-Site > Subject: version compare does not work correct > Broken in: 1.09 > Severity: Critical > Owner: Nobody > Requestors: MELEZHIK@cpan.org > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72243 > > > if $registered_version is NOT a version object, than compare `'0.9.1' > > '0.10.0'` will give true (the case when regular string compare perl > operator get called not version object's one ). The rough path for this > is: > > return if defined $registered_version > && version->parse($registered_version) > $this_version;
The last changes to that code were your changes :( Are you sure, this time? -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
I took source code from http://cpansearch.perl.org/src/MARKOV/CPAN- Site-1.09/lib/CPAN/Site/Index.pm Пнд Ноя 07 06:41:30 2011, solutions@overmeer.net писал: Show quoted text
> * Alexey Melezhik via RT (bug-CPAN-Site@rt.cpan.org) [111107 10:38]:
> > Mon Nov 07 05:38:09 2011: Request 72243 was acted upon. > > Transaction: Ticket created by MELEZHIK > > Queue: CPAN-Site > > Subject: version compare does not work correct > > Broken in: 1.09 > > Severity: Critical > > Owner: Nobody > > Requestors: MELEZHIK@cpan.org > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=72243 > > > > > if $registered_version is NOT a version object, than compare
`'0.9.1' > Show quoted text
> > '0.10.0'` will give true (the case when regular string compare perl > > operator get called not version object's one ). The rough path for
this Show quoted text
> > is: > > > > return if defined $registered_version > > && version->parse($registered_version) > $this_version;
> > The last changes to that code were your changes :( > Are you sure, this time?
release as 1.10. Let's hope this finally works