Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 72086
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: EDAVIS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.116
Fixed in: (no value)

History Show all quoted text
  Tue Nov 01 07:45:55 2011 EDAVIS [...] cpan.org - Ticket created
Subject: ProhibitUnusedCapture false positive with /e and parens
s/(.)/($1)/e; The above code gives a false positive from RegularExpressions::ProhibitUnusedCapture.
  Tue Nov 01 11:52:24 2011 wyant [...] cpan.org - Correspondence added
On Tue Nov 01 07:45:55 2011, EDAVIS wrote: Show quoted text
> s/(.)/($1)/e; > > The above code gives a false positive from > RegularExpressions::ProhibitUnusedCapture.
Thank you for reporting this. The problem also occurs for s/(.)/ { $1 } /e; and possibly for things like s/(.)/@{[ ( $1 ) ]}/ and for regular expressions involving (?{}). I have not actually checked the cases not involving /e, but the underlying cause is the same, and the fix _should_ work for these too. Patch committed as SVN revision 4092.
  Tue Nov 01 11:52:25 2011 The RT System itself - Status changed from 'new' to 'open'
  Tue Nov 01 11:52:25 2011 wyant [...] cpan.org - Status changed from 'open' to 'patched'
  Wed Jul 11 04:03:51 2012 thaljef [...] cpan.org - Correspondence added
This was fixed in Perl-Critic-1.117 -- Jeffrey Thalhammer Imaginative Software Systems www.imaginative-software.com
  Wed Jul 11 04:03:52 2012 The RT System itself - Status changed from 'patched' to 'open'
  Wed Jul 11 04:03:52 2012 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'