Skip Menu |

This queue is for tickets about the List-Maker CPAN distribution.

Report information
The Basics
Id: 72021
Status: open
Priority: 0/
Queue: List-Maker

People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Incorrect global override
The CORE::GLOBAL::glob override forwards to File::Glob::bsd_glob if the caller did not load List::Maker. That is not what perl uses by default, which would be File::Glob::csh_glob instead. Hence, loading List::Maker anywhere in a program will cause <* .*> to stop working elsewhere. Why not just export glob in import, instead of overriding it globally? And if you need to override it globally, for some reason, then you should save the previous CORE::GLOBAL::glob in a variable, if it exists, and then delegate to that, or to the built-in glob function if CORE::GLOBAL::glob does not exist.
Subject: Re: [rt.cpan.org #72021] Incorrect global override
Date: Sat, 29 Oct 2011 12:02:26 +1100
To: bug-List-Maker [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Fixed and uploaded to CPAN. Many thanks! Damian PS: List::Maker previously followed the documented behaviour of File::Glob, rather than the actual behaviour. So there's arguably a bug in File::Glob as well. ;-)
On Fri Oct 28 21:03:15 2011, damian@conway.org wrote: Show quoted text
> Fixed and uploaded to CPAN. > Many thanks! > > Damian > > PS: List::Maker previously followed the documented behaviour of > File::Glob, rather than the actual behaviour. So there's arguably a > bug in File::Glob as well. ;-)
See <http://perl5.git.perl.org/perl.git/commitdiff/ffd7a473>.
Subject: Re: [rt.cpan.org #72021] Incorrect global override
Date: Sun, 30 Oct 2011 12:21:43 +1100
To: bug-List-Maker [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Show quoted text
Excellent. Thanks again. Damian