Skip Menu |

This queue is for tickets about the Test-CheckChanges CPAN distribution.

Report information
The Basics
Id: 71995
Status: open
Priority: 0/
Queue: Test-CheckChanges

People
Owner: Nobody in particular
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.14
Fixed in: (no value)



Subject: Should skip unless $ENV{RELEASE_TESTING}
This test is useless for a user of the distribution: it is too late, and not his duty to fix it. It is only useful for the distribution author. So ok_changes() should skip completely (and report one skipped test) unless $ENV{RELEASE_TESTING} is set and true. -- Olivier Mengué - http://perlresume.org/DOLMEN
On 2011-10-27 15:26:51, DOLMEN wrote: Show quoted text
> This test is useless for a user of the distribution: it is too late, and > not his duty to fix it. > It is only useful for the distribution author. > > So ok_changes() should skip completely (and report one skipped test) > unless $ENV{RELEASE_TESTING} is set and true.
I don't think this should be set inside ok_changes itself, but rather by the caller - who may decide to run it at AUTHOR_TESTING time, rather than RELEASE_TESTING.