Skip Menu |

This queue is for tickets about the Shipment CPAN distribution.

Report information
The Basics
Id: 71949
Status: resolved
Priority: 0/
Queue: Shipment

People
Owner: andrew [...] pullingshots.ca
Requestors: paul.vlasov [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.01111360
  • 0.01111361
  • 0.01111450
  • 0.01111510
  • 0.01111730
  • 0.01112490
  • 0.01112650
Fixed in: 0.01113430



Subject: Measurement system hardoced (LBS) on method _build_services Shipment::UPS 0.01112650
Date: Wed, 26 Oct 2011 13:41:43 +0400
To: bug-Shipment [...] rt.cpan.org
From: Pavel Vlasov <paul.vlasov [...] gmail.com>
Good morning! When I try to get services between two cities in Europe (ex. Berlin and Zurich). 36 my $shipment = Shipment::UPS->new( ....); 51 foreach my $service ( $shipment->all_services ) { 52 print $service->id . " (" . $service->name . " | ".$service->cost . ")\n"; 53 } I had error "This measurement system is not valid for the selected country". I try to investigate this error and found that Shipment/UPS.pm consist on method "_build_services" line 221, hardoced Code => 'LBS'. So for European country it should be 'KGS'. Could you may to check it? My environment: Module: Shipment::UPS 0.01112650 Perl version: This is perl, v5.10.0 built for i386-linux-thread-multi OS: Linux 2.6.18-028stab091.2 #1 SMP Fri Jun 3 00:02:40 MSD 2011 i686 i686 i386 GNU/Linux Thanks you. -- Best regards, Pavel Vlasov Please consider the environment before printing this email.
As of v0.01113430, the _build_services method of Shipment::UPS will respect what has been set in the weight_unit attribute. To override the default weight unit (lb), you can do: my $shipment = Shipment::UPS->new( ... weight_unit => 'kg', ); For details about the fix, please see https://github.com/pullingshots/Shipment/commit/eea224f84612fffaab6e75fb7d73a550d3292fba
Subject: Re: [rt.cpan.org #71949] Measurement system hardoced (LBS) on method _build_services Shipment::UPS 0.01112650
Date: Sat, 10 Dec 2011 10:03:35 +0300
To: bug-Shipment [...] rt.cpan.org
From: Pavel Vlasov <paul.vlasov [...] gmail.com>
Good morning Andrew! Thank you! What do you think if I fork your project and add feature (that show soap request reply or responce for debugging) On Fri, Dec 9, 2011 at 9:08 PM, Andrew Baerg via RT < bug-Shipment@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=71949 > > > As of v0.01113430, the _build_services method of Shipment::UPS will > respect what has been set in the weight_unit attribute. > > To override the default weight unit (lb), you can do: > > my $shipment = Shipment::UPS->new( > > ... > > weight_unit => 'kg', > ); > > For details about the fix, please see > > https://github.com/pullingshots/Shipment/commit/eea224f84612fffaab6e75fb7d73a550d3292fba >
-- Best regards, Pavel Vlasov Please consider the environment before printing this email.
Subject: Re: [rt.cpan.org #71949] Measurement system hardoced (LBS) on method _build_services Shipment::UPS 0.01112650
Date: Sat, 10 Dec 2011 10:33:48 -0700
To: bug-Shipment [...] rt.cpan.org
From: Andrew Baerg <andrew.baerg [...] gmail.com>
Of Course! That is why it is published on Github... you can fork it and then do a pull request so that your features can be brought into the ditribution on cpan. If you have any questions, do not hesitate to ask. Thanks! Andrew On Sat, 10 Dec 2011, 00:03:45 MST, Pavel Vlasov via RT <bug-Shipment@rt.cpan.org> wrote: Show quoted text
>              Queue: Shipment >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=71949 > > > Good morning Andrew! > > Thank you! > What do you think if I fork your project and add feature (that show soap > request reply or responce for debugging) > > On Fri, Dec 9, 2011 at 9:08 PM, Andrew Baerg via RT < > bug-Shipment@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=71949 > > > > > As of v0.01113430, the _build_services method of Shipment::UPS will > > respect what has been set in the weight_unit attribute. > > > > To override the default weight unit (lb), you can do: > > > > my $shipment = Shipment::UPS->new( > > > > ... > > > > weight_unit => 'kg', > > ); > > > > For details about the fix, please see > > > > https://github.com/pullingshots/Shipment/commit/eea224f84612fffaab6e75fb7d73a550d3292fba > >
> > > > -- > Best regards, Pavel Vlasov > Please consider the environment before printing this email. >