| Subject: | TAP::Harness::Archive::runtests(): Unreachable statement |
In TAP::Harness::Archive::runtests() we find this code at line 238:
print "\nTAP Archive created at $output_file\n" unless
$self->verbosity < -1;
This code will never be exercised. At this point 'verbosity' is not
found at the top-level in the object. It's actually an element in the
'formatter' element of the object's data structure.
What would probably be better would be either this:
print "\nTAP Archive created at $output_file\n"
unless $self->{formatter}->{verbosity} < -1;
... or deleting the statement altogether, on the premise that no one has
ever seen the code at the end of a harness run and therefore will not be
surprised when the code is deleted.
Thank you very much.
Jim Keenan