| Subject: | TAP::Harness::aggregate_tests(): superfluous variable assignment |
In TAP::Harness::aggregate_tests(), at line 656 there is an assignment
of $self->jobs to a lexical variable $jobs.
However, $jobs is never subsequently used in this scope. It may safely
be deleted.
Thank you very much.
Jim Keenan
| Subject: | tap.harness.superfluous.variable.txt |
653 sub aggregate_tests {
654 my ( $self, $aggregate, @tests ) = @_;
655
656 my $jobs = $self->jobs; ##### <- $jobs is never used in this subroutine
657 my $scheduler = $self->make_scheduler(@tests);
658
659 # #12458
660 local $ENV{HARNESS_IS_VERBOSE} = 1
661 if $self->formatter->verbosity > 0;
662
663 # Formatter gets only names.
664 $self->formatter->prepare( map { $_->description } $scheduler->get_a ll );
665
666 if ( $self->jobs > 1 ) {
667 $self->_aggregate_parallel( $aggregate, $scheduler );
668 }
669 else {
670 $self->_aggregate_single( $aggregate, $scheduler );
671 }
672
673 return;
674 }