Bug #71657 for Unicode-LineBreak: Fix provides

Thu Oct 13 10:38:11 2011 xavier [...] bachelot.org - Ticket created

Subject:	Fix provides
Date:	Thu, 13 Oct 2011 16:37:44 +0200
To:	bug-Unicode-LineBreak [...] rt.cpan.org
From:	Xavier Bachelot <xavier [...] bachelot.org>

Hi, I'm packaging this module for Fedora and I've had issues with RPM Provides auto-detection. I worked this around with the attached patch. Could you please review it and possibly apply, if suitable ? Regards, Xavier

Message body is not shown because sender requested not to inline it.

Thu Oct 13 21:58:25 2011 hatuka [...] nezumi.nu - Correspondence added 10 min

Hi Xavier, On 2011-10月-13 木 10:38:11, xavier@bachelot.org wrote: Show quoted text

> Hi, > > I'm packaging this module for Fedora and I've had issues with RPM > Provides auto-detection. I worked this around with the attached patch. > Could you please review it and possibly apply, if suitable ?

Thanks for your suggestion. KANA_NONSTARTERS, AMBIGUOUS_ALPHABETICS etc. are intended to belong to Unicode::LineBreak namespace (package), not to Unicode::LineBreak::Constants namespace. If change of namespace is needed solely because of ``AutoProv:'' or ``AutoReqProv:'', I believe it is better to add explicit ``Provides:'' line to spec file instead. Defaults.pm.sample　is similar. But in addition this is optional configuration file, and when namespace of $Config was changed in Defaults.pm.sample, LineBreak.pm might be modified. Show quoted text

> Regards, > Xavier

Would you please tell me your comment? Thanks. --- nezumi

Thu Oct 13 21:58:26 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 13 21:58:26 2011 hatuka [...] nezumi.nu - Given to NEZUMI

Mon Oct 17 19:39:31 2011 xavier [...] bachelot.org - Correspondence added

Subject:	Re: [rt.cpan.org #71657] Fix provides
Date:	Tue, 18 Oct 2011 01:39:09 +0200
To:	bug-Unicode-LineBreak [...] rt.cpan.org
From:	Xavier Bachelot <xavier [...] bachelot.org>

Hi Nezumi, On 10/14/2011 03:58 AM, Hatuka*nezumi - IKEDA Soji via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=71657 > > > Hi Xavier, > > On 2011-10月-13 木 10:38:11, xavier@bachelot.org wrote:

>> Hi, >> >> I'm packaging this module for Fedora and I've had issues with RPM >> Provides auto-detection. I worked this around with the attached patch. >> Could you please review it and possibly apply, if suitable ?

> > Thanks for your suggestion. > > KANA_NONSTARTERS, AMBIGUOUS_ALPHABETICS etc. are intended to > belong to Unicode::LineBreak namespace (package), not to > Unicode::LineBreak::Constants namespace. If change of namespace > is needed solely because of ``AutoProv:'' or ``AutoReqProv:'', > I believe it is better to add explicit ``Provides:'' line to spec > file instead. > > Defaults.pm.sample　is similar. But in addition this is optional > configuration file, and when namespace of $Config was changed in > Defaults.pm.sample, LineBreak.pm might be modified. >

>> Regards, >> Xavier

> > Would you please tell me your comment? > > Thanks. > > --- nezumi

The issue I was trying to fix is duplicate provides because of the multiple 'package Unicode::LineBreak' declarations in lib/Unicode/LineBreak.pm, lib/Unicode/LineBreak/Defaults.pm.sample andlib/Unicode/LineBreak/Constants.pm. This resulted in the following rpm provides perl(Text::LineFold) = 2011.03 perl(Unicode::GCString) = 2011.03 perl(Unicode::LineBreak) perl(Unicode::LineBreak) = 2011.05 The patch follows changes suggested by the reviewer (https://bugzilla.redhat.com/show_bug.cgi?id=705372#c6) As the patch is wrong, I will revert back to provides filtering in the rpm spec. Thanks for your time. Regards, Xavier

Mon Oct 17 20:38:14 2011 hatuka [...] nezumi.nu - Correspondence added

Xavier, On 2011-10月-17 月 19:39:31, xavier@bachelot.org wrote: Show quoted text

> Hi Nezumi, > > On 10/14/2011 03:58 AM, Hatuka*nezumi - IKEDA Soji via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=71657 > > > > > Hi Xavier, > > > > On 2011-10月-13 木 10:38:11, xavier@bachelot.org wrote:

> >> Hi, > >> > >> I'm packaging this module for Fedora and I've had issues with RPM > >> Provides auto-detection. I worked this around with the attached patch. > >> Could you please review it and possibly apply, if suitable ?

> > > > Thanks for your suggestion. > > > > KANA_NONSTARTERS, AMBIGUOUS_ALPHABETICS etc. are intended to > > belong to Unicode::LineBreak namespace (package), not to > > Unicode::LineBreak::Constants namespace. If change of namespace > > is needed solely because of ``AutoProv:'' or ``AutoReqProv:'', > > I believe it is better to add explicit ``Provides:'' line to spec > > file instead. > > > > Defaults.pm.sample　is similar. But in addition this is optional > > configuration file, and when namespace of $Config was changed in > > Defaults.pm.sample, LineBreak.pm might be modified. > >

> >> Regards, > >> Xavier

> > > > Would you please tell me your comment? > > > > Thanks. > > > > --- nezumi

> > The issue I was trying to fix is duplicate provides because of the > multiple 'package Unicode::LineBreak' declarations in > lib/Unicode/LineBreak.pm, lib/Unicode/LineBreak/Defaults.pm.sample > andlib/Unicode/LineBreak/Constants.pm. > > This resulted in the following rpm provides > perl(Text::LineFold) = 2011.03 > perl(Unicode::GCString) = 2011.03 > perl(Unicode::LineBreak) > perl(Unicode::LineBreak) = 2011.05 > > The patch follows changes suggested by the reviewer > (https://bugzilla.redhat.com/show_bug.cgi?id=705372#c6) > > As the patch is wrong, I will revert back to provides filtering in the > rpm spec. > > Thanks for your time. > > Regards, > Xavier

Your suggestion may invite imcompatibility. I wish namespaces untouched. I suppose (it's just an idea) following filter line might be useful: %filter_from_provides /perl[(]Unicode::LineBreak[)]$/d Thanks to your important work on packageing U-LB! --- nezumi

Sat Oct 22 09:48:57 2011 hatuka [...] nezumi.nu - Correspondence added 15 min

Closed. Thank you.

Sat Oct 22 09:48:58 2011 hatuka [...] nezumi.nu - Status changed from 'open' to 'resolved'