Skip Menu |

This queue is for tickets about the Git-DescribeVersion CPAN distribution.

Report information
The Basics
Id: 71622
Status: resolved
Priority: 0/
Queue: Git-DescribeVersion

People
Owner: Nobody in particular
Requestors: mca1001 [...] users.sourceforge.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.003
Fixed in: (no value)



Subject: FYI bug, "fatal: Not a git repository: $valid_workingcopy\n"
Hi Randy, Thank you for writing Dist::Zilla::Plugin::Git::DescribeVersion. I had previously hacked something similar, http://perlunit.git.sourceforge.net/git/gitweb.cgi?p=perlunit/perlunit;a=history;f=inc/GetVersion.pm but you're quite right, that is not a sane way to proceed! This is just to let you know about https://rt.cpan.org/Ticket/Display.html?id=71621 ["fatal: Not a git repository: $valid_workingcopy\n" under Dist::Zilla::Plugin::@blah] in which a constellation alignment of packages causes Git::DescribeVersion to fail due to changed $/ ($INPUT_RECORD_SEPARATOR or $RS). I'm not sure there is anything you need to do, except perhaps consider falling back to a different git access mechanism when one fails? I hope this is useful, -- Matthew
Thanks for reporting! I changed it to fallback to the next method on failure as you suggested. I additionally localized $/ for Git::Repository to work around that specific issue.