Bug #71523 for Module-Build: [PATCH] Add test_requires and test

Fri Oct 07 13:25:20 2011 IKEGAMI [...] cpan.org - Ticket created

Subject:

Add test_requires and test_recommends

There's no good way to specify optional modules for tests, so tests are getting skipped left and right in just about every distro. I would like support for test_requires and test_recommends. Patch pushed to git repo: https://github.com/dagolden/module-build/pull/16

Fri Nov 04 14:18:51 2011 dagolden [...] cpan.org - Correspondence added

Thank you, but I'd like to defer this until there is better CPAN::Meta v2 support and consider it together at that time.

Fri Nov 04 14:18:52 2011 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 04 14:19:16 2011 dagolden [...] cpan.org - Subject changed from 'Add test_requires and test_recommends' to '[PATCH] Add test_requires and test_recommends'

Fri Nov 04 14:19:16 2011 dagolden [...] cpan.org - Severity Wishlist changed to Normal

Fri Nov 04 15:08:01 2011 kwilliams [...] cpan.org - Correspondence added

Perl has a pretty long history of treating testing as an integral part of building. It's served the community quite well in lots of ways. That's why there's been no test_requires and test_recommends - because it's considered part of build_requires and build_recommends. I'm not sure it's a good idea to change it, both for back-compatibility reasons and because it seems like it might be a step backwards unless there's some other really compelling reason to want it. -Ken

Fri Nov 04 18:55:17 2011 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date:	Fri, 4 Nov 2011 18:55:08 -0400
To:	bug-Module-Build [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

On Fri, Nov 4, 2011 at 3:08 PM, Ken Williams via RT < bug-Module-Build@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > > > Perl has a pretty long history of treating testing as an integral part > of building. It's served the community quite well in lots of ways. >

Show quoted text

> That's why there's been no test_requires and test_recommends - because > it's considered part of build_requires and build_recommends.

Except there's no build_recommends either. Are you open to accepting a patch to add build_recommends, or would that get deferred too?

Sat Nov 05 00:41:19 2011 kwilliams [...] cpan.org - Correspondence added

On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote: Show quoted text

> Except there's no build_recommends either. Are you open to accepting a > patch to add build_recommends, or would that get deferred too?

I think a build_recommends would be a good idea. I guess I forgot it didn't already exist. I'd defer to David's sense about when to add it though.

Sat Nov 05 02:54:38 2011 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date:	Sat, 5 Nov 2011 02:54:28 -0400
To:	bug-Module-Build [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT < bug-Module-Build@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > > > On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote:

> > Except there's no build_recommends either. Are you open to accepting a > > patch to add build_recommends, or would that get deferred too?

> > I think a build_recommends would be a good idea. I guess I forgot it > didn't already exist. I'd > defer to David's sense about when to add it though. >

On the off chance, patch submitted via github: https://github.com/dagolden/module-build/pull/19

Sat Nov 05 07:09:04 2011 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date:	Sat, 5 Nov 2011 07:08:32 -0400
To:	bug-Module-Build [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT <bug-Module-Build@rt.cpan.org> wrote: Show quoted text

> I think a build_recommends would be a good idea. I guess I forgot it didn't already exist. I'd > defer to David's sense about when to add it though.

At the moment, none of the CPAN clients to my knowledge do anything with recommends. So, while visual warnings are nice, the real change needed is for M::B to spit out version 2 MYMETA files and for the CPAN clients to use those to actually honor recommends, etc. That might have to be my QA hackathon project for the spring. :-) -- David

Sat Nov 05 21:15:15 2011 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #71523] [PATCH] Add test_requires and test_recommends
Date:	Sat, 5 Nov 2011 21:15:05 -0400
To:	bug-Module-Build [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

On Sat, Nov 5, 2011 at 2:54 AM, Eric Brine <ikegami@adaelis.com> wrote: Show quoted text

> On Sat, Nov 5, 2011 at 12:41 AM, Ken Williams via RT < > bug-Module-Build@rt.cpan.org> wrote: >

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=71523 > >> >> On Fri Nov 04 18:55:17 2011, ikegami@adaelis.com wrote:

>> > Except there's no build_recommends either. Are you open to accepting a >> > patch to add build_recommends, or would that get deferred too?

>> >> I think a build_recommends would be a good idea. I guess I forgot it >> didn't already exist. I'd >> defer to David's sense about when to add it though. >>

> > On the off chance, patch submitted via github: > https://github.com/dagolden/module-build/pull/19 > >

Resubmitted to new repo. https://github.com/Perl-Toolchain-Gang/Module-Build/pull/1

Bug #71523 for Module-Build: [PATCH] Add test_requires and test_recommends