Skip Menu |

This queue is for tickets about the Net-Nslookup CPAN distribution.

Report information
The Basics
Id: 71515
Status: resolved
Estimated: 15 min
Priority: 0/
Queue: Net-Nslookup

People
Owner: darren [...] cpan.org
Requestors: mattias [...] webben.nu
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.00
Fixed in: 2.01



Subject: Wrong ip in installation tests?
Date: Fri, 7 Oct 2011 14:07:30 +0200
To: bug-Net-Nslookup [...] rt.cpan.org
From: Mattias Fransson <mattias [...] webben.nu>
Hello, I just tried installing Net::Nslookup through cpan, but it failed as described below. Judging from the errors there does not seem to be any real technical problem, it just seems like the tests are expecting the wrong answers. Just wanted to let you know. Sincerely, Mattias Show quoted text
cpan> install Net::Nslookup
Running install for module 'Net::Nslookup' Running make for D/DA/DARREN/Net-Nslookup-2.00.tar.gz Has already been unwrapped into directory C:\strawberry-perl\cpan\build\Net-Nslookup-2.00-ibecFb Has already been made Running make test C:\strawberry-perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/a.t ...... ok t/cname.t .. ok t/mx.t ..... ok t/ns.t ..... 1/9 # Failed test 'nslookup(domain => 'boston.com', type => NS) -> ns-a.pnap.net' # at t/ns.t line 13. # got: 'ns1.p22.dynect.net' # expected: 'ns-a.pnap.net' # Failed test 'nslookup(domain => 'boston.com', type => NS) -> ns-b.pnap.net' # at t/ns.t line 14. # got: 'ns2.p22.dynect.net' # expected: 'ns-b.pnap.net' # Failed test 'nslookup(domain => 'boston.com', type => NS) -> ns-c.pnap.net' # at t/ns.t line 15. # got: 'ns3.p22.dynect.net' # expected: 'ns-c.pnap.net' # Failed test 'nslookup(domain => 'boston.com', type => NS) -> ns-d.pnap.net' # at t/ns.t line 16. # got: 'ns4.p22.dynect.net' # expected: 'ns-d.pnap.net' # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 64.94.123.36' # at t/ns.t line 20. # got: '204.13.250.22' # expected: '64.94.123.36' # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 64.94.123.4' # at t/ns.t line 21. # got: '204.13.251.22' # expected: '64.94.123.4' # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 64.95.61.36' # at t/ns.t line 22. # got: '208.78.70.22' # expected: '64.95.61.36' # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 64.95.61.4' # at t/ns.t line 23. # got: '208.78.71.22' # expected: '64.95.61.4' # Looks like you failed 8 tests of 9. t/ns.t ..... Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/9 subtests t/ptr.t .... ok Test Summary Report ------------------- t/ns.t (Wstat: 2048 Tests: 9 Failed: 8) Failed tests: 2-9 Non-zero exit status: 8 Files=5, Tests=22, 2 wallclock secs ( 0.09 usr + 0.02 sys = 0.11 CPU) Result: FAIL Failed 1/5 test programs. 8/22 subtests failed. dmake.EXE: Error code 255, while making 'test_dynamic' DARREN/Net-Nslookup-2.00.tar.gz C:\strawberry-perl\c\bin\dmake.EXE test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports DARREN/Net-Nslookup-2.00.tar.gz Running make install make test had returned bad status, won't install without force Failed during this command: DARREN/Net-Nslookup-2.00.tar.gz : make_test NO Show quoted text
cpan>
Subject: Re: [rt.cpan.org #71515] AutoReply: Wrong ip in installation tests?
Date: Fri, 7 Oct 2011 14:57:53 +0200
To: bug-Net-Nslookup [...] rt.cpan.org
From: Mattias Fransson <mattias [...] webben.nu>
I changed the file ns.t to the following to get the installation to finish: #!/usr/bin/perl -w # vim: set ft=perl: use strict; use Test::More tests => 9; my ($res, @res); use_ok("Net::Nslookup"); @res = nslookup(domain => "boston.com", type => "NS"); @res = sort @res; is($res[0], "ns1.p22.dynect.net", "nslookup(domain => 'boston.com', type => NS) -> ns1.p22.dynect.net"); is($res[1], "ns2.p22.dynect.net", "nslookup(domain => 'boston.com', type => NS) -> ns2.p22.dynect.net"); is($res[2], "ns3.p22.dynect.net", "nslookup(domain => 'boston.com', type => NS) -> ns3.p22.dynect.net"); is($res[3], "ns4.p22.dynect.net", "nslookup(domain => 'boston.com', type => NS) -> ns4.p22.dynect.net"); @res = nslookup(domain => "boston.com", type => "NS", recurse => 1); @res = sort @res; is($res[0], "204.13.250.22", "nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 204.13.250.22"); is($res[1], "204.13.251.22", "nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 204.13.251.22"); is($res[2], "208.78.70.22", "nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 208.78.70.22"); is($res[3], "208.78.71.22", "nslookup(domain => 'boston.com', type => NS, recurse => 1) -> 208.78.71.22"); On Fri, Oct 7, 2011 at 2:08 PM, Bugs in Net-Nslookup via RT < bug-Net-Nslookup@rt.cpan.org> wrote: Show quoted text
> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "Wrong ip in installation tests?", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #71515]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=71515 > > Please include the string: > > [rt.cpan.org #71515] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > bug-Net-Nslookup@rt.cpan.org > > ------------------------------------------------------------------------- > Hello, > > I just tried installing Net::Nslookup through cpan, but it failed as > described below. > > Judging from the errors there does not seem to be any real technical > problem, it just seems like the tests are expecting the wrong answers. > > Just wanted to let you know. > > Sincerely, > Mattias >
> cpan> install Net::Nslookup
> Running install for module 'Net::Nslookup' > Running make for D/DA/DARREN/Net-Nslookup-2.00.tar.gz > Has already been unwrapped into directory > C:\strawberry-perl\cpan\build\Net-Nslookup-2.00-ibecFb > Has already been made > Running make test > C:\strawberry-perl\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t > t/a.t ...... ok > t/cname.t .. ok > t/mx.t ..... ok > t/ns.t ..... 1/9 > # Failed test 'nslookup(domain => 'boston.com', type => NS) -> > ns-a.pnap.net' > # at t/ns.t line 13. > # got: 'ns1.p22.dynect.net' > # expected: 'ns-a.pnap.net' > > # Failed test 'nslookup(domain => 'boston.com', type => NS) -> > ns-b.pnap.net' > # at t/ns.t line 14. > # got: 'ns2.p22.dynect.net' > # expected: 'ns-b.pnap.net' > > # Failed test 'nslookup(domain => 'boston.com', type => NS) -> > ns-c.pnap.net' > # at t/ns.t line 15. > # got: 'ns3.p22.dynect.net' > # expected: 'ns-c.pnap.net' > > # Failed test 'nslookup(domain => 'boston.com', type => NS) -> > ns-d.pnap.net' > # at t/ns.t line 16. > # got: 'ns4.p22.dynect.net' > # expected: 'ns-d.pnap.net' > > # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => > 1) > -> 64.94.123.36' > # at t/ns.t line 20. > # got: '204.13.250.22' > # expected: '64.94.123.36' > > # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => > 1) > -> 64.94.123.4' > # at t/ns.t line 21. > # got: '204.13.251.22' > # expected: '64.94.123.4' > > # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => > 1) > -> 64.95.61.36' > # at t/ns.t line 22. > # got: '208.78.70.22' > # expected: '64.95.61.36' > > # Failed test 'nslookup(domain => 'boston.com', type => NS, recurse => > 1) > -> 64.95.61.4' > # at t/ns.t line 23. > # got: '208.78.71.22' > # expected: '64.95.61.4' > # Looks like you failed 8 tests of 9. > t/ns.t ..... Dubious, test returned 8 (wstat 2048, 0x800) > Failed 8/9 subtests > t/ptr.t .... ok > > Test Summary Report > ------------------- > t/ns.t (Wstat: 2048 Tests: 9 Failed: 8) > Failed tests: 2-9 > Non-zero exit status: 8 > Files=5, Tests=22, 2 wallclock secs ( 0.09 usr + 0.02 sys = 0.11 CPU) > Result: FAIL > Failed 1/5 test programs. 8/22 subtests failed. > dmake.EXE: Error code 255, while making 'test_dynamic' > DARREN/Net-Nslookup-2.00.tar.gz > C:\strawberry-perl\c\bin\dmake.EXE test -- NOT OK > //hint// to see the cpan-testers results for installing this module, try: > reports DARREN/Net-Nslookup-2.00.tar.gz > Running make install > make test had returned bad status, won't install without force > Failed during this command: > DARREN/Net-Nslookup-2.00.tar.gz : make_test NO >
> cpan>
> >
You're right, that is a bug, and your fix is correct, as well. I'm going to upload 2.01 today that includes the fix.
This is fixed; change is https://github.com/dlc/net-- nslookup/commit/6ee66356c621c1c72098fc9867f42078205ac6fa .