Skip Menu |

This queue is for tickets about the LWP-UserAgent-Determined CPAN distribution.

Report information
The Basics
Id: 71491
Status: open
Priority: 0/
Queue: LWP-UserAgent-Determined
People
Owner: Nobody in particular
Requestors: IRONCAMEL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.05
Fixed in: (no value)

History Show all quoted text
  Wed Oct 05 23:48:44 2011 IRONCAMEL [...] cpan.org - Ticket created
Subject: tests hang inside 10_determined_test.t
The tests hang right here for us. I'm running ubuntu 11.04, perl 5.14.1. ok 5 # After_count: 3 ok 6 # Trying a nonexistent address, http://www.aoeaoeaoeaoe.int:9876/sntstn # /Trying http://www.aoeaoeaoeaoe.int:9876/sntstn at Wed Oct 5 23:42:48 2011...
  Thu Oct 13 15:20:19 2011 https://www.google.com/accounts/o8/id?id=AItOawlh1OzD0tnqwUMGLrfx3M7nx4vmPj0tHg0 - Correspondence added
From: ewright [...] linescale.com
On Wed Oct 05 23:48:44 2011, IRONCAMEL wrote: Show quoted text
> The tests hang right here for us. I'm running ubuntu 11.04, perl 5.14.1. > > ok 5 > # After_count: 3 > ok 6 > # Trying a nonexistent address, http://www.aoeaoeaoeaoe.int:9876/sntstn > # /Trying http://www.aoeaoeaoeaoe.int:9876/sntstn at Wed Oct 5 > 23:42:48 2011... >
I can confirm this behavior as well on 2 separate installations - starting at test 7 of 13 in 10_determined_test.t while testing a nonexistent address. I'm running Perl 5.14.2 on CentOS 4.8 on one and Perl 5.10.1 on CentOS 5.5 on the other. Please let us know if there's anything we can do to help.
  Thu Oct 13 15:20:20 2011 The RT System itself - Status changed from 'new' to 'open'
  Thu Oct 20 14:11:13 2011 RWSTAUNER [...] cpan.org - Correspondence added
I am experiencing this across the board: perl 5.8.3 / LWP 5.835 perl 5.8.8 / LWP 6.02 perl 5.14.2 / LWP 6.03 This does appear "new", I didn't notice when it started, but sometime earlier this year I was not having this problem. The tests do eventually seem to finish, however they take *forever*. It seems to start faster and then slow down as it fails. Eventually I get this: Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_about_verbose......ok t/10_determined_test....ok 7/13 # Test 11 got: "4" (t/10_determined_test.t at line 83) # Expected: "1" # t/10_determined_test.t line 83 is: ok $before_count, 1; # Test 12 got: "4" (t/10_determined_test.t at line 85) # Expected: "1" # t/10_determined_test.t line 85 is: ok $after_count, 1; t/10_determined_test....FAILED tests 11-12 Failed 2/13 tests, 84.62% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/10_determined_test.t 13 2 11-12 Failed 1/2 test scripts. 2/15 subtests failed. Files=2, Tests=15, 752 wallclock secs ( 0.38 cusr + 0.05 csys = 0.43 CPU) Failed 1/2 test programs. 2/15 subtests failed. make: *** [test_dynamic] Error 255 I have some tests somewhere that test using this module with a mocked LWP::UserAgent... i'll find them and submit them on github. I don't think making actual network requests to fake addresses is necessary to test the functionality.
  Fri Nov 04 15:04:12 2011 RWSTAUNER [...] cpan.org - Correspondence added
Show quoted text
> > I have some tests somewhere that test using this module with a mocked > LWP::UserAgent... > i'll find them and submit them on github. > > I don't think making actual network requests to fake addresses is > necessary to test the functionality.
https://github.com/obra/lwp--useragent--determined/pull/4
  Mon Dec 05 07:54:32 2011 MARKF [...] cpan.org - Correspondence added
Hi Jesse, I'm just bumping this again. By the time you see this I've sent a different pull request for you to fix the above issue from us on github. There's now three solutions in play (all with pull requests) 1. Change the url to google.com (first pull fix) 2. Change the url to bestpractical.com (my suggestion) 3. Mock the whole thing (probably the best fix, but requires the most code changes) Mark.
  Tue Jun 27 18:46:23 2017 ether [...] cpan.org - Correspondence added
On 2011-12-05 04:54:32, MARKF wrote: Show quoted text
> Hi Jesse, > > I'm just bumping this again. By the time you see this I've sent a > different pull request for you to > fix the above issue from us on github. > > There's now three solutions in play (all with pull requests) > > 1. Change the url to google.com (first pull fix) > 2. Change the url to bestpractical.com (my suggestion) > 3. Mock the whole thing (probably the best fix, but requires the most > code changes) > > Mark.
I'm also experiencing this issue. Network tests should always use Test::RequiresInternet, which also allows the user to opt out of tests that use the network by setting NO_NETWORK_TESTING=1 (which that module checks).