Bug #71416 for Devel-PatchPerl: Tests fail in 0.56 / typo

Mon Oct 03 12:08:46 2011 gregoa [...] cpan.org - Ticket created

Subject:

Tests fail in 0.56 / typo

The test suite fails in 0.56 with: make[1]: Entering directory `/tmp/buildd/libdevel-patchperl-perl-0.56' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Sequence (?^...) not recognized in regex; marked by <-- HERE in m/(?^ <-- HERE :5.1(?:[24].\d+|0.1))/ at lib/Devel/PatchPerl.pm line 136. Compilation failed in require at -e line 1. This looks like a typo in lib/Devel/PatchPerl.pm, line 136: qr/(?^:5.1(?:[24].\d+|0.1))/, Propsed fix: diff --git a/lib/Devel/PatchPerl.pm b/lib/Devel/PatchPerl.pm index b9afbbd..963719e 100644 --- a/lib/Devel/PatchPerl.pm +++ b/lib/Devel/PatchPerl.pm @@ -133,7 +133,7 @@ my @patch = ( }, { perl => [ - qr/(?^:5.1(?:[24].\d+|0.1))/, + qr/(?:^5.1(?:[24].\d+|0.1))/, ], subs => [ [ \&_patch_make_ext_pl ], Cheers, gregor, Debian Perl Group

Mon Oct 03 16:31:26 2011 chris [...] bingosnet.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #71416] Tests fail in 0.56 / typo
Date:	Mon, 3 Oct 2011 21:31:12 +0100
To:	gregor herrmann via RT <bug-Devel-PatchPerl [...] rt.cpan.org>
From:	"Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>

On Mon, Oct 03, 2011 at 12:08:47PM -0400, gregor herrmann via RT wrote: Show quoted text

> > The test suite fails in 0.56 with: > > make[1]: Entering directory `/tmp/buildd/libdevel-patchperl-perl-0.56' > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > Sequence (?^...) not recognized in regex; marked by <-- HERE in m/(?^ > <-- HERE :5.1(?:[24].\d+|0.1))/ at lib/Devel/PatchPerl.pm line 136. > Compilation failed in require at -e line 1. > > > This looks like a typo in lib/Devel/PatchPerl.pm, line 136: > > qr/(?^:5.1(?:[24].\d+|0.1))/, >

Not a typo, but a v5.14-ism $ /opt/perl-5.14.0/bin/perl -le 'print "Yes" if shift =~ /(?^:5.1(?:[24].\d+|0.1))/;' 5.14.2 Yes $ /opt/perl-5.12.0/bin/perl -le 'print "Yes" if shift =~ /(?^:5.1(?:[24].\d+|0.1))/;' 5.14.2 Sequence (?^...) not recognized in regex; marked by <-- HERE in m/(?^ <-- HERE :5.1(?:[24].\d+|0.1))/ at -e line 1. Pesky. I've stripped it back to basics and just released version 0.58 to CPAN. Many thanks. -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.

Mon Oct 03 16:31:27 2011 The RT System itself - Status changed from 'new' to 'open'

Mon Oct 03 17:14:30 2011 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #71416] Tests fail in 0.56 / typo
Date:	Mon, 3 Oct 2011 23:14:19 +0200
To:	"chris [...] bingosnet.co.uk via RT" <bug-Devel-PatchPerl [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Mon, 03 Oct 2011 16:31:26 -0400, chris@bingosnet.co.uk via RT wrote: Show quoted text

> > This looks like a typo in lib/Devel/PatchPerl.pm, line 136: > > qr/(?^:5.1(?:[24].\d+|0.1))/,

> Not a typo, but a v5.14-ism

Oh, I didn't know that, thanks for the hint! (Still on 5.12) Show quoted text

> I've stripped it back to basics and just released version 0.58 to CPAN.

Thank you! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key ID: 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe `- NP: Tom Waits: Green Grass

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Sat Mar 03 10:14:18 2012 BINGOS [...] cpan.org - Correspondence added 30 min

This was fixed and released as version 0.58 Many thanks.

Sat Mar 03 10:14:19 2012 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Mar 03 10:14:19 2012 BINGOS [...] cpan.org - Given to BINGOS